From: Adrian Hunter <adrian.hunter@intel.com>
To: Christoph Muellner <christoph.muellner@theobroma-systems.com>,
robh+dt@kernel.org, mark.rutland@arm.com, heiko@sntech.de,
shawn.lin@rock-chips.com, ulf.hansson@linaro.org
Cc: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>,
Michal Simek <michal.simek@xilinx.com>,
Douglas Anderson <dianders@chromium.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Vicente Bergas <vicencb@gmail.com>,
Emil Renner Berthing <kernel@esmil.dk>,
Randy Li <ayaka@soulik.info>, Tony Xie <tony.xie@rock-chips.com>,
Ezequiel Garcia <ezequiel@collabora.com>,
Klaus Goger <klaus.goger@theobroma-systems.com>,
Lin Huang <hl@rock-chips.com>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v2 2/3] dt-bindings: mmc: Add a new property disable-cqe-dcmd.
Date: Fri, 8 Mar 2019 14:46:47 +0200 [thread overview]
Message-ID: <37a96eda-196e-bacf-7ae2-5b9354c70273@intel.com> (raw)
In-Reply-To: <20190307084329.25416-2-christoph.muellner@theobroma-systems.com>
On 7/03/19 10:43 AM, Christoph Muellner wrote:
> This patch documents the new property disable-cqe-dcmd
> for the Arasan eMMC 5.1 driver.
>
> Signed-off-by: Christoph Muellner <christoph.muellner@theobroma-systems.com>
> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
> Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> index 1edbb049cccb..ec699bf98b7c 100644
> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> @@ -44,6 +44,10 @@ Optional Properties:
> properly. Test mode can be used to force the controller to function.
> - xlnx,int-clock-stable-broken: when present, the controller always reports
> that the internal clock is stable even when it is not.
> + - disable-cqe-dcmd: The eMMC 5.1 standard specifies direct commands (DCMDs)
> + as part of the command queue engine (CQE). On controllers with a CQHCI,
> + such as the Arasan eMMC 5.1 host controller, the driver has to enable DCMDs.
> + This is done unless disable-cqe-dcmd is specified.
If "supports-cqe" is in mmc.txt, should "disable-cqe-dcmd" be there also?
WARNING: multiple messages have this Message-ID (diff)
From: Adrian Hunter <adrian.hunter@intel.com>
To: Christoph Muellner <christoph.muellner@theobroma-systems.com>,
robh+dt@kernel.org, mark.rutland@arm.com, heiko@sntech.de,
shawn.lin@rock-chips.com, ulf.hansson@linaro.org
Cc: devicetree@vger.kernel.org,
Emil Renner Berthing <kernel@esmil.dk>,
Viresh Kumar <viresh.kumar@linaro.org>,
Randy Li <ayaka@soulik.info>,
linux-mmc@vger.kernel.org, Michal Simek <michal.simek@xilinx.com>,
Vicente Bergas <vicencb@gmail.com>,
Douglas Anderson <dianders@chromium.org>,
linux-rockchip@lists.infradead.org,
Tony Xie <tony.xie@rock-chips.com>,
Klaus Goger <klaus.goger@theobroma-systems.com>,
linux-arm-kernel@lists.infradead.org,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Philipp Tomsich <philipp.tomsich@theobroma-systems.com>,
Ezequiel Garcia <ezequiel@collabora.com>,
linux-kernel@vger.kernel.org, Lin Huang <hl@rock-chips.com>
Subject: Re: [PATCH v2 2/3] dt-bindings: mmc: Add a new property disable-cqe-dcmd.
Date: Fri, 8 Mar 2019 14:46:47 +0200 [thread overview]
Message-ID: <37a96eda-196e-bacf-7ae2-5b9354c70273@intel.com> (raw)
In-Reply-To: <20190307084329.25416-2-christoph.muellner@theobroma-systems.com>
On 7/03/19 10:43 AM, Christoph Muellner wrote:
> This patch documents the new property disable-cqe-dcmd
> for the Arasan eMMC 5.1 driver.
>
> Signed-off-by: Christoph Muellner <christoph.muellner@theobroma-systems.com>
> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
> Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> index 1edbb049cccb..ec699bf98b7c 100644
> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> @@ -44,6 +44,10 @@ Optional Properties:
> properly. Test mode can be used to force the controller to function.
> - xlnx,int-clock-stable-broken: when present, the controller always reports
> that the internal clock is stable even when it is not.
> + - disable-cqe-dcmd: The eMMC 5.1 standard specifies direct commands (DCMDs)
> + as part of the command queue engine (CQE). On controllers with a CQHCI,
> + such as the Arasan eMMC 5.1 host controller, the driver has to enable DCMDs.
> + This is done unless disable-cqe-dcmd is specified.
If "supports-cqe" is in mmc.txt, should "disable-cqe-dcmd" be there also?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-08 12:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 8:43 [PATCH v2 1/3] mmc: sdhci-of-arasan: Add DTS property to disable DCMDs Christoph Muellner
2019-03-07 8:43 ` Christoph Muellner
2019-03-07 8:43 ` [PATCH v2 2/3] dt-bindings: mmc: Add a new property disable-cqe-dcmd Christoph Muellner
2019-03-07 8:43 ` Christoph Muellner
2019-03-08 12:46 ` Adrian Hunter [this message]
2019-03-08 12:46 ` Adrian Hunter
2019-03-08 13:10 ` Christoph Müllner
2019-03-08 13:10 ` Christoph Müllner
2019-03-08 13:10 ` Christoph Müllner
2019-03-12 13:17 ` Heiko Stuebner
2019-03-12 13:17 ` Heiko Stuebner
2019-03-12 13:17 ` Heiko Stuebner
2019-03-12 14:46 ` Christoph Müllner
2019-03-12 14:46 ` Christoph Müllner
2019-03-12 14:46 ` Christoph Müllner
2019-03-12 17:10 ` Heiko Stübner
2019-03-12 17:10 ` Heiko Stübner
2019-03-12 17:10 ` Heiko Stübner
2019-03-12 17:16 ` Christoph Müllner
2019-03-12 17:16 ` Christoph Müllner
2019-03-12 19:28 ` Rob Herring
2019-03-12 19:28 ` Rob Herring
2019-03-12 19:28 ` Rob Herring
2019-03-07 8:43 ` [PATCH v2 3/3] arm64: dts: rockchip: Disable DCMDs on RK3399's eMMC controller Christoph Muellner
2019-03-07 8:43 ` Christoph Muellner
2019-03-08 12:47 ` [PATCH v2 1/3] mmc: sdhci-of-arasan: Add DTS property to disable DCMDs Adrian Hunter
2019-03-08 12:47 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37a96eda-196e-bacf-7ae2-5b9354c70273@intel.com \
--to=adrian.hunter@intel.com \
--cc=ayaka@soulik.info \
--cc=christoph.muellner@theobroma-systems.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=ezequiel@collabora.com \
--cc=heiko@sntech.de \
--cc=hl@rock-chips.com \
--cc=kernel@esmil.dk \
--cc=klaus.goger@theobroma-systems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=philipp.tomsich@theobroma-systems.com \
--cc=robh+dt@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=tony.xie@rock-chips.com \
--cc=ulf.hansson@linaro.org \
--cc=vicencb@gmail.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.