From: "Maxime Ripard" <mripard@kernel.org>
To: "Douglas Anderson" <dianders@chromium.org>
Cc: airlied@gmail.com, airlied@redhat.com, alain.volmat@foss.st.com,
alexander.deucher@amd.com, alexandre.belloni@bootlin.com,
alison.wang@nxp.com, bbrezillon@kernel.org,
christian.koenig@amd.com, claudiu.beznea@microchip.com,
daniel@ffwll.ch, drawat.floss@gmail.com,
dri-devel@lists.freedesktop.org, javierm@redhat.com,
jernej.skrabec@gmail.com, jfalempe@redhat.com,
jstultz@google.com, kong.kongxinwei@hisilicon.com,
kraxel@redhat.com, linus.walleij@linaro.org,
linux-arm-kernel@lists.infradead.org,
linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sunxi@lists.linux.dev, liviu.dudau@arm.com,
nicolas.ferre@microchip.com, paul.kocialkowski@bootlin.com,
sam@ravnborg.org, samuel@sholland.org,
spice-devel@lists.freedesktop.org, stefan@agner.ch,
suijingfeng@loongson.cn, sumit.semwal@linaro.org,
tiantao6@hisilicon.com, tomi.valkeinen@ideasonboard.com,
tzimmermann@suse.de, virtualization@lists.linux-foundation.org,
wens@csie.org, xinliang.liu@linaro.org, yongqin.liu@linaro.org,
zackr@vmware.com, "Maxime Ripard" <mripard@kernel.org>
Subject: Re: [RFT PATCH 2/6] drm: Call drm_atomic_helper_shutdown() at shutdown time for misc drivers
Date: Mon, 04 Sep 2023 07:58:27 +0000 [thread overview]
Message-ID: <37ab52defccfc95d726451853227bd91.mripard@kernel.org> (raw)
In-Reply-To: <20230901163944.RFT.2.I9115e5d094a43e687978b0699cc1fe9f2a3452ea@changeid>
On Fri, 1 Sep 2023 16:39:53 -0700, Douglas Anderson wrote:
> Based on grepping through the source code these drivers appear to be
> missing a call to drm_atomic_helper_shutdown() at system shutdown
> time. Among other things, this means that if a panel is in use that it
> won't be cleanly powered off at system shutdown time.
>
>
> [ ... ]
Acked-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
WARNING: multiple messages have this Message-ID (diff)
From: "Maxime Ripard" <mripard@kernel.org>
To: "Douglas Anderson" <dianders@chromium.org>
Cc: alexandre.belloni@bootlin.com, xinliang.liu@linaro.org,
tomi.valkeinen@ideasonboard.com, linus.walleij@linaro.org,
liviu.dudau@arm.com, linux-hyperv@vger.kernel.org,
dri-devel@lists.freedesktop.org, wens@csie.org,
jstultz@google.com, kraxel@redhat.com, airlied@gmail.com,
sumit.semwal@linaro.org, yongqin.liu@linaro.org,
samuel@sholland.org, sam@ravnborg.org, javierm@redhat.com,
jernej.skrabec@gmail.com, drawat.floss@gmail.com,
kong.kongxinwei@hisilicon.com, alain.volmat@foss.st.com,
linux-sunxi@lists.linux.dev, suijingfeng@loongson.cn,
tzimmermann@suse.de, alison.wang@nxp.com,
Maxime Ripard <mripard@kernel.org>,
stefan@agner.ch, airlied@redhat.com,
virtualization@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org, jfalempe@redhat.com,
bbrezillon@kernel.org, linux-kernel@vger.kernel.org,
christian.koenig@amd.com, paul.kocialkowski@bootlin.com,
spice-devel@lists.freedesktop.org, daniel@ffwll.ch,
alexander.deucher@amd.com, tiantao6@hisilicon.com,
claudiu.beznea@microchip.com, zackr@vmware.com
Subject: Re: [RFT PATCH 2/6] drm: Call drm_atomic_helper_shutdown() at shutdown time for misc drivers
Date: Mon, 04 Sep 2023 07:58:27 +0000 [thread overview]
Message-ID: <37ab52defccfc95d726451853227bd91.mripard@kernel.org> (raw)
In-Reply-To: <20230901163944.RFT.2.I9115e5d094a43e687978b0699cc1fe9f2a3452ea@changeid>
On Fri, 1 Sep 2023 16:39:53 -0700, Douglas Anderson wrote:
> Based on grepping through the source code these drivers appear to be
> missing a call to drm_atomic_helper_shutdown() at system shutdown
> time. Among other things, this means that if a panel is in use that it
> won't be cleanly powered off at system shutdown time.
>
>
> [ ... ]
Acked-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: "Maxime Ripard" <mripard@kernel.org>
To: "Douglas Anderson" <dianders@chromium.org>
Cc: alexandre.belloni@bootlin.com, xinliang.liu@linaro.org,
tomi.valkeinen@ideasonboard.com, liviu.dudau@arm.com,
linux-hyperv@vger.kernel.org, dri-devel@lists.freedesktop.org,
nicolas.ferre@microchip.com, wens@csie.org, jstultz@google.com,
kraxel@redhat.com, sumit.semwal@linaro.org,
yongqin.liu@linaro.org, samuel@sholland.org, sam@ravnborg.org,
javierm@redhat.com, jernej.skrabec@gmail.com,
drawat.floss@gmail.com, kong.kongxinwei@hisilicon.com,
alain.volmat@foss.st.com, linux-sunxi@lists.linux.dev,
suijingfeng@loongson.cn, tzimmermann@suse.de,
alison.wang@nxp.com, Maxime Ripard <mripard@kernel.org>,
airlied@redhat.com, virtualization@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org, jfalempe@redhat.com,
bbrezillon@kernel.org, linux-kernel@vger.kernel.org,
christian.koenig@amd.com, paul.kocialkowski@bootlin.com,
spice-devel@lists.freedesktop.org, alexander.deucher@amd.com,
tiantao6@hisilicon.com, claudiu.beznea@microchip.com
Subject: Re: [RFT PATCH 2/6] drm: Call drm_atomic_helper_shutdown() at shutdown time for misc drivers
Date: Mon, 04 Sep 2023 07:58:27 +0000 [thread overview]
Message-ID: <37ab52defccfc95d726451853227bd91.mripard@kernel.org> (raw)
In-Reply-To: <20230901163944.RFT.2.I9115e5d094a43e687978b0699cc1fe9f2a3452ea@changeid>
On Fri, 1 Sep 2023 16:39:53 -0700, Douglas Anderson wrote:
> Based on grepping through the source code these drivers appear to be
> missing a call to drm_atomic_helper_shutdown() at system shutdown
> time. Among other things, this means that if a panel is in use that it
> won't be cleanly powered off at system shutdown time.
>
>
> [ ... ]
Acked-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
next prev parent reply other threads:[~2023-09-04 7:58 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 23:39 [RFT PATCH 0/6] drm: drm-misc drivers call drm_atomic_helper_shutdown() at the right times Douglas Anderson
2023-09-01 23:39 ` Douglas Anderson
2023-09-01 23:39 ` [RFT PATCH 1/6] drm/atomic-helper: drm_atomic_helper_shutdown(NULL) should be a noop Douglas Anderson
2023-09-01 23:39 ` Douglas Anderson
2023-09-04 7:55 ` Maxime Ripard
2023-09-04 7:55 ` Maxime Ripard
2023-09-05 21:14 ` Doug Anderson
2023-09-05 21:14 ` Doug Anderson
2023-09-13 18:19 ` Doug Anderson
2023-09-13 18:19 ` Doug Anderson
2023-09-01 23:39 ` [RFT PATCH 2/6] drm: Call drm_atomic_helper_shutdown() at shutdown time for misc drivers Douglas Anderson
2023-09-01 23:39 ` Douglas Anderson
2023-09-01 23:39 ` Douglas Anderson
2023-09-04 7:58 ` Maxime Ripard [this message]
2023-09-04 7:58 ` Maxime Ripard
2023-09-04 7:58 ` Maxime Ripard
2023-09-05 21:06 ` Jernej Škrabec
2023-09-05 21:06 ` Jernej Škrabec
2023-09-05 21:06 ` Jernej Škrabec
2023-09-15 9:11 ` suijingfeng
2023-09-15 9:11 ` suijingfeng
2023-09-15 9:11 ` suijingfeng
2023-09-15 13:44 ` Doug Anderson
2023-09-15 13:44 ` Doug Anderson
2023-09-15 13:44 ` Doug Anderson
2023-09-15 14:02 ` suijingfeng
2023-09-15 14:02 ` suijingfeng
2023-09-15 14:02 ` suijingfeng
2023-09-19 7:31 ` Tomi Valkeinen
2023-09-19 7:31 ` Tomi Valkeinen
2023-09-19 7:31 ` Tomi Valkeinen
2023-09-21 18:46 ` Doug Anderson
2023-09-21 18:46 ` Doug Anderson
2023-09-21 18:46 ` Doug Anderson
2023-09-01 23:39 ` [RFT PATCH 3/6] drm/vc4: Call drm_atomic_helper_shutdown() at shutdown time Douglas Anderson
2023-09-01 23:39 ` Douglas Anderson
2023-09-04 7:58 ` Maxime Ripard
2023-09-04 7:58 ` Maxime Ripard
2023-09-21 18:46 ` Doug Anderson
2023-09-21 18:46 ` Doug Anderson
2023-09-01 23:39 ` [RFT PATCH 4/6] drm/ssd130x: Call drm_atomic_helper_shutdown() at remove time Douglas Anderson
2023-09-01 23:39 ` Douglas Anderson
2023-09-04 7:59 ` Maxime Ripard
2023-09-04 7:59 ` Maxime Ripard
2023-09-21 18:47 ` Doug Anderson
2023-09-21 18:47 ` Doug Anderson
2023-09-01 23:39 ` [RFT PATCH 5/6] drm: Call drm_atomic_helper_shutdown() at shutdown/remove time for misc drivers Douglas Anderson
2023-09-01 23:39 ` Douglas Anderson
2023-09-01 23:39 ` Douglas Anderson
2023-09-04 8:00 ` Maxime Ripard
2023-09-04 8:00 ` Maxime Ripard
2023-09-04 8:00 ` Maxime Ripard
2023-09-19 7:09 ` Tomi Valkeinen
2023-09-19 7:09 ` Tomi Valkeinen
2023-09-19 7:09 ` Tomi Valkeinen
2023-09-21 18:48 ` Doug Anderson
2023-09-21 18:48 ` Doug Anderson
2023-09-21 18:48 ` Doug Anderson
2023-09-01 23:39 ` [RFT PATCH 6/6] drm/hisilicon/kirin: Call drm_atomic_helper_shutdown() at shutdown/unbind time Douglas Anderson
2023-09-01 23:39 ` Douglas Anderson
2023-09-04 8:00 ` Maxime Ripard
2023-09-04 8:00 ` Maxime Ripard
2023-09-21 18:48 ` Doug Anderson
2023-09-21 18:48 ` Doug Anderson
2023-09-13 18:31 ` [RFT PATCH 0/6] drm: drm-misc drivers call drm_atomic_helper_shutdown() at the right times Doug Anderson
2023-09-13 18:31 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37ab52defccfc95d726451853227bd91.mripard@kernel.org \
--to=mripard@kernel.org \
--cc=airlied@gmail.com \
--cc=airlied@redhat.com \
--cc=alain.volmat@foss.st.com \
--cc=alexander.deucher@amd.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alison.wang@nxp.com \
--cc=bbrezillon@kernel.org \
--cc=christian.koenig@amd.com \
--cc=claudiu.beznea@microchip.com \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=drawat.floss@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=jernej.skrabec@gmail.com \
--cc=jfalempe@redhat.com \
--cc=jstultz@google.com \
--cc=kong.kongxinwei@hisilicon.com \
--cc=kraxel@redhat.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=liviu.dudau@arm.com \
--cc=nicolas.ferre@microchip.com \
--cc=paul.kocialkowski@bootlin.com \
--cc=sam@ravnborg.org \
--cc=samuel@sholland.org \
--cc=spice-devel@lists.freedesktop.org \
--cc=stefan@agner.ch \
--cc=suijingfeng@loongson.cn \
--cc=sumit.semwal@linaro.org \
--cc=tiantao6@hisilicon.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
--cc=virtualization@lists.linux-foundation.org \
--cc=wens@csie.org \
--cc=xinliang.liu@linaro.org \
--cc=yongqin.liu@linaro.org \
--cc=zackr@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.