From: Eric Blake <eblake@redhat.com>
To: AlexChen <alex.chen@huawei.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Michael Tokarev" <mjt@tls.msk.ru>,
"Laurent Vivier" <laurent@vivier.eu>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
QEMU <qemu-devel@nongnu.org>,
zhang.zhanghailiang@huawei.com
Subject: Re: [PATCH V2 1/2] plugins: Fix resource leak in connect_socket()
Date: Fri, 6 Nov 2020 07:17:12 -0600 [thread overview]
Message-ID: <37c069f2-b137-b68d-9fb5-45a98b84aa0c@redhat.com> (raw)
In-Reply-To: <5FA4AE11.6060701@huawei.com>
On 11/5/20 7:59 PM, AlexChen wrote:
> Close the fd when the connect() fails.
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Alex Chen <alex.chen@huawei.com>
Your From: line ("AlexChen") is spelled differently than your S-o-b:
line ("Alex Chen"). While this is not fatal to the patch, it is
confusing, so you may want to update your git settings to produce mail
spelled in the same manner as the S-o-b.
Also, although you did manage to send a 0/2 letter, you did not thread
things:
0/2 Message-ID: <5FA4AE0B.1000007@huawei.com>
1/2 Message-ID: Message-ID: <5FA4AE11.6060701@huawei.com>, but no
In-Reply-To: or References: headers, which means it is a new top-level
thread. You may want to figure out why your mail setup is not
preserving threading.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-11-06 13:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 1:59 [PATCH V2 1/2] plugins: Fix resource leak in connect_socket() AlexChen
2020-11-06 13:17 ` Eric Blake [this message]
2020-11-09 8:20 ` AlexChen
2020-11-09 15:53 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37c069f2-b137-b68d-9fb5-45a98b84aa0c@redhat.com \
--to=eblake@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=alex.chen@huawei.com \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.