From: Eric Blake <eblake@redhat.com>
To: AlexChen <alex.chen@huawei.com>
Cc: zhang.zhanghailiang@huawei.com,
"QEMU Trivial" <qemu-trivial@nongnu.org>,
"Michael Tokarev" <mjt@tls.msk.ru>,
"Laurent Vivier" <laurent@vivier.eu>,
QEMU <qemu-devel@nongnu.org>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH V2 1/2] plugins: Fix resource leak in connect_socket()
Date: Mon, 9 Nov 2020 09:53:22 -0600 [thread overview]
Message-ID: <e8b2bb7c-3809-4437-7903-300d6d3bc7bf@redhat.com> (raw)
In-Reply-To: <5FA8FBE4.7000504@huawei.com>
On 11/9/20 2:20 AM, AlexChen wrote:
> On 2020/11/6 21:17, Eric Blake wrote:
>> On 11/5/20 7:59 PM, AlexChen wrote:
>>> Close the fd when the connect() fails.
>>>
>>> Reported-by: Euler Robot <euler.robot@huawei.com>
>>> Signed-off-by: Alex Chen <alex.chen@huawei.com>
>>
>> Your From: line ("AlexChen") is spelled differently than your S-o-b:
>> line ("Alex Chen"). While this is not fatal to the patch, it is
>> confusing, so you may want to update your git settings to produce mail
>> spelled in the same manner as the S-o-b.
>>
>
> Hi Eric,
>
> Thanks for you suggestion, I will modify the user.name of git to "Alex Chen".
>
>> Also, although you did manage to send a 0/2 letter, you did not thread
>> things:
>> 0/2 Message-ID: <5FA4AE0B.1000007@huawei.com>
>> 1/2 Message-ID: Message-ID: <5FA4AE11.6060701@huawei.com>, but no
>> In-Reply-To: or References: headers, which means it is a new top-level
>> thread. You may want to figure out why your mail setup is not
>> preserving threading.
>>
>
> This may be my email settings is wrong, I try to modify the setting and send a patch v3.
Thanks for the rapid turnaround - I can confirm that v3 is indeed nicer
to read.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
prev parent reply other threads:[~2020-11-09 15:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 1:59 [PATCH V2 1/2] plugins: Fix resource leak in connect_socket() AlexChen
2020-11-06 13:17 ` Eric Blake
2020-11-09 8:20 ` AlexChen
2020-11-09 15:53 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8b2bb7c-3809-4437-7903-300d6d3bc7bf@redhat.com \
--to=eblake@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=alex.chen@huawei.com \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.