Re: [PATCH 4/5] sched/arinc653: Reorganize function definition order

From: Dario Faggioli <dfaggioli@suse.com>
To: Jan Beulich <jbeulich@suse.com>,
	Jeff Kubascik <jeff.kubascik@dornerworks.com>
Cc: xen-devel@lists.xenproject.org, xen-devel@dornerworks.com,
	Josh Whitehead <josh.whitehead@dornerworks.com>,
	Stewart Hildebrand <stewart.hildebrand@dornerworks.com>,
	George Dunlap <george.dunlap@citrix.com>
Subject: Re: [PATCH 4/5] sched/arinc653: Reorganize function definition order
Date: Thu, 17 Sep 2020 16:16:31 +0200	[thread overview]
Message-ID: <3828f62a38d84c7fd27cfaacc0d29d428d19d55e.camel@suse.com> (raw)
In-Reply-To: <67010159-2bde-cb52-434c-d75c27f8ce7a@suse.com>

[-- Attachment #1: Type: text/plain, Size: 2262 bytes --]

On Thu, 2020-09-17 at 10:12 +0200, Jan Beulich wrote:
> On 16.09.2020 20:18, Jeff Kubascik wrote:
> > @@ -517,27 +516,35 @@ static const struct scheduler
> > sched_arinc653_def = {
> >      .sched_id       = XEN_SCHEDULER_ARINC653,
> >      .sched_data     = NULL,
> >  
> > +    .global_init    = NULL,
> >      .init           = a653sched_init,
> >      .deinit         = a653sched_deinit,
> >  
> > -    .free_udata     = a653sched_free_udata,
> > -    .alloc_udata    = a653sched_alloc_udata,
> > +    .alloc_pdata    = NULL,
> > +    .switch_sched   = a653sched_switch_sched,
> > +    .deinit_pdata   = NULL,
> > +    .free_pdata     = NULL,
> >  
> > +    .alloc_domdata  = NULL,
> > +    .free_domdata   = NULL,
> > +
> > +    .alloc_udata    = a653sched_alloc_udata,
> >      .insert_unit    = NULL,
> >      .remove_unit    = NULL,
> > +    .free_udata     = a653sched_free_udata,
> >  
> >      .sleep          = a653sched_unit_sleep,
> >      .wake           = a653sched_unit_wake,
> >      .yield          = NULL,
> >      .context_saved  = NULL,
> >  
> > -    .do_schedule    = a653sched_do_schedule,
> > -
> >      .pick_resource  = a653sched_pick_resource,
> > +    .migrate        = NULL,
> >  
> > -    .switch_sched   = a653sched_switch_sched,
> > +    .do_schedule    = a653sched_do_schedule,
> >  
> >      .adjust         = NULL,
> > +    .adjust_affinity= NULL,
> 
> Adding all these not really needed NULL initializers looks to rather
> move
> this scheduler away from all the others.
>
Agreed, no need for more "= NULL". On the contrary, the ones that are
there should go away.

About this:

>  (Oddly enough all of them
> explicitly set .sched_data to NULL - for whatever reason.)
> 
Yes, we decided to keep it like that, back then. I think now it would
be ok for it to go away too.

So, Jeff, feel free to zap it with this patch or series. Or I can send
a patch to zap all of them, as you wish.

Regards
-- 
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]