From: Stewart Hildebrand <Stewart.Hildebrand@dornerworks.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Jeff Kubascik <Jeff.Kubascik@dornerworks.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: xen-devel <xen-devel@dornerworks.com>,
Josh Whitehead <Josh.Whitehead@dornerworks.com>,
George Dunlap <george.dunlap@citrix.com>,
Dario Faggioli <dfaggioli@suse.com>
Subject: RE: [PATCH 5/5] sched/arinc653: Implement CAST-32A multicore scheduling
Date: Thu, 17 Sep 2020 14:57:08 +0000 [thread overview]
Message-ID: <CY1P110MB05519EEB1C9F879D54ECF6F58C3E0@CY1P110MB0551.NAMP110.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <36f7ed35-039c-482b-c04b-0f2348de37f6@citrix.com>
On Thursday, September 17, 2020 10:43 AM, Andrew Cooper wrote:
>On 16/09/2020 19:18, Jeff Kubascik wrote:
>> +/*
>> + * A handle with all zeros represents domain 0 if present, otherwise idle UNIT
>> + */
>> +#define DOM0_HANDLE ((const xen_domain_handle_t){0})
>
>This isn't accurate.
>
>There are systems where dom0 doesn't have a zero UUID (XenServer for
>one), and its easy to create domU's which have a zero UUID. They are
>not unique, and can be changed at any time during the running of the VM.
>
>If you need a unique identifier, then use domid's.
>
>I can't see any legitimate need for the scheduler to handle the UUID at all.
We tried switching it to domid at one point in the past, but the problem was that when a domU reboots (destroy/create) the domid increments, so the schedule would have to be reinstantiated. At least that was the case before a recent patch series allowing to specify domid [1], but Jeff developed this CAST-32A series prior to that. The UUID can be specified in the .cfg file, allowing domUs to reboot and come back up with the same UUID.
Stew
[1] https://lists.xenproject.org/archives/html/xen-devel/2020-02/msg01574.html
>~Andrew
next prev parent reply other threads:[~2020-09-17 14:57 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 18:18 [PATCH 0/5] Multicore support for ARINC653 scheduler Jeff Kubascik
2020-09-16 18:18 ` [PATCH 1/5] sched/arinc653: Clean up comments Jeff Kubascik
2020-09-17 13:24 ` Andrew Cooper
2020-09-18 15:33 ` Jeff Kubascik
2020-09-16 18:18 ` [PATCH 2/5] sched/arinc653: Rename scheduler private structs Jeff Kubascik
2020-09-17 12:09 ` Andrew Cooper
2020-09-17 14:46 ` Dario Faggioli
2020-09-18 15:52 ` Jeff Kubascik
2020-09-16 18:18 ` [PATCH 3/5] sched/arinc653: Clean up function definitions Jeff Kubascik
2020-09-17 8:09 ` Jan Beulich
2020-09-17 14:40 ` Dario Faggioli
2020-09-18 17:43 ` Jeff Kubascik
2020-09-16 18:18 ` [PATCH 4/5] sched/arinc653: Reorganize function definition order Jeff Kubascik
2020-09-17 8:12 ` Jan Beulich
2020-09-17 14:16 ` Dario Faggioli
2020-09-18 18:21 ` Jeff Kubascik
2020-09-17 14:17 ` Andrew Cooper
2020-09-18 18:04 ` Jeff Kubascik
2020-09-18 18:05 ` Jeff Kubascik
2020-09-16 18:18 ` [PATCH 5/5] sched/arinc653: Implement CAST-32A multicore scheduling Jeff Kubascik
2020-09-17 9:04 ` Jürgen Groß
2020-09-17 15:10 ` Stewart Hildebrand
2020-09-17 15:18 ` Jürgen Groß
2020-09-17 15:20 ` Dario Faggioli
2020-09-17 15:59 ` Stewart Hildebrand
2020-09-17 17:30 ` Dario Faggioli
2020-09-18 20:03 ` Jeff Kubascik
2020-09-18 20:34 ` Dario Faggioli
2020-09-22 19:50 ` Andrew Cooper
2020-09-17 14:42 ` Andrew Cooper
2020-09-17 14:57 ` Stewart Hildebrand [this message]
2020-09-17 16:18 ` Andrew Cooper
2020-09-17 17:57 ` Stewart Hildebrand
2020-09-18 19:22 ` Jeff Kubascik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY1P110MB05519EEB1C9F879D54ECF6F58C3E0@CY1P110MB0551.NAMP110.PROD.OUTLOOK.COM \
--to=stewart.hildebrand@dornerworks.com \
--cc=Jeff.Kubascik@dornerworks.com \
--cc=Josh.Whitehead@dornerworks.com \
--cc=andrew.cooper3@citrix.com \
--cc=dfaggioli@suse.com \
--cc=george.dunlap@citrix.com \
--cc=xen-devel@dornerworks.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.