From: Andrew Lunn <andrew@lunn.ch> To: "Arınç ÜNAL" <arinc.unal@arinc9.com> Cc: Daniel Golle <daniel@makrotopia.org>, netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>, Vladimir Oltean <olteanv@gmail.com>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Matthias Brugger <matthias.bgg@gmail.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, Sean Wang <sean.wang@mediatek.com>, Landen Chao <Landen.Chao@mediatek.com>, DENG Qingfang <dqfext@gmail.com>, Philipp Zabel <p.zabel@pengutronix.de>, Sam Shih <Sam.Shih@mediatek.com>, Lorenzo Bianconi <lorenzo@kernel.org>, John Crispin <john@phrozen.org>, Felix Fietkau <nbd@nbd.name>, Luiz Angelo Daros de Luca <luizluca@gmail.com> Subject: Re: [PATCH net-next 14/15] net: dsa: mt7530: introduce driver for MT7988 built-in switch Date: Fri, 31 Mar 2023 14:45:01 +0200 [thread overview] Message-ID: <387b3105-2d70-4906-9573-cfac20a55d3a@lunn.ch> (raw) In-Reply-To: <7d0acaef-0cec-91b9-a5c6-d094b71e3dbd@arinc9.com> > Firstly, all of the functions on the mt7530-mmio driver should be changed > from mt7988_* to mt7530_mmio_*. Same goes for the mt7530-mdio driver too as > some of the functions don't start with mt7530_mdio_*. The MDIO and MMIO > drivers are supposed to be used for the switches the MT7530 DSA driver > supports. The mt7530_ prefix is derived from that. The mmio_ or mdio_ prefix > is derived from, well, the driver itself. There are examples of similar naming schemes in other DSA drivers. For the marvell mv88e6xxx driver, all generic functions use the mv88e6xxx_ prefix. For functions which are specific to a family of marvell switches, we use a prefix for when the feature was introduced. So for example we have mv88e6352_g1_reset(), where that method of resetting the devices was introduced in the mv88e6352. This also gives us some namespace space, so we can also have mv88e6185_g1_reset() which is used for a different family. So i personally don't have a problem using different prefixes within one driver, if it helps with understanding and name space issues. > What I'm going to say next depends on how generic the MMIO and MDIO drivers > are so that they can be used on all MediaTek architecture switches. Let's > say, a new MediaTek switch is introduced. It seems likely that either the > MMIO or MDIO driver will be used to control the switch. Maybe the driver for > this new switch won't be under mt7530.c, like on Realtek, but that doesn't > change the outcome. My experience with silicon vendors is that they like to change the hardware in none backwards compatible ways. So i would actually avoid generic names, it makes it harder to deal with different variants. Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch> To: "Arınç ÜNAL" <arinc.unal@arinc9.com> Cc: Daniel Golle <daniel@makrotopia.org>, netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>, Vladimir Oltean <olteanv@gmail.com>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Matthias Brugger <matthias.bgg@gmail.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, Sean Wang <sean.wang@mediatek.com>, Landen Chao <Landen.Chao@mediatek.com>, DENG Qingfang <dqfext@gmail.com>, Philipp Zabel <p.zabel@pengutronix.de>, Sam Shih <Sam.Shih@mediatek.com>, Lorenzo Bianconi <lorenzo@kernel.org>, John Crispin <john@phrozen.org>, Felix Fietkau <nbd@nbd.name>, Luiz Angelo Daros de Luca <luizluca@gmail.com> Subject: Re: [PATCH net-next 14/15] net: dsa: mt7530: introduce driver for MT7988 built-in switch Date: Fri, 31 Mar 2023 14:45:01 +0200 [thread overview] Message-ID: <387b3105-2d70-4906-9573-cfac20a55d3a@lunn.ch> (raw) In-Reply-To: <7d0acaef-0cec-91b9-a5c6-d094b71e3dbd@arinc9.com> > Firstly, all of the functions on the mt7530-mmio driver should be changed > from mt7988_* to mt7530_mmio_*. Same goes for the mt7530-mdio driver too as > some of the functions don't start with mt7530_mdio_*. The MDIO and MMIO > drivers are supposed to be used for the switches the MT7530 DSA driver > supports. The mt7530_ prefix is derived from that. The mmio_ or mdio_ prefix > is derived from, well, the driver itself. There are examples of similar naming schemes in other DSA drivers. For the marvell mv88e6xxx driver, all generic functions use the mv88e6xxx_ prefix. For functions which are specific to a family of marvell switches, we use a prefix for when the feature was introduced. So for example we have mv88e6352_g1_reset(), where that method of resetting the devices was introduced in the mv88e6352. This also gives us some namespace space, so we can also have mv88e6185_g1_reset() which is used for a different family. So i personally don't have a problem using different prefixes within one driver, if it helps with understanding and name space issues. > What I'm going to say next depends on how generic the MMIO and MDIO drivers > are so that they can be used on all MediaTek architecture switches. Let's > say, a new MediaTek switch is introduced. It seems likely that either the > MMIO or MDIO driver will be used to control the switch. Maybe the driver for > this new switch won't be under mt7530.c, like on Realtek, but that doesn't > change the outcome. My experience with silicon vendors is that they like to change the hardware in none backwards compatible ways. So i would actually avoid generic names, it makes it harder to deal with different variants. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-31 12:45 UTC|newest] Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-30 15:19 [PATCH net-next 00/15] net: dsa: add support for MT7988 Daniel Golle 2023-03-30 15:19 ` Daniel Golle 2023-03-30 15:19 ` [PATCH net-next 01/15] net: dsa: mt7530: make some noise if register read fails Daniel Golle 2023-03-30 15:19 ` Daniel Golle 2023-03-30 20:58 ` Andrew Lunn 2023-03-30 20:58 ` Andrew Lunn 2023-03-30 15:19 ` [PATCH net-next 02/15] net: dsa: mt7530: refactor SGMII PCS creation Daniel Golle 2023-03-30 15:19 ` Daniel Golle 2023-03-30 20:59 ` Andrew Lunn 2023-03-30 20:59 ` Andrew Lunn 2023-03-30 15:20 ` [PATCH net-next 03/15] net: dsa: mt7530: use unlocked regmap accessors Daniel Golle 2023-03-30 15:20 ` Daniel Golle 2023-03-30 21:01 ` Andrew Lunn 2023-03-30 21:01 ` Andrew Lunn 2023-03-30 15:20 ` [PATCH net-next 04/15] net: dsa: mt7530: use regmap to access switch register space Daniel Golle 2023-03-30 15:20 ` Daniel Golle 2023-03-30 21:02 ` Andrew Lunn 2023-03-30 21:02 ` Andrew Lunn 2023-03-31 2:28 ` Daniel Golle 2023-03-31 2:28 ` Daniel Golle 2023-03-30 15:21 ` [PATCH net-next 05/15] net: dsa: mt7530: move SGMII PCS creation to mt7530_probe function Daniel Golle 2023-03-30 15:21 ` Daniel Golle 2023-03-30 21:02 ` Andrew Lunn 2023-03-30 21:02 ` Andrew Lunn 2023-03-30 15:21 ` [PATCH net-next 06/15] net: dsa: mt7530: introduce mutex helpers Daniel Golle 2023-03-30 15:21 ` Daniel Golle 2023-03-30 15:21 ` [PATCH net-next 07/15] net: dsa: mt7530: move p5_intf_modes() function to mt7530.c Daniel Golle 2023-03-30 15:21 ` Daniel Golle 2023-03-30 15:22 ` [PATCH net-next 08/15] net: dsa: mt7530: introduce mt7530_probe_common helper function Daniel Golle 2023-03-30 15:22 ` Daniel Golle 2023-03-30 15:22 ` [PATCH net-next 09/15] net: dsa: mt7530: introduce mt7530_remove_common " Daniel Golle 2023-03-30 15:22 ` Daniel Golle 2023-03-30 15:22 ` [PATCH net-next 10/15] net: dsa: mt7530: split-off common parts from mt7531_setup Daniel Golle 2023-03-30 15:22 ` Daniel Golle 2023-03-30 15:22 ` [PATCH net-next 11/15] net: dsa: mt7530: introduce separate MDIO driver Daniel Golle 2023-03-30 15:22 ` Daniel Golle 2023-03-30 15:23 ` [PATCH net-next 12/15] net: dsa: mt7530: skip locking if MDIO bus isn't present Daniel Golle 2023-03-30 15:23 ` Daniel Golle 2023-03-30 15:23 ` [PATCH net-next 13/15] net: dsa: mt7530: add support for 10G link modes for CPU port Daniel Golle 2023-03-30 15:23 ` Daniel Golle 2023-04-01 8:56 ` Arınç ÜNAL 2023-04-01 8:56 ` Arınç ÜNAL 2023-04-01 13:05 ` Daniel Golle 2023-04-01 13:05 ` Daniel Golle 2023-03-30 15:23 ` [PATCH net-next 14/15] net: dsa: mt7530: introduce driver for MT7988 built-in switch Daniel Golle 2023-03-30 15:23 ` Daniel Golle 2023-03-30 21:03 ` Andrew Lunn 2023-03-30 21:03 ` Andrew Lunn 2023-03-31 5:50 ` Arınç ÜNAL 2023-03-31 5:50 ` Arınç ÜNAL 2023-03-31 10:16 ` Daniel Golle 2023-03-31 10:16 ` Daniel Golle 2023-03-31 12:06 ` Arınç ÜNAL 2023-03-31 12:06 ` Arınç ÜNAL 2023-03-31 12:45 ` Andrew Lunn [this message] 2023-03-31 12:45 ` Andrew Lunn 2023-03-31 13:18 ` Arınç ÜNAL 2023-03-31 13:18 ` Arınç ÜNAL 2023-03-31 13:19 ` Arınç ÜNAL 2023-03-31 13:19 ` Arınç ÜNAL 2023-03-31 14:10 ` Daniel Golle 2023-03-31 14:10 ` Daniel Golle 2023-03-31 14:11 ` Arınç ÜNAL 2023-03-31 14:11 ` Arınç ÜNAL 2023-03-31 20:07 ` Arınç ÜNAL 2023-03-31 20:07 ` Arınç ÜNAL 2023-03-31 20:33 ` Daniel Golle 2023-03-31 20:33 ` Daniel Golle 2023-04-01 8:05 ` Luiz Angelo Daros de Luca 2023-04-01 8:05 ` Luiz Angelo Daros de Luca 2023-03-30 15:23 ` [PATCH 15/15] dt-bindings: net: dsa: mediatek,mt7530: add mediatek,mt7988-switch Daniel Golle 2023-03-30 15:23 ` Daniel Golle 2023-03-31 5:27 ` Arınç ÜNAL 2023-03-31 5:27 ` Arınç ÜNAL 2023-04-03 18:23 ` Daniel Golle 2023-04-03 18:23 ` Daniel Golle 2023-03-31 5:27 ` [PATCH net-next 00/15] net: dsa: add support for MT7988 Arınç ÜNAL 2023-03-31 5:27 ` Arınç ÜNAL
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=387b3105-2d70-4906-9573-cfac20a55d3a@lunn.ch \ --to=andrew@lunn.ch \ --cc=Landen.Chao@mediatek.com \ --cc=Sam.Shih@mediatek.com \ --cc=angelogioacchino.delregno@collabora.com \ --cc=arinc.unal@arinc9.com \ --cc=daniel@makrotopia.org \ --cc=davem@davemloft.net \ --cc=dqfext@gmail.com \ --cc=edumazet@google.com \ --cc=f.fainelli@gmail.com \ --cc=john@phrozen.org \ --cc=kuba@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux@armlinux.org.uk \ --cc=lorenzo@kernel.org \ --cc=luizluca@gmail.com \ --cc=matthias.bgg@gmail.com \ --cc=nbd@nbd.name \ --cc=netdev@vger.kernel.org \ --cc=olteanv@gmail.com \ --cc=p.zabel@pengutronix.de \ --cc=pabeni@redhat.com \ --cc=sean.wang@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.