From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Yong Wu <yong.wu@mediatek.com>, Joerg Roedel <joro@8bytes.org>,
Will Deacon <will@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: Robin Murphy <robin.murphy@arm.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
iommu@lists.linux.dev, linux-mediatek@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, mingyuan.ma@mediatek.com,
yf.wang@mediatek.com, jianjiao.zeng@mediatek.com,
chengci.xu@mediatek.com, youlin.pei@mediatek.com
Subject: Re: [PATCH v8 1/7] dt-bindings: mediatek: mt8188: Add binding for MM & INFRA IOMMU
Date: Wed, 8 Mar 2023 11:35:19 +0100 [thread overview]
Message-ID: <388e2274-d46a-68a4-3e85-5bd597085041@linaro.org> (raw)
In-Reply-To: <20230307080555.14399-2-yong.wu@mediatek.com>
On 07/03/2023 09:05, Yong Wu wrote:
> From: "Chengci.Xu" <chengci.xu@mediatek.com>
>
> Add descriptions for mt8188 IOMMU which also use ARM Short-Descriptor
> translation table format.
>
> In mt8188, there are two smi-common HW and IOMMU, one is for vdo(video
> output), the other is for vpp(video processing pipe). They connects
> with different smi-larbs, then some setting(larbid_remap) is different.
> Differentiate them with the compatible string.
>
> Something like this:
>
> IOMMU(VDO) IOMMU(VPP)
> | |
> SMI_COMMON_VDO SMI_COMMON_VPP
>
> --------------- ----------------
> | | ... | | ...
> larb0 larb2 ... larb1 larb3 ...
>
> We also have an IOMMU that is for infra master like PCIe.
> And infra master don't have the larb and ports.
>
> Signed-off-by: Chengci.Xu <chengci.xu@mediatek.com>
> Reviewed-by: Yong Wu <yong.wu@mediatek.com>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Indeed, I missed broken checkpatch/DCO chain.
NAK. Please fix the chain.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Yong Wu <yong.wu@mediatek.com>, Joerg Roedel <joro@8bytes.org>,
Will Deacon <will@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: Robin Murphy <robin.murphy@arm.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
iommu@lists.linux.dev, linux-mediatek@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, mingyuan.ma@mediatek.com,
yf.wang@mediatek.com, jianjiao.zeng@mediatek.com,
chengci.xu@mediatek.com, youlin.pei@mediatek.com
Subject: Re: [PATCH v8 1/7] dt-bindings: mediatek: mt8188: Add binding for MM & INFRA IOMMU
Date: Wed, 8 Mar 2023 11:35:19 +0100 [thread overview]
Message-ID: <388e2274-d46a-68a4-3e85-5bd597085041@linaro.org> (raw)
In-Reply-To: <20230307080555.14399-2-yong.wu@mediatek.com>
On 07/03/2023 09:05, Yong Wu wrote:
> From: "Chengci.Xu" <chengci.xu@mediatek.com>
>
> Add descriptions for mt8188 IOMMU which also use ARM Short-Descriptor
> translation table format.
>
> In mt8188, there are two smi-common HW and IOMMU, one is for vdo(video
> output), the other is for vpp(video processing pipe). They connects
> with different smi-larbs, then some setting(larbid_remap) is different.
> Differentiate them with the compatible string.
>
> Something like this:
>
> IOMMU(VDO) IOMMU(VPP)
> | |
> SMI_COMMON_VDO SMI_COMMON_VPP
>
> --------------- ----------------
> | | ... | | ...
> larb0 larb2 ... larb1 larb3 ...
>
> We also have an IOMMU that is for infra master like PCIe.
> And infra master don't have the larb and ports.
>
> Signed-off-by: Chengci.Xu <chengci.xu@mediatek.com>
> Reviewed-by: Yong Wu <yong.wu@mediatek.com>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Indeed, I missed broken checkpatch/DCO chain.
NAK. Please fix the chain.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-08 10:36 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 8:05 [PATCH v8 0/7] MT8188 IOMMU SUPPORT Yong Wu
2023-03-07 8:05 ` Yong Wu
2023-03-07 8:05 ` [PATCH v8 1/7] dt-bindings: mediatek: mt8188: Add binding for MM & INFRA IOMMU Yong Wu
2023-03-07 8:05 ` Yong Wu
2023-03-07 9:51 ` AngeloGioacchino Del Regno
2023-03-07 9:51 ` AngeloGioacchino Del Regno
2023-03-08 10:35 ` Krzysztof Kozlowski [this message]
2023-03-08 10:35 ` Krzysztof Kozlowski
2023-03-14 2:41 ` Yong Wu (吴勇)
2023-03-14 2:41 ` Yong Wu (吴勇)
2023-03-14 6:46 ` Krzysztof Kozlowski
2023-03-14 6:46 ` Krzysztof Kozlowski
2023-03-14 10:14 ` Yong Wu (吴勇)
2023-03-14 14:08 ` Krzysztof Kozlowski
2023-03-14 14:08 ` Krzysztof Kozlowski
2023-03-07 8:05 ` [PATCH v8 2/7] iommu/mediatek: Set dma_mask for PGTABLE_PA_35_EN Yong Wu
2023-03-07 8:05 ` Yong Wu
2023-03-07 9:53 ` AngeloGioacchino Del Regno
2023-03-07 9:53 ` AngeloGioacchino Del Regno
2023-03-07 8:05 ` [PATCH v8 3/7] iommu/mediatek: Fix two IOMMU share pagetable issue Yong Wu
2023-03-07 8:05 ` Yong Wu
2023-03-07 8:05 ` [PATCH v8 4/7] iommu/mediatek: Adjust mtk_iommu_config flow Yong Wu
2023-03-07 8:05 ` Yong Wu
2023-03-07 8:05 ` [PATCH v8 5/7] iommu/mediatek: Add enable IOMMU SMC command for INFRA master Yong Wu
2023-03-07 8:05 ` Yong Wu
2023-03-07 8:05 ` [PATCH v8 6/7] iommu/mediatek: Add MT8188 IOMMU Support Yong Wu
2023-03-07 8:05 ` Yong Wu
2023-03-07 8:05 ` [PATCH v8 7/7] iommu/mediatek: mt8188: Add iova_region_larb_msk Yong Wu
2023-03-07 8:05 ` Yong Wu
2023-03-07 9:56 ` AngeloGioacchino Del Regno
2023-03-07 9:56 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=388e2274-d46a-68a4-3e85-5bd597085041@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chengci.xu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux.dev \
--cc=jianjiao.zeng@mediatek.com \
--cc=joro@8bytes.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mingyuan.ma@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
--cc=yf.wang@mediatek.com \
--cc=yong.wu@mediatek.com \
--cc=youlin.pei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.