From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Julien Grall" <julien@xen.org>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Paul Durrant" <paul@xen.org>,
"Oleksandr Tyshchenko" <oleksandr_tyshchenko@epam.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] xen/memory: Reject out-of-range resource 'frame' values
Date: Fri, 29 Jan 2021 11:01:54 +0100 [thread overview]
Message-ID: <38e6a495-5573-5eeb-acdf-e11211dab73b@suse.com> (raw)
In-Reply-To: <0c574f20-9d92-ba86-37fc-eaa72c3e3d16@citrix.com>
On 29.01.2021 10:47, Andrew Cooper wrote:
> On 29/01/2021 09:40, Jan Beulich wrote:
>> On 29.01.2021 10:32, Andrew Cooper wrote:
>>> What's the likelihood that you'll choose to backport this?
>> Didn't consider this aspect yet. I think I wouldn't have picked
>> it without anyone asking for it to be backported.
>>
>>> I can extend it if needs be.
>> Well, if that deletion of code gets committed in time, then of
>> course there's no real need to fiddle with it here.
>
> This specific patch fixes a real bug on arm32 which will cause unsigned
> long + unsigned int to truncate together and permit certain values.
Why Arm32 only? Looking at current staging, there's no overflow
check at all on the grant part of the path. A suitably large
64-bit "frame" will allow the same behavior on 64-bit (wrapping
around through zero), afaict.
Jan
next prev parent reply other threads:[~2021-01-29 10:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 16:06 [PATCH] xen/memory: Reject out-of-range resource 'frame' values Andrew Cooper
2021-01-28 17:13 ` Paul Durrant
2021-01-29 9:15 ` Jan Beulich
2021-01-29 9:32 ` Andrew Cooper
2021-01-29 9:40 ` Jan Beulich
2021-01-29 9:47 ` Andrew Cooper
2021-01-29 10:01 ` Jan Beulich [this message]
2021-01-29 10:04 ` Andrew Cooper
2021-01-29 10:09 ` Jan Beulich
2021-01-29 11:43 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38e6a495-5573-5eeb-acdf-e11211dab73b@suse.com \
--to=jbeulich@suse.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien@xen.org \
--cc=oleksandr_tyshchenko@epam.com \
--cc=paul@xen.org \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.