From: Julien Grall <julien@xen.org>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Cc: "Jan Beulich" <JBeulich@suse.com>,
"Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Paul Durrant" <paul@xen.org>,
"Oleksandr Tyshchenko" <oleksandr_tyshchenko@epam.com>
Subject: Re: [PATCH] xen/memory: Reject out-of-range resource 'frame' values
Date: Fri, 29 Jan 2021 11:43:43 +0000 [thread overview]
Message-ID: <5c738446-b279-419b-cb81-ac42873ad740@xen.org> (raw)
In-Reply-To: <20210128160616.17608-1-andrew.cooper3@citrix.com>
Hi Andrew,
On 28/01/2021 16:06, Andrew Cooper wrote:
> The ABI is unfortunate, and frame being 64 bits leads to all kinds of problems
> performing correct overflow checks.
>
> Furthermore, the mixed use of unsigned int and unsigned long in the call tree
> is buggy on arm32 where the two are the same size, and certain out-of-range
> combinations will truncated and be permitted.
set_foreign_p2m_entry() always return -EOPNOTSUPP, so I think this would
not need a backport if the issue is Arm only.
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Julien Grall <jgrall@amazon.com>
Cheers,
--
Julien Grall
prev parent reply other threads:[~2021-01-29 11:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 16:06 [PATCH] xen/memory: Reject out-of-range resource 'frame' values Andrew Cooper
2021-01-28 17:13 ` Paul Durrant
2021-01-29 9:15 ` Jan Beulich
2021-01-29 9:32 ` Andrew Cooper
2021-01-29 9:40 ` Jan Beulich
2021-01-29 9:47 ` Andrew Cooper
2021-01-29 10:01 ` Jan Beulich
2021-01-29 10:04 ` Andrew Cooper
2021-01-29 10:09 ` Jan Beulich
2021-01-29 11:43 ` Julien Grall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c738446-b279-419b-cb81-ac42873ad740@xen.org \
--to=julien@xen.org \
--cc=JBeulich@suse.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=oleksandr_tyshchenko@epam.com \
--cc=paul@xen.org \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.