Re: [PATCH] HPE BMC GXP SUPPORT - Verdun, Jean-Marie

From: "Verdun, Jean-Marie" <verdun@hpe.com>
To: "minyard@acm.org" <minyard@acm.org>,
	"Hawkins, Nick" <nick.hawkins@hpe.com>
Cc: "David Airlie" <airlied@linux.ie>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Bartosz Golaszewski" <brgl@bgdev.pl>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Richard Weinberger" <richard@nod.at>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Lee Jones" <lee.jones@linaro.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Mark Brown" <broonie@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Daniel Lezcano" <daniel.lezcano@linaro.org>,
	"Amit Kucheria" <amitk@kernel.org>,
	"Zhang Rui" <rui.zhang@intel.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Wim Van Sebroeck" <wim@linux-watchdog.org>,
	"Guenter Roeck" <linux@roeck-us.net>,
	"Russell King" <linux@armlinux.org.uk>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Olof Johansson" <olof@lixom.net>,
	"soc@kernel.org" <soc@kernel.org>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Stanislav Jakubek" <stano.jakubek@gmail.com>,
	"Sam Ravnborg" <sam@ravnborg.org>,
	"Hao Fang" <fanghao11@huawei.com>,
	"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Marc Zyngier" <maz@kernel.org>,
	"Ard Biesheuvel" <ardb@kernel.org>,
	"Anshuman Khandual" <anshuman.khandual@arm.com>,
	"Wang Kefeng" <wangkefeng.wang@huawei.com>,
	"Lukas Bulwahn" <lukas.bulwahn@gmail.com>,
	"Masahiro Yamada" <masahiroy@kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	"openipmi-developer@lists.sourceforge.net"
	<openipmi-developer@lists.sourceforge.net>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
	"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] HPE BMC GXP SUPPORT
Date: Wed, 2 Feb 2022 18:14:57 +0000	[thread overview]
Message-ID: <3E9905F2-1576-4826-ADC2-85796DE0F4DB@hpe.com> (raw)
In-Reply-To: <20220202175635.GC2091156@minyard.net>

> This is far too big for a single patch.  It needs to be broken into
> functional chunks that can be reviewed individually.  Each driver and
> each device tree change along with it's accompanying code need to be
> done in individual patches.  The way it is it can't be reviewed in any
> sane manner.

> -corey

Thanks for your feedback. We are getting a little bit lost here, as our plan was to submit initial

- bindings
- dts for SoC and 1 board
- initial platform init code

Then drivers code avoiding to send many dts updates which might complexify the review. We wanted to send all drivers code to relevant reviewers by tomorrow.

So, what you are asking ( do not worry I am not trying to negotiate, I just want to avoid English misunderstandings as I am French) is to send per driver

- binding
- dts update
- driver code

For each driver through different submission (with each of them containing the 3 associated parts) ?

What shall be the initial one in our case as we are introducing a platform ? An empty dts infrastructure and then we make it grow one step at a time ?

vejmarie