From: Steven Price <steven.price@arm.com> To: Dave Hansen <dave.hansen@intel.com>, linux-mm@kvack.org, Linus Torvalds <torvalds@linux-foundation.org> Cc: "Mark Rutland" <Mark.Rutland@arm.com>, "Dave Hansen" <dave.hansen@linux.intel.com>, "Arnd Bergmann" <arnd@arndb.de>, "Ard Biesheuvel" <ard.biesheuvel@linaro.org>, "Peter Zijlstra" <peterz@infradead.org>, "Catalin Marinas" <catalin.marinas@arm.com>, x86@kernel.org, "Will Deacon" <will.deacon@arm.com>, linux-kernel@vger.kernel.org, "Jérôme Glisse" <jglisse@redhat.com>, "Ingo Molnar" <mingo@redhat.com>, "Borislav Petkov" <bp@alien8.de>, "Andy Lutomirski" <luto@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>, "James Morse" <james.morse@arm.com>, "Thomas Gleixner" <tglx@linutronix.de>, "Andrew Morton" <akpm@linux-foundation.org>, linux-arm-kernel@lists.infradead.org, "Liang, Kan" <kan.liang@linux.intel.com> Subject: Re: [PATCH v8 00/20] Convert x86 & arm64 to use generic page walk Date: Wed, 17 Apr 2019 15:28:54 +0100 [thread overview] Message-ID: <3acbf061-8c97-55eb-f4b6-163a33ea4d73@arm.com> (raw) In-Reply-To: <3b9561d0-3bde-ef7a-0313-c2cc6216f94d@intel.com> On 12/04/2019 15:44, Dave Hansen wrote: > On 4/10/19 7:56 AM, Steven Price wrote: >> Gentle ping: who can take this? Is there anything blocking this series? > > First of all, I really appreciate that you tried this. Every open-coded > page walk has a set of common pitfalls, but is pretty unbounded in what > kinds of bugs it can contain. I think this at least gets us to the > point where some of those pitfalls won't happen. That's cool, but I'm a > worried that it hasn't gotten easier in the end. My plan was to implement the generic infrastructure and then work to remove the per-arch code for ptdump debugfs where possible. This patch series doesn't actually get that far because I wanted to get some confidence that the general approach would be accepted. > Linus also had some strong opinions in the past on how page walks should > be written. He needs to have a look before we go much further. Fair enough. I'll post the initial work I've done on unifying the x86/arm64 ptdump code - the diffstat is a bit nicer on that - but there's still work to be done so I'm posting just as an RFC. Thanks, Steve
WARNING: multiple messages have this Message-ID (diff)
From: Steven Price <steven.price@arm.com> To: Dave Hansen <dave.hansen@intel.com>, linux-mm@kvack.org, Linus Torvalds <torvalds@linux-foundation.org> Cc: "Mark Rutland" <Mark.Rutland@arm.com>, x86@kernel.org, "Arnd Bergmann" <arnd@arndb.de>, "Ard Biesheuvel" <ard.biesheuvel@linaro.org>, "Peter Zijlstra" <peterz@infradead.org>, "Catalin Marinas" <catalin.marinas@arm.com>, "Dave Hansen" <dave.hansen@linux.intel.com>, "Will Deacon" <will.deacon@arm.com>, linux-kernel@vger.kernel.org, "Jérôme Glisse" <jglisse@redhat.com>, "Ingo Molnar" <mingo@redhat.com>, "Borislav Petkov" <bp@alien8.de>, "Andy Lutomirski" <luto@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>, "James Morse" <james.morse@arm.com>, "Thomas Gleixner" <tglx@linutronix.de>, "Andrew Morton" <akpm@linux-foundation.org>, linux-arm-kernel@lists.infradead.org, "Liang, Kan" <kan.liang@linux.intel.com> Subject: Re: [PATCH v8 00/20] Convert x86 & arm64 to use generic page walk Date: Wed, 17 Apr 2019 15:28:54 +0100 [thread overview] Message-ID: <3acbf061-8c97-55eb-f4b6-163a33ea4d73@arm.com> (raw) In-Reply-To: <3b9561d0-3bde-ef7a-0313-c2cc6216f94d@intel.com> On 12/04/2019 15:44, Dave Hansen wrote: > On 4/10/19 7:56 AM, Steven Price wrote: >> Gentle ping: who can take this? Is there anything blocking this series? > > First of all, I really appreciate that you tried this. Every open-coded > page walk has a set of common pitfalls, but is pretty unbounded in what > kinds of bugs it can contain. I think this at least gets us to the > point where some of those pitfalls won't happen. That's cool, but I'm a > worried that it hasn't gotten easier in the end. My plan was to implement the generic infrastructure and then work to remove the per-arch code for ptdump debugfs where possible. This patch series doesn't actually get that far because I wanted to get some confidence that the general approach would be accepted. > Linus also had some strong opinions in the past on how page walks should > be written. He needs to have a look before we go much further. Fair enough. I'll post the initial work I've done on unifying the x86/arm64 ptdump code - the diffstat is a bit nicer on that - but there's still work to be done so I'm posting just as an RFC. Thanks, Steve _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-17 14:33 UTC|newest] Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-03 14:16 [PATCH v8 00/20] Convert x86 & arm64 to use generic page walk Steven Price 2019-04-03 14:16 ` Steven Price 2019-04-03 14:16 ` [PATCH v8 01/20] arc: mm: Add p?d_large() definitions Steven Price 2019-04-03 14:16 ` Steven Price 2019-04-03 14:16 ` Steven Price 2019-04-03 14:16 ` [PATCH v8 02/20] arm64: " Steven Price 2019-04-03 14:16 ` Steven Price 2019-06-11 15:36 ` Will Deacon 2019-06-11 15:36 ` Will Deacon 2019-04-03 14:16 ` [PATCH v8 03/20] mips: " Steven Price 2019-04-03 14:16 ` Steven Price 2019-04-03 14:16 ` [PATCH v8 04/20] powerpc: " Steven Price 2019-04-03 14:16 ` Steven Price 2019-04-03 14:16 ` Steven Price 2019-04-03 14:16 ` Steven Price 2019-04-03 14:16 ` [PATCH v8 05/20] KVM: PPC: Book3S HV: Remove pmd_is_leaf() Steven Price 2019-04-03 14:16 ` Steven Price 2019-04-03 14:16 ` Steven Price 2019-04-03 14:16 ` Steven Price 2019-04-29 2:05 ` Paul Mackerras 2019-04-29 2:05 ` Paul Mackerras 2019-04-29 2:05 ` Paul Mackerras 2019-04-29 2:05 ` Paul Mackerras 2019-05-09 15:03 ` Steven Price 2019-05-09 15:03 ` Steven Price 2019-05-09 15:03 ` Steven Price 2019-05-09 15:03 ` Steven Price 2019-04-03 14:16 ` [PATCH v8 06/20] riscv: mm: Add p?d_large() definitions Steven Price 2019-04-03 14:16 ` Steven Price 2019-04-03 14:16 ` Steven Price 2019-04-05 4:14 ` Anup Patel 2019-04-05 4:14 ` Anup Patel 2019-04-05 4:14 ` Anup Patel 2019-04-03 14:16 ` [PATCH v8 07/20] s390: " Steven Price 2019-04-03 14:16 ` Steven Price 2019-04-03 14:16 ` [PATCH v8 08/20] sparc: " Steven Price 2019-04-03 14:16 ` Steven Price 2019-04-03 14:16 ` Steven Price 2019-04-03 14:16 ` [PATCH v8 09/20] x86: " Steven Price 2019-04-03 14:16 ` Steven Price 2019-04-03 14:16 ` [PATCH v8 10/20] mm: Add generic p?d_large() macros Steven Price 2019-04-03 14:16 ` Steven Price 2019-04-03 14:16 ` [PATCH v8 11/20] mm: pagewalk: Add p4d_entry() and pgd_entry() Steven Price 2019-04-03 14:16 ` Steven Price 2019-04-03 14:16 ` [PATCH v8 12/20] mm: pagewalk: Allow walking without vma Steven Price 2019-04-03 14:16 ` Steven Price 2019-04-03 14:16 ` [PATCH v8 13/20] mm: pagewalk: Add test_p?d callbacks Steven Price 2019-04-03 14:16 ` Steven Price 2019-04-03 14:16 ` [PATCH v8 14/20] arm64: mm: Convert mm/dump.c to use walk_page_range() Steven Price 2019-04-03 14:16 ` Steven Price 2019-04-03 14:16 ` [PATCH v8 15/20] x86: mm: Don't display pages which aren't present in debugfs Steven Price 2019-04-03 14:16 ` Steven Price 2019-04-03 14:16 ` [PATCH v8 16/20] x86: mm: Point to struct seq_file from struct pg_state Steven Price 2019-04-03 14:16 ` Steven Price 2019-04-03 14:16 ` [PATCH v8 17/20] x86: mm+efi: Convert ptdump_walk_pgd_level() to take a mm_struct Steven Price 2019-04-03 14:16 ` Steven Price 2019-04-03 14:16 ` [PATCH v8 18/20] x86: mm: Convert ptdump_walk_pgd_level_debugfs() to take an mm_struct Steven Price 2019-04-03 14:16 ` Steven Price 2019-04-03 14:16 ` [PATCH v8 19/20] x86: mm: Convert ptdump_walk_pgd_level_core() " Steven Price 2019-04-03 14:16 ` Steven Price 2019-04-03 14:16 ` [PATCH v8 20/20] x86: mm: Convert dump_pagetables to use walk_page_range Steven Price 2019-04-03 14:16 ` Steven Price 2019-04-10 14:56 ` [PATCH v8 00/20] Convert x86 & arm64 to use generic page walk Steven Price 2019-04-10 14:56 ` Steven Price 2019-04-12 14:44 ` Dave Hansen 2019-04-12 14:44 ` Dave Hansen 2019-04-17 14:28 ` Steven Price [this message] 2019-04-17 14:28 ` Steven Price 2019-04-17 14:34 ` [RFC PATCH 1/3] mm: Add generic ptdump Steven Price 2019-04-17 14:34 ` Steven Price 2019-04-17 14:34 ` [RFC PATCH 2/3] arm64: mm: Switch to using generic pt_dump Steven Price 2019-04-17 14:34 ` Steven Price 2019-04-17 14:34 ` [RFC PATCH 3/3] x86: " Steven Price 2019-04-17 14:34 ` Steven Price
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3acbf061-8c97-55eb-f4b6-163a33ea4d73@arm.com \ --to=steven.price@arm.com \ --cc=Mark.Rutland@arm.com \ --cc=akpm@linux-foundation.org \ --cc=ard.biesheuvel@linaro.org \ --cc=arnd@arndb.de \ --cc=bp@alien8.de \ --cc=catalin.marinas@arm.com \ --cc=dave.hansen@intel.com \ --cc=dave.hansen@linux.intel.com \ --cc=hpa@zytor.com \ --cc=james.morse@arm.com \ --cc=jglisse@redhat.com \ --cc=kan.liang@linux.intel.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=luto@kernel.org \ --cc=mingo@redhat.com \ --cc=peterz@infradead.org \ --cc=tglx@linutronix.de \ --cc=torvalds@linux-foundation.org \ --cc=will.deacon@arm.com \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.