From: "André Draszik" <andre.draszik@linaro.org>
To: Tudor Ambarus <tudor.ambarus@linaro.org>,
peter.griffin@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Cc: alim.akhtar@samsung.com, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, willmcvicker@google.com,
kernel-team@android.com
Subject: Re: [PATCH] arm64: dts: exynos: gs101: move serial_0 pinctrl-0/names to dtsi
Date: Thu, 07 Mar 2024 14:00:51 +0000 [thread overview]
Message-ID: <3acffe042bde796dc47d4bdcb339f0081a05193c.camel@linaro.org> (raw)
In-Reply-To: <20240307135248.162752-1-tudor.ambarus@linaro.org>
On Thu, 2024-03-07 at 13:52 +0000, Tudor Ambarus wrote:
> The pinctrl nodes are coming from the shared gs101-pinctrl.dtsi,
> thus the pinctrl-0/names shall stay in dtsi. Move them.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> ---
> arch/arm64/boot/dts/exynos/google/gs101-oriole.dts | 2 --
> arch/arm64/boot/dts/exynos/google/gs101.dtsi | 2 ++
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
> index 6ccade2c8cb4..9dc0f47ef646 100644
> --- a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
> +++ b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
> @@ -103,8 +103,6 @@ key_power: key-power-pins {
> };
>
> &serial_0 {
> - pinctrl-names = "default";
> - pinctrl-0 = <&uart0_bus>;
> status = "okay";
> };
>
> diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> index 55e6bcb3689e..ee65ed9d2cfc 100644
> --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> @@ -421,6 +421,8 @@ serial_0: serial@10a00000 {
> reg = <0x10a00000 0xc0>;
> interrupts = <GIC_SPI 634
> IRQ_TYPE_LEVEL_HIGH 0>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart0_bus>;
The preferred order for these is pinctrl-0 pinctrl-names (and I thought
I had sent a patch for all such issues in gs101, but looks like I
didn't...)
Once addressed:
Reviewed-by: André Draszik <andre.draszik@linaro.org>
Cheers,
Andre'
WARNING: multiple messages have this Message-ID (diff)
From: "André Draszik" <andre.draszik@linaro.org>
To: Tudor Ambarus <tudor.ambarus@linaro.org>,
peter.griffin@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Cc: alim.akhtar@samsung.com, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, willmcvicker@google.com,
kernel-team@android.com
Subject: Re: [PATCH] arm64: dts: exynos: gs101: move serial_0 pinctrl-0/names to dtsi
Date: Thu, 07 Mar 2024 14:00:51 +0000 [thread overview]
Message-ID: <3acffe042bde796dc47d4bdcb339f0081a05193c.camel@linaro.org> (raw)
In-Reply-To: <20240307135248.162752-1-tudor.ambarus@linaro.org>
On Thu, 2024-03-07 at 13:52 +0000, Tudor Ambarus wrote:
> The pinctrl nodes are coming from the shared gs101-pinctrl.dtsi,
> thus the pinctrl-0/names shall stay in dtsi. Move them.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> ---
> arch/arm64/boot/dts/exynos/google/gs101-oriole.dts | 2 --
> arch/arm64/boot/dts/exynos/google/gs101.dtsi | 2 ++
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
> index 6ccade2c8cb4..9dc0f47ef646 100644
> --- a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
> +++ b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
> @@ -103,8 +103,6 @@ key_power: key-power-pins {
> };
>
> &serial_0 {
> - pinctrl-names = "default";
> - pinctrl-0 = <&uart0_bus>;
> status = "okay";
> };
>
> diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> index 55e6bcb3689e..ee65ed9d2cfc 100644
> --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> @@ -421,6 +421,8 @@ serial_0: serial@10a00000 {
> reg = <0x10a00000 0xc0>;
> interrupts = <GIC_SPI 634
> IRQ_TYPE_LEVEL_HIGH 0>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart0_bus>;
The preferred order for these is pinctrl-0 pinctrl-names (and I thought
I had sent a patch for all such issues in gs101, but looks like I
didn't...)
Once addressed:
Reviewed-by: André Draszik <andre.draszik@linaro.org>
Cheers,
Andre'
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-07 14:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 13:52 [PATCH] arm64: dts: exynos: gs101: move serial_0 pinctrl-0/names to dtsi Tudor Ambarus
2024-03-07 13:52 ` Tudor Ambarus
2024-03-07 14:00 ` André Draszik [this message]
2024-03-07 14:00 ` André Draszik
2024-03-08 7:37 ` Tudor Ambarus
2024-03-08 7:37 ` Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3acffe042bde796dc47d4bdcb339f0081a05193c.camel@linaro.org \
--to=andre.draszik@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh+dt@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.