From: Michael Walle <michael@walle.cc>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
Shawn Guo <shawnguo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Esben Haabendal <eha@deif.com>,
angelo@sysam.it, andrew.smirnov@gmail.com,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Wei Chen <weic@nvidia.com>, Mohamed Hosny <mhosny@nvidia.com>,
peng.ma@nxp.com
Subject: Re: [PATCH 5/6] arm64: dts: ls1028a: Specify the DMA channels for the DSPI controllers
Date: Mon, 09 Mar 2020 21:17:42 +0100 [thread overview]
Message-ID: <3b25c8b5fc9c433715e1fa99bc515822@walle.cc> (raw)
In-Reply-To: <CA+h21hp2MxLqLJL9AnufmW_-OQFdiY7p4Db97G3eTr_MUkH4TA@mail.gmail.com>
Am 2020-03-09 20:59, schrieb Vladimir Oltean:
> On Mon, 9 Mar 2020 at 21:06, Michael Walle <michael@walle.cc> wrote:
>>
>> Am 2020-03-09 15:56, schrieb Vladimir Oltean:
>> > From: Vladimir Oltean <vladimir.oltean@nxp.com>
>> >
>> > LS1028A has a functional connection to the eDMA module. Even if the
>> > spi-fsl-dspi.c driver is not using DMA for LS1028A now, define the
>> > slots
>> > in the DMAMUX for connecting the eDMA channels to the 3 DSPI
>> > controllers.
>> >
>> > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
>> > ---
>> > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 6 ++++++
>> > 1 file changed, 6 insertions(+)
>> >
>> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> > index 515e0a1b934f..18155273a46e 100644
>> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> > @@ -298,6 +298,8 @@
>> > interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
>> > clock-names = "dspi";
>> > clocks = <&clockgen 4 1>;
>> > + dmas = <&edma0 0 62>, <&edma0 0 60>;
>> > + dma-names = "tx", "rx";
>>
>> minor nit. Other nodes specified the dma channels as
>>
>> dma-names = "tx", "rx";
>> dmas = <&edma0 0 62>,
>> <&edma0 0 60>;
>>
>> -michael
>>
>
> Does it matter?
No, therefore "minor nit". Its just formatted other then everything else
in the file.
-michael
next prev parent reply other threads:[~2020-03-09 20:17 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 14:56 [PATCH 0/6] NXP DSPI bugfixes and support for LS1028A Vladimir Oltean
2020-03-09 14:56 ` Vladimir Oltean
2020-03-09 14:56 ` [PATCH 1/6] spi: spi-fsl-dspi: Don't access reserved fields in SPI_MCR Vladimir Oltean
2020-03-09 18:05 ` Michael Walle
2020-03-09 18:05 ` Michael Walle
2020-03-09 18:09 ` Vladimir Oltean
2020-03-09 18:09 ` Vladimir Oltean
2020-03-09 14:56 ` [PATCH 2/6] spi: spi-fsl-dspi: Fix little endian access to PUSHR CMD and TXDATA Vladimir Oltean
2020-03-09 17:59 ` Michael Walle
2020-03-09 17:59 ` Michael Walle
2020-03-09 18:07 ` Vladimir Oltean
2020-03-09 18:07 ` Vladimir Oltean
2020-03-09 18:19 ` Michael Walle
2020-03-09 18:19 ` Michael Walle
2020-03-09 18:31 ` Vladimir Oltean
2020-03-09 18:31 ` Vladimir Oltean
2020-03-09 14:56 ` [PATCH 3/6] spi: spi-fsl-dspi: Fix oper_word_size of zero for DMA mode Vladimir Oltean
2020-03-09 14:56 ` Vladimir Oltean
2020-03-09 14:56 ` [PATCH 4/6] spi: spi-fsl-dspi: Add support for LS1028A Vladimir Oltean
2020-03-09 18:38 ` Michael Walle
2020-03-09 18:38 ` Michael Walle
2020-03-09 18:51 ` Vladimir Oltean
2020-03-09 18:51 ` Vladimir Oltean
2020-03-09 14:56 ` [PATCH 5/6] arm64: dts: ls1028a: Specify the DMA channels for the DSPI controllers Vladimir Oltean
2020-03-09 14:56 ` Vladimir Oltean
2020-03-09 19:06 ` Michael Walle
2020-03-09 19:06 ` Michael Walle
2020-03-09 19:59 ` Vladimir Oltean
2020-03-09 19:59 ` Vladimir Oltean
2020-03-09 20:17 ` Michael Walle [this message]
2020-03-09 14:56 ` [PATCH 6/6] arm64: dts: ls1028a-rdb: Add a spidev node for the mikroBUS Vladimir Oltean
2020-03-09 14:56 ` Vladimir Oltean
2020-03-09 18:35 ` Michael Walle
2020-03-09 18:35 ` Michael Walle
2020-03-09 18:50 ` Vladimir Oltean
2020-03-09 18:50 ` Vladimir Oltean
2020-03-09 18:58 ` Michael Walle
2020-03-09 18:58 ` Michael Walle
2020-03-09 18:03 ` [PATCH 0/6] NXP DSPI bugfixes and support for LS1028A Michael Walle
2020-03-09 18:03 ` Michael Walle
2020-03-09 18:14 ` Vladimir Oltean
2020-03-09 18:14 ` Vladimir Oltean
2020-03-09 18:31 ` Michael Walle
2020-03-09 18:48 ` Vladimir Oltean
2020-03-09 18:59 ` Michael Walle
2020-03-09 18:59 ` Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b25c8b5fc9c433715e1fa99bc515822@walle.cc \
--to=michael@walle.cc \
--cc=andrew.smirnov@gmail.com \
--cc=angelo@sysam.it \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eha@deif.com \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhosny@nvidia.com \
--cc=olteanv@gmail.com \
--cc=peng.ma@nxp.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=weic@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.