From: Alex Ghiti <alex@ghiti.fr> To: Naresh Kamboju <naresh.kamboju@linaro.org>, Palmer Dabbelt <palmer@dabbelt.com>, vitaly.wool@konsulko.com Cc: Paul Walmsley <paul.walmsley@sifive.com>, Albert Ou <aou@eecs.berkeley.edu>, linux-riscv <linux-riscv@lists.infradead.org>, open list <linux-kernel@vger.kernel.org>, Linux-Arch <linux-arch@vger.kernel.org>, linux-mm <linux-mm@kvack.org>, lkft-triage@lists.linaro.org Subject: Re: [PATCH v8] RISC-V: enable XIP Date: Tue, 27 Apr 2021 02:44:11 -0400 [thread overview] Message-ID: <3b6ff653-f29f-3230-201d-8ca756346792@ghiti.fr> (raw) In-Reply-To: <CA+G9fYv4y+n6PoYf1jOPZbjPxY7rTi+Ajc89zsNzTS0_uL+RJw@mail.gmail.com> Le 4/26/21 à 12:46 PM, Naresh Kamboju a écrit : > my two cents, > > The riscv build failed on Linux -next 20210426 tag kernel due to > below warnings / errors. > Following builds failed. > - riscv (tinyconfig) with gcc-8 > - riscv (allnoconfig) with gcc-8 > - riscv (tinyconfig) with gcc-9 > - riscv (allnoconfig) with gcc-9 > - riscv (tinyconfig) with gcc-10 > - riscv (allnoconfig) with gcc-10 > >>>>> diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c >>>>> index 30e4af0fd50c..2ddf654c72bb 100644 >>>>> --- a/arch/riscv/kernel/setup.c >>>>> +++ b/arch/riscv/kernel/setup.c >>>>> @@ -50,7 +50,11 @@ struct screen_info screen_info __section(".data") = { >>>>> * This is used before the kernel initializes the BSS so it can't be in the >>>>> * BSS. >>>>> */ >>>>> -atomic_t hart_lottery __section(".sdata"); >>>>> +atomic_t hart_lottery __section(".sdata") >>>>> +#ifdef CONFIG_XIP_KERNEL >>>>> += ATOMIC_INIT(0xC001BEEF) >>>>> +#endif >>>>> +; >>>>> unsigned long boot_cpu_hartid; >>>>> static DEFINE_PER_CPU(struct cpu, cpu_devices); >>>>> >>>>> @@ -254,7 +258,7 @@ void __init setup_arch(char **cmdline_p) >>>>> #if IS_ENABLED(CONFIG_BUILTIN_DTB) >>>>> unflatten_and_copy_device_tree(); >>>>> #else >>>>> - if (early_init_dt_verify(__va(dtb_early_pa))) >>>>> + if (early_init_dt_verify(__va(XIP_FIXUP(dtb_early_pa)))) > > arch/riscv/kernel/setup.c: In function 'setup_arch': > arch/riscv/kernel/setup.c:284:32: error: implicit declaration of > function 'XIP_FIXUP' [-Werror=implicit-function-declaration] > if (early_init_dt_verify(__va(XIP_FIXUP(dtb_early_pa)))) > ^~~~~~~~~ > arch/riscv/include/asm/page.h:112:62: note: in definition of macro > 'linear_mapping_pa_to_va' > #define linear_mapping_pa_to_va(x) ((void *)((unsigned long)(x) + > va_pa_offset)) > ^ > arch/riscv/include/asm/page.h:156:27: note: in expansion of macro > '__pa_to_va_nodebug' > #define __va(x) ((void *)__pa_to_va_nodebug((phys_addr_t)(x))) > ^~~~~~~~~~~~~~~~~~ > arch/riscv/kernel/setup.c:284:27: note: in expansion of macro '__va' > if (early_init_dt_verify(__va(XIP_FIXUP(dtb_early_pa)))) > ^~~~ > cc1: some warnings being treated as errors > > Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> > > > steps to reproduce: > --------------------------- > # TuxMake is a command line tool and Python library that provides > # portable and repeatable Linux kernel builds across a variety of > # architectures, toolchains, kernel configurations, and make targets. > # > # TuxMake supports the concept of runtimes. > # See https://docs.tuxmake.org/runtimes/, for that to work it requires > # that you install podman or docker on your system. > # > # To install tuxmake on your system globally: > # sudo pip3 install -U tuxmake > # > # See https://docs.tuxmake.org/ for complete documentation. > > > tuxmake --runtime podman --target-arch riscv --toolchain gcc-8 > --kconfig allnoconfig > Thank you Naresh for the report, I will fix that today. Thanks again, Alex > -- > Linaro LKFT > https://lkft.linaro.org > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv >
WARNING: multiple messages have this Message-ID (diff)
From: Alex Ghiti <alex@ghiti.fr> To: Naresh Kamboju <naresh.kamboju@linaro.org>, Palmer Dabbelt <palmer@dabbelt.com>, vitaly.wool@konsulko.com Cc: Paul Walmsley <paul.walmsley@sifive.com>, Albert Ou <aou@eecs.berkeley.edu>, linux-riscv <linux-riscv@lists.infradead.org>, open list <linux-kernel@vger.kernel.org>, Linux-Arch <linux-arch@vger.kernel.org>, linux-mm <linux-mm@kvack.org>, lkft-triage@lists.linaro.org Subject: Re: [PATCH v8] RISC-V: enable XIP Date: Tue, 27 Apr 2021 02:44:11 -0400 [thread overview] Message-ID: <3b6ff653-f29f-3230-201d-8ca756346792@ghiti.fr> (raw) In-Reply-To: <CA+G9fYv4y+n6PoYf1jOPZbjPxY7rTi+Ajc89zsNzTS0_uL+RJw@mail.gmail.com> Le 4/26/21 à 12:46 PM, Naresh Kamboju a écrit : > my two cents, > > The riscv build failed on Linux -next 20210426 tag kernel due to > below warnings / errors. > Following builds failed. > - riscv (tinyconfig) with gcc-8 > - riscv (allnoconfig) with gcc-8 > - riscv (tinyconfig) with gcc-9 > - riscv (allnoconfig) with gcc-9 > - riscv (tinyconfig) with gcc-10 > - riscv (allnoconfig) with gcc-10 > >>>>> diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c >>>>> index 30e4af0fd50c..2ddf654c72bb 100644 >>>>> --- a/arch/riscv/kernel/setup.c >>>>> +++ b/arch/riscv/kernel/setup.c >>>>> @@ -50,7 +50,11 @@ struct screen_info screen_info __section(".data") = { >>>>> * This is used before the kernel initializes the BSS so it can't be in the >>>>> * BSS. >>>>> */ >>>>> -atomic_t hart_lottery __section(".sdata"); >>>>> +atomic_t hart_lottery __section(".sdata") >>>>> +#ifdef CONFIG_XIP_KERNEL >>>>> += ATOMIC_INIT(0xC001BEEF) >>>>> +#endif >>>>> +; >>>>> unsigned long boot_cpu_hartid; >>>>> static DEFINE_PER_CPU(struct cpu, cpu_devices); >>>>> >>>>> @@ -254,7 +258,7 @@ void __init setup_arch(char **cmdline_p) >>>>> #if IS_ENABLED(CONFIG_BUILTIN_DTB) >>>>> unflatten_and_copy_device_tree(); >>>>> #else >>>>> - if (early_init_dt_verify(__va(dtb_early_pa))) >>>>> + if (early_init_dt_verify(__va(XIP_FIXUP(dtb_early_pa)))) > > arch/riscv/kernel/setup.c: In function 'setup_arch': > arch/riscv/kernel/setup.c:284:32: error: implicit declaration of > function 'XIP_FIXUP' [-Werror=implicit-function-declaration] > if (early_init_dt_verify(__va(XIP_FIXUP(dtb_early_pa)))) > ^~~~~~~~~ > arch/riscv/include/asm/page.h:112:62: note: in definition of macro > 'linear_mapping_pa_to_va' > #define linear_mapping_pa_to_va(x) ((void *)((unsigned long)(x) + > va_pa_offset)) > ^ > arch/riscv/include/asm/page.h:156:27: note: in expansion of macro > '__pa_to_va_nodebug' > #define __va(x) ((void *)__pa_to_va_nodebug((phys_addr_t)(x))) > ^~~~~~~~~~~~~~~~~~ > arch/riscv/kernel/setup.c:284:27: note: in expansion of macro '__va' > if (early_init_dt_verify(__va(XIP_FIXUP(dtb_early_pa)))) > ^~~~ > cc1: some warnings being treated as errors > > Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> > > > steps to reproduce: > --------------------------- > # TuxMake is a command line tool and Python library that provides > # portable and repeatable Linux kernel builds across a variety of > # architectures, toolchains, kernel configurations, and make targets. > # > # TuxMake supports the concept of runtimes. > # See https://docs.tuxmake.org/runtimes/, for that to work it requires > # that you install podman or docker on your system. > # > # To install tuxmake on your system globally: > # sudo pip3 install -U tuxmake > # > # See https://docs.tuxmake.org/ for complete documentation. > > > tuxmake --runtime podman --target-arch riscv --toolchain gcc-8 > --kconfig allnoconfig > Thank you Naresh for the report, I will fix that today. Thanks again, Alex > -- > Linaro LKFT > https://lkft.linaro.org > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv > _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2021-04-27 6:44 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-13 6:35 [PATCH v8] RISC-V: enable XIP Alexandre Ghiti 2021-04-13 6:35 ` Alexandre Ghiti 2021-04-13 13:44 ` Alex Ghiti 2021-04-13 13:44 ` Alex Ghiti 2021-04-23 4:22 ` Palmer Dabbelt 2021-04-23 4:22 ` Palmer Dabbelt 2021-04-23 7:52 ` Alex Ghiti 2021-04-23 7:52 ` Alex Ghiti 2021-04-23 21:27 ` Vitaly Wool 2021-04-23 21:27 ` Vitaly Wool 2021-04-23 21:27 ` Vitaly Wool 2021-04-24 11:30 ` Alex Ghiti 2021-04-24 11:30 ` Alex Ghiti 2021-04-26 15:32 ` Palmer Dabbelt 2021-04-26 15:32 ` Palmer Dabbelt 2021-04-26 16:46 ` Naresh Kamboju 2021-04-26 16:46 ` Naresh Kamboju 2021-04-26 16:46 ` Naresh Kamboju 2021-04-27 6:44 ` Alex Ghiti [this message] 2021-04-27 6:44 ` Alex Ghiti 2021-05-06 6:38 ` Palmer Dabbelt 2021-05-06 6:38 ` Palmer Dabbelt 2021-04-28 3:08 ` Guenter Roeck 2021-04-28 3:08 ` Guenter Roeck 2021-04-28 3:35 ` Palmer Dabbelt 2021-04-28 3:35 ` Palmer Dabbelt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3b6ff653-f29f-3230-201d-8ca756346792@ghiti.fr \ --to=alex@ghiti.fr \ --cc=aou@eecs.berkeley.edu \ --cc=linux-arch@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-riscv@lists.infradead.org \ --cc=lkft-triage@lists.linaro.org \ --cc=naresh.kamboju@linaro.org \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=vitaly.wool@konsulko.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.