All of lore.kernel.org
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org
Cc: Arvind Yadav <arvind.yadav.cs@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>,
	Takashi Sakamoto <o-takashi@sakamocchi.jp>,
	kernel-janitors@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: ALSA: nm256: Fine-tuning for three function implementations
Date: Tue, 28 Nov 2017 15:19:55 +0100	[thread overview]
Message-ID: <3b7b24bd-4bdf-752e-1a62-cc71e9152acc@users.sourceforge.net> (raw)
In-Reply-To: <s5hlgiqr0ad.wl-tiwai@suse.de>

>> How would you notice that a corresponding system test worked
>> in reasonable ways?
> 
> It needs a trust to the patch author or the tester who reported that
> it worked.

Can this aspect vary over time?


> The test result should be mentioned concisely.

How do you think about to introduce accepted automatic test procedures?


> You shouldn't rely on my system.

Did this system get sufficient trust so far?


> The main point is your patch itself; make your patch more reliable.

It seems that I can make my adjustments only a bit more interesting
by positive review comments from other contributors
(if you can not become convinced by the concrete source code changes).

Regards,
Markus

WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org
Cc: Arvind Yadav <arvind.yadav.cs@gmail.com>,
	Takashi Sakamoto <o-takashi@sakamocchi.jp>,
	kernel-janitors@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: ALSA: nm256: Fine-tuning for three function implementations
Date: Tue, 28 Nov 2017 14:19:55 +0000	[thread overview]
Message-ID: <3b7b24bd-4bdf-752e-1a62-cc71e9152acc@users.sourceforge.net> (raw)
In-Reply-To: <s5hlgiqr0ad.wl-tiwai@suse.de>

>> How would you notice that a corresponding system test worked
>> in reasonable ways?
> 
> It needs a trust to the patch author or the tester who reported that
> it worked.

Can this aspect vary over time?


> The test result should be mentioned concisely.

How do you think about to introduce accepted automatic test procedures?


> You shouldn't rely on my system.

Did this system get sufficient trust so far?


> The main point is your patch itself; make your patch more reliable.

It seems that I can make my adjustments only a bit more interesting
by positive review comments from other contributors
(if you can not become convinced by the concrete source code changes).

Regards,
Markus

WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org
Cc: Arvind Yadav <arvind.yadav.cs@gmail.com>,
	Takashi Sakamoto <o-takashi@sakamocchi.jp>,
	kernel-janitors@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: ALSA: nm256: Fine-tuning for three function implementations
Date: Tue, 28 Nov 2017 15:19:55 +0100	[thread overview]
Message-ID: <3b7b24bd-4bdf-752e-1a62-cc71e9152acc@users.sourceforge.net> (raw)
In-Reply-To: <s5hlgiqr0ad.wl-tiwai@suse.de>

>> How would you notice that a corresponding system test worked
>> in reasonable ways?
> 
> It needs a trust to the patch author or the tester who reported that
> it worked.

Can this aspect vary over time?


> The test result should be mentioned concisely.

How do you think about to introduce accepted automatic test procedures?


> You shouldn't rely on my system.

Did this system get sufficient trust so far?


> The main point is your patch itself; make your patch more reliable.

It seems that I can make my adjustments only a bit more interesting
by positive review comments from other contributors
(if you can not become convinced by the concrete source code changes).

Regards,
Markus

  reply	other threads:[~2017-11-28 14:21 UTC|newest]

Thread overview: 121+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-16 17:05 [PATCH 0/2] ALSA: nm256: Fine-tuning for three function implementations SF Markus Elfring
2017-11-16 17:05 ` SF Markus Elfring
2017-11-16 17:05 ` SF Markus Elfring
2017-11-16 17:07 ` [PATCH 1/2] ALSA: nm256: Adjust five function calls together with a variable assignment SF Markus Elfring
2017-11-16 17:07   ` SF Markus Elfring
2017-11-16 17:07   ` SF Markus Elfring
2017-11-16 17:08 ` [PATCH 2/2] ALSA: nm256: Use common error handling code in snd_nm256_probe() SF Markus Elfring
2017-11-16 17:08   ` SF Markus Elfring
2017-11-16 17:08   ` SF Markus Elfring
2017-11-16 17:15 ` [PATCH 0/2] ALSA: nm256: Fine-tuning for three function implementations Takashi Iwai
2017-11-16 17:15   ` Takashi Iwai
2017-11-16 17:15   ` Takashi Iwai
2017-11-16 17:48   ` SF Markus Elfring
2017-11-16 17:48     ` SF Markus Elfring
2017-11-16 17:48     ` SF Markus Elfring
2017-11-16 18:54     ` Takashi Iwai
2017-11-16 18:54       ` Takashi Iwai
2017-11-16 19:30       ` SF Markus Elfring
2017-11-16 19:30         ` SF Markus Elfring
2017-11-28  7:46         ` Takashi Iwai
2017-11-28  7:46           ` Takashi Iwai
2017-11-28  8:19           ` SF Markus Elfring
2017-11-28  8:19             ` SF Markus Elfring
2017-11-28  8:19             ` SF Markus Elfring
2017-11-28  9:10             ` Takashi Iwai
2017-11-28  9:10               ` Takashi Iwai
2017-11-28  9:10               ` Takashi Iwai
2017-11-28  9:50               ` SF Markus Elfring
2017-11-28  9:50                 ` SF Markus Elfring
2017-11-28  9:50                 ` SF Markus Elfring
2017-11-28 11:37                 ` Takashi Iwai
2017-11-28 11:37                   ` Takashi Iwai
2017-11-28 12:33                   ` SF Markus Elfring
2017-11-28 12:33                     ` SF Markus Elfring
2017-11-28 12:33                     ` SF Markus Elfring
2017-11-28 12:46                     ` Takashi Iwai
2017-11-28 12:46                       ` Takashi Iwai
2017-11-28 13:00                       ` SF Markus Elfring
2017-11-28 13:00                         ` SF Markus Elfring
2017-11-28 13:00                         ` SF Markus Elfring
2017-11-28 13:06                         ` Takashi Iwai
2017-11-28 13:06                           ` Takashi Iwai
2017-11-28 13:17                           ` SF Markus Elfring
2017-11-28 13:17                             ` SF Markus Elfring
2017-11-28 13:17                             ` SF Markus Elfring
2017-11-28 13:38                             ` Takashi Iwai
2017-11-28 13:38                               ` Takashi Iwai
2017-11-28 14:19                               ` SF Markus Elfring [this message]
2017-11-28 14:19                                 ` SF Markus Elfring
2017-11-28 14:19                                 ` SF Markus Elfring
2017-11-28 14:27                                 ` Takashi Iwai
2017-11-28 14:27                                   ` Takashi Iwai
2017-11-28 14:33                                   ` SF Markus Elfring
2017-11-28 14:33                                     ` SF Markus Elfring
2017-11-28 14:33                                     ` SF Markus Elfring
2017-11-28 14:38                                     ` Takashi Iwai
2017-11-28 14:38                                       ` Takashi Iwai
2017-11-28 14:38                                       ` Takashi Iwai
2017-11-28 14:44                                       ` SF Markus Elfring
2017-11-28 14:44                                         ` SF Markus Elfring
2017-11-28 14:44                                         ` SF Markus Elfring
2017-11-28 14:53                                         ` Takashi Iwai
2017-11-28 14:53                                           ` Takashi Iwai
2017-11-28 14:53                                           ` Takashi Iwai
2017-11-28 15:01                                           ` SF Markus Elfring
2017-11-28 15:01                                             ` SF Markus Elfring
2017-11-28 15:01                                             ` SF Markus Elfring
2017-11-28 15:21                                             ` Takashi Iwai
2017-11-28 15:21                                               ` Takashi Iwai
2017-11-28 15:21                                               ` Takashi Iwai
2017-11-28 16:15                                               ` SF Markus Elfring
2017-11-28 16:15                                                 ` SF Markus Elfring
2017-11-28 16:15                                                 ` SF Markus Elfring
2017-11-28 16:27                                                 ` Takashi Iwai
2017-11-28 16:27                                                   ` Takashi Iwai
2017-11-28 16:27                                                   ` Takashi Iwai
2017-11-28 16:40                                                   ` SF Markus Elfring
2017-11-28 16:40                                                     ` SF Markus Elfring
2017-11-28 16:40                                                     ` SF Markus Elfring
2017-11-28 16:44                                                     ` Takashi Iwai
2017-11-28 16:44                                                       ` Takashi Iwai
2017-11-28 16:44                                                       ` Takashi Iwai
2017-11-28 17:15                                                       ` SF Markus Elfring
2017-11-28 17:15                                                         ` SF Markus Elfring
2017-11-28 17:15                                                         ` SF Markus Elfring
2017-11-28 18:35                                                         ` Takashi Iwai
2017-11-28 18:35                                                           ` Takashi Iwai
2017-11-28 19:08                                                           ` SF Markus Elfring
2017-11-28 19:08                                                             ` SF Markus Elfring
2017-11-28 19:08                                                             ` SF Markus Elfring
2017-11-28 19:43                                                             ` Takashi Iwai
2017-11-28 19:43                                                               ` Takashi Iwai
2017-11-28 19:43                                                               ` Takashi Iwai
2017-11-28 19:48                                                               ` SF Markus Elfring
2017-11-28 19:48                                                                 ` SF Markus Elfring
2017-11-28 19:48                                                                 ` SF Markus Elfring
2017-11-28 19:54                                                                 ` Takashi Iwai
2017-11-28 19:54                                                                   ` Takashi Iwai
2017-11-28 19:54                                                                   ` Takashi Iwai
2017-11-28 19:57                                                                   ` SF Markus Elfring
2017-11-28 19:57                                                                     ` SF Markus Elfring
2017-11-28 19:57                                                                     ` SF Markus Elfring
2017-11-28 20:00                                                                     ` Takashi Iwai
2017-11-28 20:00                                                                       ` Takashi Iwai
2017-11-28 20:00                                                                       ` Takashi Iwai
2017-11-28 20:18                                                                       ` SF Markus Elfring
2017-11-28 20:18                                                                         ` SF Markus Elfring
2017-11-28 20:18                                                                         ` SF Markus Elfring
2017-11-28 20:25                                                                         ` Takashi Iwai
2017-11-28 20:25                                                                           ` Takashi Iwai
2017-11-28 20:32                                                                           ` SF Markus Elfring
2017-11-28 20:32                                                                             ` SF Markus Elfring
2017-11-28 20:32                                                                             ` SF Markus Elfring
2017-11-29 10:34               ` SF Markus Elfring
2017-11-29 10:34                 ` SF Markus Elfring
2017-11-29 10:34                 ` SF Markus Elfring
2017-11-28 12:33             ` [alsa-devel] " Ondrej Zary
2017-11-28 12:33               ` Ondrej Zary
2017-11-28 13:10               ` SF Markus Elfring
2017-11-28 13:10                 ` SF Markus Elfring
2017-11-28 13:10                 ` [alsa-devel] " SF Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b7b24bd-4bdf-752e-1a62-cc71e9152acc@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=alsa-devel@alsa-project.org \
    --cc=arvind.yadav.cs@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=o-takashi@sakamocchi.jp \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.