From: Waiman Long <longman@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>,
cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, Ming Lei <ming.lei@redhat.com>
Subject: Re: [PATCH v5 4/4] blk-cgroup: Document the design of new lockless iostat_cpu list
Date: Thu, 2 Jun 2022 15:12:53 -0400 [thread overview]
Message-ID: <3ba0799f-c008-bbdf-bbc1-626d8bb4b821@redhat.com> (raw)
In-Reply-To: <YpkJ6rDTR24ScuEq@slm.duckdns.org>
On 6/2/22 15:05, Tejun Heo wrote:
> On Thu, Jun 02, 2022 at 02:54:01PM -0400, Waiman Long wrote:
>> A set of percpu lockless lists per block cgroup (blkcg) is added to
>> track the set of recently updated iostat_cpu structures. Add comment
>> in the code to document the design of this new set of lockless lists.
>>
>> Signed-off-by: Waiman Long <longman@redhat.com>
> Acked-by: Tejun Heo <tj@kernel.org>
>
> Thanks.
I have just realized that I forgot to free the percpu blkcg->lhead in
blkcg_css_free(). I will send out v6 with this change as well as
integrating this documentation patch back. Sorry for the omission.
Thanks,
Longman
WARNING: multiple messages have this Message-ID (diff)
From: Waiman Long <longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Ming Lei <ming.lei-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v5 4/4] blk-cgroup: Document the design of new lockless iostat_cpu list
Date: Thu, 2 Jun 2022 15:12:53 -0400 [thread overview]
Message-ID: <3ba0799f-c008-bbdf-bbc1-626d8bb4b821@redhat.com> (raw)
In-Reply-To: <YpkJ6rDTR24ScuEq-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
On 6/2/22 15:05, Tejun Heo wrote:
> On Thu, Jun 02, 2022 at 02:54:01PM -0400, Waiman Long wrote:
>> A set of percpu lockless lists per block cgroup (blkcg) is added to
>> track the set of recently updated iostat_cpu structures. Add comment
>> in the code to document the design of this new set of lockless lists.
>>
>> Signed-off-by: Waiman Long <longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Acked-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>
> Thanks.
I have just realized that I forgot to free the percpu blkcg->lhead in
blkcg_css_free(). I will send out v6 with this change as well as
integrating this documentation patch back. Sorry for the omission.
Thanks,
Longman
next prev parent reply other threads:[~2022-06-02 19:13 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 21:18 [PATCH v3 0/2] blk-cgroup: Optimize blkcg_rstat_flush() Waiman Long
2022-06-01 21:18 ` Waiman Long
2022-06-01 21:18 ` [PATCH v3 1/2] blk-cgroup: Correctly free percpu iostat_cpu in blkg on error exit Waiman Long
2022-06-01 21:18 ` [PATCH v3 2/2] blk-cgroup: Optimize blkcg_rstat_flush() Waiman Long
2022-06-01 21:18 ` Waiman Long
2022-06-01 21:26 ` Tejun Heo
2022-06-01 21:30 ` Waiman Long
2022-06-02 6:32 ` kernel test robot
2022-06-02 1:54 ` [PATCH v4 " Waiman Long
2022-06-02 1:54 ` Waiman Long
2022-06-02 13:35 ` [PATCH v5 0/3] " Waiman Long
2022-06-02 13:35 ` [PATCH v5 1/3] blk-cgroup: Correctly free percpu iostat_cpu in blkg on error exit Waiman Long
2022-06-02 18:54 ` [PATCH v5 4/4] blk-cgroup: Document the design of new lockless iostat_cpu list Waiman Long
2022-06-02 18:54 ` Waiman Long
2022-06-02 19:05 ` Tejun Heo
2022-06-02 19:12 ` Waiman Long [this message]
2022-06-02 19:12 ` Waiman Long
2022-06-02 13:35 ` [PATCH v5 2/3] blk-cgroup: Return -ENOMEM directly in blkcg_css_alloc() error path Waiman Long
2022-06-02 13:35 ` Waiman Long
2022-06-02 16:16 ` Tejun Heo
2022-06-02 17:17 ` Waiman Long
2022-06-02 17:17 ` Waiman Long
2022-06-02 13:35 ` [PATCH v5 3/3] blk-cgroup: Optimize blkcg_rstat_flush() Waiman Long
2022-06-02 16:58 ` Tejun Heo
2022-06-02 17:26 ` Waiman Long
2022-06-02 17:26 ` Waiman Long
2022-06-02 17:46 ` Tejun Heo
2022-06-02 17:46 ` Tejun Heo
2022-06-02 18:18 ` Waiman Long
2022-06-02 18:18 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ba0799f-c008-bbdf-bbc1-626d8bb4b821@redhat.com \
--to=longman@redhat.com \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.