From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rudraksha Gupta <guptarud@gmail.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
soc@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/4] dt-bindings: phy: qcom,usb-hs-phy: Add compatible
Date: Sun, 4 Jun 2023 12:30:41 +0200 [thread overview]
Message-ID: <3c781ae6-4a45-1d6d-840c-d25f33684b00@linaro.org> (raw)
In-Reply-To: <20230604063032.365775-3-guptarud@gmail.com>
On 04/06/2023 08:30, Rudraksha Gupta wrote:
> Adds qcom,usb-hs-phy-msm8960 compatible
>
> Signed-off-by: Rudraksha Gupta <guptarud@gmail.com>
> ---
> Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml
> index aa97478dd016..63b6914993fe 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml
> @@ -13,7 +13,9 @@ if:
> properties:
> compatible:
> contains:
> - const: qcom,usb-hs-phy-apq8064
> + items:
> + - const: qcom,usb-hs-phy-apq8064
> + - const: qcom,usb-hs-phy-msm8960
I have no clue what you want to achieve here. You break the bindings.
It does not look like you tested the bindings, at least after quick
look. Please run `make dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Maybe you need to update your dtschema and yamllint.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rudraksha Gupta <guptarud@gmail.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
soc@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/4] dt-bindings: phy: qcom,usb-hs-phy: Add compatible
Date: Sun, 4 Jun 2023 12:30:41 +0200 [thread overview]
Message-ID: <3c781ae6-4a45-1d6d-840c-d25f33684b00@linaro.org> (raw)
In-Reply-To: <20230604063032.365775-3-guptarud@gmail.com>
On 04/06/2023 08:30, Rudraksha Gupta wrote:
> Adds qcom,usb-hs-phy-msm8960 compatible
>
> Signed-off-by: Rudraksha Gupta <guptarud@gmail.com>
> ---
> Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml
> index aa97478dd016..63b6914993fe 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml
> @@ -13,7 +13,9 @@ if:
> properties:
> compatible:
> contains:
> - const: qcom,usb-hs-phy-apq8064
> + items:
> + - const: qcom,usb-hs-phy-apq8064
> + - const: qcom,usb-hs-phy-msm8960
I have no clue what you want to achieve here. You break the bindings.
It does not look like you tested the bindings, at least after quick
look. Please run `make dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Maybe you need to update your dtschema and yamllint.
Best regards,
Krzysztof
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rudraksha Gupta <guptarud@gmail.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
soc@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/4] dt-bindings: phy: qcom,usb-hs-phy: Add compatible
Date: Sun, 4 Jun 2023 12:30:41 +0200 [thread overview]
Message-ID: <3c781ae6-4a45-1d6d-840c-d25f33684b00@linaro.org> (raw)
In-Reply-To: <20230604063032.365775-3-guptarud@gmail.com>
On 04/06/2023 08:30, Rudraksha Gupta wrote:
> Adds qcom,usb-hs-phy-msm8960 compatible
>
> Signed-off-by: Rudraksha Gupta <guptarud@gmail.com>
> ---
> Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml
> index aa97478dd016..63b6914993fe 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml
> @@ -13,7 +13,9 @@ if:
> properties:
> compatible:
> contains:
> - const: qcom,usb-hs-phy-apq8064
> + items:
> + - const: qcom,usb-hs-phy-apq8064
> + - const: qcom,usb-hs-phy-msm8960
I have no clue what you want to achieve here. You break the bindings.
It does not look like you tested the bindings, at least after quick
look. Please run `make dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Maybe you need to update your dtschema and yamllint.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-06-04 10:30 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-04 6:30 [PATCH v3 0/4] Samsung Galaxy Express SGH-I437 Support Rudraksha Gupta
2023-06-04 6:30 ` Rudraksha Gupta
2023-06-04 6:30 ` Rudraksha Gupta
2023-06-04 6:30 ` [PATCH v3 1/4] dt-bindings: arm: qcom: Add Samsung Galaxy Express Rudraksha Gupta
2023-06-04 6:30 ` Rudraksha Gupta
2023-06-04 6:30 ` Rudraksha Gupta
2023-06-04 6:30 ` [PATCH v3 2/4] dt-bindings: phy: qcom,usb-hs-phy: Add compatible Rudraksha Gupta
2023-06-04 6:30 ` Rudraksha Gupta
2023-06-04 6:30 ` Rudraksha Gupta
2023-06-04 7:23 ` Rob Herring
2023-06-04 7:23 ` Rob Herring
2023-06-04 7:23 ` Rob Herring
2023-06-06 2:06 ` Rudraksha Gupta
2023-06-06 2:06 ` Rudraksha Gupta
2023-06-06 2:06 ` Rudraksha Gupta
2023-06-04 10:30 ` Krzysztof Kozlowski [this message]
2023-06-04 10:30 ` Krzysztof Kozlowski
2023-06-04 10:30 ` Krzysztof Kozlowski
2023-06-06 2:48 ` Rudraksha Gupta
2023-06-06 2:48 ` Rudraksha Gupta
2023-06-06 2:48 ` Rudraksha Gupta
2023-06-06 6:20 ` Krzysztof Kozlowski
2023-06-06 6:20 ` Krzysztof Kozlowski
2023-06-06 6:20 ` Krzysztof Kozlowski
2023-06-04 6:30 ` [PATCH v3 3/4] ARM: dts: qcom: msm8960: Add USB node Rudraksha Gupta
2023-06-04 6:30 ` Rudraksha Gupta
2023-06-04 6:30 ` Rudraksha Gupta
2023-06-04 6:30 ` [PATCH v3 4/4] ARM: dts: qcom: Add Samsung Galaxy Express support Rudraksha Gupta
2023-06-04 6:30 ` Rudraksha Gupta
2023-06-04 6:30 ` Rudraksha Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c781ae6-4a45-1d6d-840c-d25f33684b00@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=guptarud@gmail.com \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.