From: Alexander Duyck <alexander.h.duyck@linux.intel.com>
To: Dan Williams <dan.j.williams@intel.com>, linux-nvdimm@lists.01.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] libnvdimm, dimm: Maximize label transfer size
Date: Fri, 28 Sep 2018 15:44:27 -0700 [thread overview]
Message-ID: <3cf89dd3-a024-dbab-36ed-923f9466669c@linux.intel.com> (raw)
In-Reply-To: <153816098159.2233877.8382846671636531035.stgit@dwillia2-desk3.amr.corp.intel.com>
On 9/28/2018 11:56 AM, Dan Williams wrote:
> Use kvzalloc() to bypass the arbitrary PAGE_SIZE limit of label transfer
> operations. Given the expense of calling into firmware, maximize the
> amount of label data we transfer per call to be up to the total label
> space if allowed by the firmware.
>
> Cc: Alexander Duyck <alexander.h.duyck@linux.intel.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
This looks mostly fine to me.
The only thing I am not certain about is if we want to use the raw
max_cmd_size value or not since there is no guarantee it is aligned to
any sort of boundary. It might be beneficial to either cache line align
it or align it to 256B if it is larger than that since that way we at
least would be getting full labels instead of partial ones.
> ---
> drivers/nvdimm/dimm_devs.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/nvdimm/dimm_devs.c b/drivers/nvdimm/dimm_devs.c
> index 863cabc35215..82ab96a9f560 100644
> --- a/drivers/nvdimm/dimm_devs.c
> +++ b/drivers/nvdimm/dimm_devs.c
> @@ -111,8 +111,8 @@ int nvdimm_init_config_data(struct nvdimm_drvdata *ndd)
> if (!ndd->data)
> return -ENOMEM;
>
> - max_cmd_size = min_t(u32, PAGE_SIZE, ndd->nsarea.max_xfer);
> - cmd = kzalloc(max_cmd_size + sizeof(*cmd), GFP_KERNEL);
> + max_cmd_size = min_t(u32, ndd->nsarea.config_size, ndd->nsarea.max_xfer);
> + cmd = kvzalloc(max_cmd_size + sizeof(*cmd), GFP_KERNEL);
> if (!cmd)
> return -ENOMEM;
>
> @@ -134,7 +134,7 @@ int nvdimm_init_config_data(struct nvdimm_drvdata *ndd)
> memcpy(ndd->data + offset, cmd->out_buf, cmd->in_length);
> }
> dev_dbg(ndd->dev, "len: %zu rc: %d\n", offset, rc);
> - kfree(cmd);
> + kvfree(cmd);
>
> return rc;
> }
> @@ -157,9 +157,9 @@ int nvdimm_set_config_data(struct nvdimm_drvdata *ndd, size_t offset,
> if (offset + len > ndd->nsarea.config_size)
> return -ENXIO;
>
> - max_cmd_size = min_t(u32, PAGE_SIZE, len);
> + max_cmd_size = min_t(u32, ndd->nsarea.config_size, len);
> max_cmd_size = min_t(u32, max_cmd_size, ndd->nsarea.max_xfer);
> - cmd = kzalloc(max_cmd_size + sizeof(*cmd) + sizeof(u32), GFP_KERNEL);
> + cmd = kvzalloc(max_cmd_size + sizeof(*cmd) + sizeof(u32), GFP_KERNEL);
> if (!cmd)
> return -ENOMEM;
>
> @@ -183,7 +183,7 @@ int nvdimm_set_config_data(struct nvdimm_drvdata *ndd, size_t offset,
> break;
> }
> }
> - kfree(cmd);
> + kvfree(cmd);
>
> return rc;
> }
>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Duyck <alexander.h.duyck@linux.intel.com>
To: Dan Williams <dan.j.williams@intel.com>, linux-nvdimm@lists.01.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] libnvdimm, dimm: Maximize label transfer size
Date: Fri, 28 Sep 2018 15:44:27 -0700 [thread overview]
Message-ID: <3cf89dd3-a024-dbab-36ed-923f9466669c@linux.intel.com> (raw)
In-Reply-To: <153816098159.2233877.8382846671636531035.stgit@dwillia2-desk3.amr.corp.intel.com>
On 9/28/2018 11:56 AM, Dan Williams wrote:
> Use kvzalloc() to bypass the arbitrary PAGE_SIZE limit of label transfer
> operations. Given the expense of calling into firmware, maximize the
> amount of label data we transfer per call to be up to the total label
> space if allowed by the firmware.
>
> Cc: Alexander Duyck <alexander.h.duyck@linux.intel.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
This looks mostly fine to me.
The only thing I am not certain about is if we want to use the raw
max_cmd_size value or not since there is no guarantee it is aligned to
any sort of boundary. It might be beneficial to either cache line align
it or align it to 256B if it is larger than that since that way we at
least would be getting full labels instead of partial ones.
> ---
> drivers/nvdimm/dimm_devs.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/nvdimm/dimm_devs.c b/drivers/nvdimm/dimm_devs.c
> index 863cabc35215..82ab96a9f560 100644
> --- a/drivers/nvdimm/dimm_devs.c
> +++ b/drivers/nvdimm/dimm_devs.c
> @@ -111,8 +111,8 @@ int nvdimm_init_config_data(struct nvdimm_drvdata *ndd)
> if (!ndd->data)
> return -ENOMEM;
>
> - max_cmd_size = min_t(u32, PAGE_SIZE, ndd->nsarea.max_xfer);
> - cmd = kzalloc(max_cmd_size + sizeof(*cmd), GFP_KERNEL);
> + max_cmd_size = min_t(u32, ndd->nsarea.config_size, ndd->nsarea.max_xfer);
> + cmd = kvzalloc(max_cmd_size + sizeof(*cmd), GFP_KERNEL);
> if (!cmd)
> return -ENOMEM;
>
> @@ -134,7 +134,7 @@ int nvdimm_init_config_data(struct nvdimm_drvdata *ndd)
> memcpy(ndd->data + offset, cmd->out_buf, cmd->in_length);
> }
> dev_dbg(ndd->dev, "len: %zu rc: %d\n", offset, rc);
> - kfree(cmd);
> + kvfree(cmd);
>
> return rc;
> }
> @@ -157,9 +157,9 @@ int nvdimm_set_config_data(struct nvdimm_drvdata *ndd, size_t offset,
> if (offset + len > ndd->nsarea.config_size)
> return -ENXIO;
>
> - max_cmd_size = min_t(u32, PAGE_SIZE, len);
> + max_cmd_size = min_t(u32, ndd->nsarea.config_size, len);
> max_cmd_size = min_t(u32, max_cmd_size, ndd->nsarea.max_xfer);
> - cmd = kzalloc(max_cmd_size + sizeof(*cmd) + sizeof(u32), GFP_KERNEL);
> + cmd = kvzalloc(max_cmd_size + sizeof(*cmd) + sizeof(u32), GFP_KERNEL);
> if (!cmd)
> return -ENOMEM;
>
> @@ -183,7 +183,7 @@ int nvdimm_set_config_data(struct nvdimm_drvdata *ndd, size_t offset,
> break;
> }
> }
> - kfree(cmd);
> + kvfree(cmd);
>
> return rc;
> }
>
next prev parent reply other threads:[~2018-09-28 22:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 18:56 [PATCH] libnvdimm, dimm: Maximize label transfer size Dan Williams
2018-09-28 18:56 ` Dan Williams
2018-09-28 22:44 ` Alexander Duyck [this message]
2018-09-28 22:44 ` Alexander Duyck
2018-09-28 23:03 ` Dan Williams
2018-09-28 23:03 ` Dan Williams
2018-10-01 15:41 ` Alexander Duyck
2018-10-01 15:41 ` Alexander Duyck
2018-10-01 16:55 ` Dan Williams
2018-10-01 16:55 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cf89dd3-a024-dbab-36ed-923f9466669c@linux.intel.com \
--to=alexander.h.duyck@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.