From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: John Harrison <john.c.harrison@intel.com>,
Intel-GFX@Lists.FreeDesktop.Org
Cc: DRI-Devel@Lists.FreeDesktop.Org
Subject: Re: [Intel-gfx] [PATCH 10/12] drm/i915/guc: Support larger contexts on newer hardware
Date: Mon, 25 Jul 2022 12:24:14 +0100 [thread overview]
Message-ID: <3d04906d-87de-1c5b-5139-d32bdbcabc28@linux.intel.com> (raw)
In-Reply-To: <25f0f1b0-2eb0-4a52-a105-17a82354284c@intel.com>
On 22/07/2022 20:32, John Harrison wrote:
> On 7/19/2022 02:56, Tvrtko Ursulin wrote:
>> On 19/07/2022 01:13, John Harrison wrote:
>>> On 7/18/2022 05:35, Tvrtko Ursulin wrote:
>>>>
>>>> On 13/07/2022 00:31, John.C.Harrison@Intel.com wrote:
>>>>> From: Matthew Brost <matthew.brost@intel.com>
>>>>>
>>>>> The GuC needs a copy of a golden context for implementing watchdog
>>>>> resets (aka media resets). This context is larger on newer platforms.
>>>>> So adjust the size being allocated/copied accordingly.
>>>>
>>>> What were the consequences of this being too small? Media watchdog
>>>> reset broken impacting userspace? Platforms? Do we have an IGT
>>>> testcase? Do we need a Fixes: tag? Copy stable?
>>> Yes. Not sure if we have an IGT for the media watchdog. I recall
>>> writing something a long time back but I don't think it ever got
>>> merged due to push back that I don't recall right now. And no because
>>> it only affects DG2 onwards which is still forceprobed.
>>
>> Right, hm, I don't know if the MBD SKU promise for DG2 relies on force
>> probe removal or not. My impression certainly was that a bunch of uapi
>> we recently merged made people happy in that respect - that we
>> satisfied the commit to deliver that support with 5.19. Maybe I am
>> wrong, or perhaps to err on the side of safety you could add the right
>> Fixes: tag regardless? Pick some patch which enables GuC for DG2 if
>> there isn't anything better I guess. Or you could check with James.
> Adding "Fixes: random patch that is actually irrelevant" seems like the
> wrong thing to do. This is not a bug fix. It is new platform support.
> And it is not the only thing required to support that new platform that
> is not currently in 5.19. E.g. DG2 requires at least GuC v70.4.2 to
> support some hardware w/a's. The guidance for that was to not add Fixes
> tags but to send a manual pull request once everything is ready.
All I know is that some people were really interested(*) that 5.19
contains everything needed for DG2. Hence I suggested to err on the side
of safety, or at least check with folks.
Bottom line is, if you want this fix to be in 5.19, or even 5.20, you
should add a Fixes: tag. Otherwise it will be in 5.21 at the earliest.
Your call, I only tried to be helpful and avoid another failure.
Regards,
Tvrtko
*) To the point of actively pining the maintainers to ensure patches do
not miss the merge window.
next prev parent reply other threads:[~2022-07-25 11:24 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 23:31 [PATCH 00/12] Random assortment of (mostly) GuC related patches John.C.Harrison
2022-07-12 23:31 ` [Intel-gfx] " John.C.Harrison
2022-07-12 23:31 ` [PATCH 01/12] drm/i915: Remove bogus GEM_BUG_ON in unpark John.C.Harrison
2022-07-12 23:31 ` [Intel-gfx] " John.C.Harrison
2022-07-18 12:15 ` Tvrtko Ursulin
2022-07-19 0:05 ` John Harrison
2022-07-19 9:42 ` Tvrtko Ursulin
2022-07-21 0:54 ` John Harrison
2022-07-21 9:24 ` Tvrtko Ursulin
2022-07-22 19:09 ` John Harrison
2022-07-12 23:31 ` [PATCH 02/12] drm/i915/guc: Don't call ring_is_idle in GuC submission John.C.Harrison
2022-07-12 23:31 ` [Intel-gfx] " John.C.Harrison
2022-07-18 12:26 ` Tvrtko Ursulin
2022-07-19 0:09 ` John Harrison
2022-07-19 9:49 ` Tvrtko Ursulin
2022-07-19 10:14 ` Tvrtko Ursulin
2022-07-12 23:31 ` [PATCH 03/12] drm/i915/guc: Fix issues with live_preempt_cancel John.C.Harrison
2022-07-12 23:31 ` [Intel-gfx] " John.C.Harrison
2022-07-12 23:31 ` [PATCH 04/12] drm/i915/guc: Add GuC <-> kernel time stamp translation information John.C.Harrison
2022-07-12 23:31 ` [Intel-gfx] " John.C.Harrison
2022-07-12 23:31 ` [PATCH 05/12] drm/i915/guc: Record CTB info in error logs John.C.Harrison
2022-07-12 23:31 ` [Intel-gfx] " John.C.Harrison
2022-07-12 23:31 ` [PATCH 06/12] drm/i915/guc: Use streaming loads to speed up dumping the guc log John.C.Harrison
2022-07-12 23:31 ` [Intel-gfx] " John.C.Harrison
2022-07-22 20:05 ` John Harrison
2022-07-12 23:31 ` [PATCH 07/12] drm/i915/guc: Route semaphores to GuC for Gen12+ John.C.Harrison
2022-07-12 23:31 ` [Intel-gfx] " John.C.Harrison
2022-07-13 0:51 ` Matthew Brost
2022-07-13 0:51 ` [Intel-gfx] " Matthew Brost
2022-07-15 17:21 ` Ceraolo Spurio, Daniele
2022-07-15 17:21 ` [Intel-gfx] " Ceraolo Spurio, Daniele
2022-07-12 23:31 ` [PATCH 08/12] drm/i915/guc: Add selftest for a hung GuC John.C.Harrison
2022-07-12 23:31 ` [Intel-gfx] " John.C.Harrison
2022-07-12 23:31 ` [PATCH 09/12] drm/i915/selftest: Cope with not having an RCS engine John.C.Harrison
2022-07-12 23:31 ` [Intel-gfx] " John.C.Harrison
2022-07-13 0:48 ` Matthew Brost
2022-07-13 0:48 ` [Intel-gfx] " Matthew Brost
2022-07-12 23:31 ` [PATCH 10/12] drm/i915/guc: Support larger contexts on newer hardware John.C.Harrison
2022-07-12 23:31 ` [Intel-gfx] " John.C.Harrison
2022-07-18 12:35 ` Tvrtko Ursulin
2022-07-19 0:13 ` John Harrison
2022-07-19 9:56 ` Tvrtko Ursulin
2022-07-22 19:32 ` John Harrison
2022-07-25 11:24 ` Tvrtko Ursulin [this message]
2022-07-12 23:31 ` [PATCH 11/12] drm/i915/guc: Don't abort on CTB_UNUSED status John.C.Harrison
2022-07-12 23:31 ` [Intel-gfx] " John.C.Harrison
2022-07-18 12:36 ` Tvrtko Ursulin
2022-07-19 0:16 ` John Harrison
2022-07-12 23:31 ` [PATCH 12/12] drm/i915/guc: Add a helper for log buffer size John.C.Harrison
2022-07-12 23:31 ` [Intel-gfx] " John.C.Harrison
2022-07-13 0:46 ` Matthew Brost
2022-07-13 0:46 ` [Intel-gfx] " Matthew Brost
2022-07-13 0:31 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning for Random assortment of (mostly) GuC related patches Patchwork
2022-07-13 20:09 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Random assortment of (mostly) GuC related patches (rev2) Patchwork
2022-07-13 20:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-07-14 1:41 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d04906d-87de-1c5b-5139-d32bdbcabc28@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=DRI-Devel@Lists.FreeDesktop.Org \
--cc=Intel-GFX@Lists.FreeDesktop.Org \
--cc=john.c.harrison@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.