From: Matthew Brost <matthew.brost@intel.com>
To: John.C.Harrison@Intel.com
Cc: Intel-GFX@Lists.FreeDesktop.Org, DRI-Devel@Lists.FreeDesktop.Org,
Alan Previn <alan.previn.teres.alexis@intel.com>
Subject: Re: [PATCH 12/12] drm/i915/guc: Add a helper for log buffer size
Date: Tue, 12 Jul 2022 17:46:48 -0700 [thread overview]
Message-ID: <20220713004648.GA2991@jons-linux-dev-box> (raw)
In-Reply-To: <20220712233136.1044951-13-John.C.Harrison@Intel.com>
On Tue, Jul 12, 2022 at 04:31:36PM -0700, John.C.Harrison@Intel.com wrote:
> From: Alan Previn <alan.previn.teres.alexis@intel.com>
>
> Add a helper to get GuC log buffer size.
>
> Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
John - you need to add a Signed-off-by since you posted.
Patch LGTM:
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
> ---
> drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 49 ++++++++++++----------
> 1 file changed, 27 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> index ff091adb56096..4bb81d2cf3828 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> @@ -15,6 +15,32 @@
>
> static void guc_log_copy_debuglogs_for_relay(struct intel_guc_log *log);
>
> +static u32 intel_guc_log_size(struct intel_guc_log *log)
> +{
> + /*
> + * GuC Log buffer Layout:
> + *
> + * NB: Ordering must follow "enum guc_log_buffer_type".
> + *
> + * +===============================+ 00B
> + * | Debug state header |
> + * +-------------------------------+ 32B
> + * | Crash dump state header |
> + * +-------------------------------+ 64B
> + * | Capture state header |
> + * +-------------------------------+ 96B
> + * | |
> + * +===============================+ PAGE_SIZE (4KB)
> + * | Debug logs |
> + * +===============================+ + DEBUG_SIZE
> + * | Crash Dump logs |
> + * +===============================+ + CRASH_SIZE
> + * | Capture logs |
> + * +===============================+ + CAPTURE_SIZE
> + */
> + return PAGE_SIZE + CRASH_BUFFER_SIZE + DEBUG_BUFFER_SIZE + CAPTURE_BUFFER_SIZE;
> +}
> +
> /**
> * DOC: GuC firmware log
> *
> @@ -461,32 +487,11 @@ int intel_guc_log_create(struct intel_guc_log *log)
>
> GEM_BUG_ON(log->vma);
>
> - /*
> - * GuC Log buffer Layout
> - * (this ordering must follow "enum guc_log_buffer_type" definition)
> - *
> - * +===============================+ 00B
> - * | Debug state header |
> - * +-------------------------------+ 32B
> - * | Crash dump state header |
> - * +-------------------------------+ 64B
> - * | Capture state header |
> - * +-------------------------------+ 96B
> - * | |
> - * +===============================+ PAGE_SIZE (4KB)
> - * | Debug logs |
> - * +===============================+ + DEBUG_SIZE
> - * | Crash Dump logs |
> - * +===============================+ + CRASH_SIZE
> - * | Capture logs |
> - * +===============================+ + CAPTURE_SIZE
> - */
> if (intel_guc_capture_output_min_size_est(guc) > CAPTURE_BUFFER_SIZE)
> DRM_WARN("GuC log buffer for state_capture maybe too small. %d < %d\n",
> CAPTURE_BUFFER_SIZE, intel_guc_capture_output_min_size_est(guc));
>
> - guc_log_size = PAGE_SIZE + CRASH_BUFFER_SIZE + DEBUG_BUFFER_SIZE +
> - CAPTURE_BUFFER_SIZE;
> + guc_log_size = intel_guc_log_size(log);
>
> vma = intel_guc_allocate_vma(guc, guc_log_size);
> if (IS_ERR(vma)) {
> --
> 2.36.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Brost <matthew.brost@intel.com>
To: John.C.Harrison@Intel.com
Cc: Intel-GFX@Lists.FreeDesktop.Org, DRI-Devel@Lists.FreeDesktop.Org,
Alan Previn <alan.previn.teres.alexis@intel.com>
Subject: Re: [Intel-gfx] [PATCH 12/12] drm/i915/guc: Add a helper for log buffer size
Date: Tue, 12 Jul 2022 17:46:48 -0700 [thread overview]
Message-ID: <20220713004648.GA2991@jons-linux-dev-box> (raw)
In-Reply-To: <20220712233136.1044951-13-John.C.Harrison@Intel.com>
On Tue, Jul 12, 2022 at 04:31:36PM -0700, John.C.Harrison@Intel.com wrote:
> From: Alan Previn <alan.previn.teres.alexis@intel.com>
>
> Add a helper to get GuC log buffer size.
>
> Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
John - you need to add a Signed-off-by since you posted.
Patch LGTM:
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
> ---
> drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 49 ++++++++++++----------
> 1 file changed, 27 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> index ff091adb56096..4bb81d2cf3828 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> @@ -15,6 +15,32 @@
>
> static void guc_log_copy_debuglogs_for_relay(struct intel_guc_log *log);
>
> +static u32 intel_guc_log_size(struct intel_guc_log *log)
> +{
> + /*
> + * GuC Log buffer Layout:
> + *
> + * NB: Ordering must follow "enum guc_log_buffer_type".
> + *
> + * +===============================+ 00B
> + * | Debug state header |
> + * +-------------------------------+ 32B
> + * | Crash dump state header |
> + * +-------------------------------+ 64B
> + * | Capture state header |
> + * +-------------------------------+ 96B
> + * | |
> + * +===============================+ PAGE_SIZE (4KB)
> + * | Debug logs |
> + * +===============================+ + DEBUG_SIZE
> + * | Crash Dump logs |
> + * +===============================+ + CRASH_SIZE
> + * | Capture logs |
> + * +===============================+ + CAPTURE_SIZE
> + */
> + return PAGE_SIZE + CRASH_BUFFER_SIZE + DEBUG_BUFFER_SIZE + CAPTURE_BUFFER_SIZE;
> +}
> +
> /**
> * DOC: GuC firmware log
> *
> @@ -461,32 +487,11 @@ int intel_guc_log_create(struct intel_guc_log *log)
>
> GEM_BUG_ON(log->vma);
>
> - /*
> - * GuC Log buffer Layout
> - * (this ordering must follow "enum guc_log_buffer_type" definition)
> - *
> - * +===============================+ 00B
> - * | Debug state header |
> - * +-------------------------------+ 32B
> - * | Crash dump state header |
> - * +-------------------------------+ 64B
> - * | Capture state header |
> - * +-------------------------------+ 96B
> - * | |
> - * +===============================+ PAGE_SIZE (4KB)
> - * | Debug logs |
> - * +===============================+ + DEBUG_SIZE
> - * | Crash Dump logs |
> - * +===============================+ + CRASH_SIZE
> - * | Capture logs |
> - * +===============================+ + CAPTURE_SIZE
> - */
> if (intel_guc_capture_output_min_size_est(guc) > CAPTURE_BUFFER_SIZE)
> DRM_WARN("GuC log buffer for state_capture maybe too small. %d < %d\n",
> CAPTURE_BUFFER_SIZE, intel_guc_capture_output_min_size_est(guc));
>
> - guc_log_size = PAGE_SIZE + CRASH_BUFFER_SIZE + DEBUG_BUFFER_SIZE +
> - CAPTURE_BUFFER_SIZE;
> + guc_log_size = intel_guc_log_size(log);
>
> vma = intel_guc_allocate_vma(guc, guc_log_size);
> if (IS_ERR(vma)) {
> --
> 2.36.0
>
next prev parent reply other threads:[~2022-07-13 0:53 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 23:31 [PATCH 00/12] Random assortment of (mostly) GuC related patches John.C.Harrison
2022-07-12 23:31 ` [Intel-gfx] " John.C.Harrison
2022-07-12 23:31 ` [PATCH 01/12] drm/i915: Remove bogus GEM_BUG_ON in unpark John.C.Harrison
2022-07-12 23:31 ` [Intel-gfx] " John.C.Harrison
2022-07-18 12:15 ` Tvrtko Ursulin
2022-07-19 0:05 ` John Harrison
2022-07-19 9:42 ` Tvrtko Ursulin
2022-07-21 0:54 ` John Harrison
2022-07-21 9:24 ` Tvrtko Ursulin
2022-07-22 19:09 ` John Harrison
2022-07-12 23:31 ` [PATCH 02/12] drm/i915/guc: Don't call ring_is_idle in GuC submission John.C.Harrison
2022-07-12 23:31 ` [Intel-gfx] " John.C.Harrison
2022-07-18 12:26 ` Tvrtko Ursulin
2022-07-19 0:09 ` John Harrison
2022-07-19 9:49 ` Tvrtko Ursulin
2022-07-19 10:14 ` Tvrtko Ursulin
2022-07-12 23:31 ` [PATCH 03/12] drm/i915/guc: Fix issues with live_preempt_cancel John.C.Harrison
2022-07-12 23:31 ` [Intel-gfx] " John.C.Harrison
2022-07-12 23:31 ` [PATCH 04/12] drm/i915/guc: Add GuC <-> kernel time stamp translation information John.C.Harrison
2022-07-12 23:31 ` [Intel-gfx] " John.C.Harrison
2022-07-12 23:31 ` [PATCH 05/12] drm/i915/guc: Record CTB info in error logs John.C.Harrison
2022-07-12 23:31 ` [Intel-gfx] " John.C.Harrison
2022-07-12 23:31 ` [PATCH 06/12] drm/i915/guc: Use streaming loads to speed up dumping the guc log John.C.Harrison
2022-07-12 23:31 ` [Intel-gfx] " John.C.Harrison
2022-07-22 20:05 ` John Harrison
2022-07-12 23:31 ` [PATCH 07/12] drm/i915/guc: Route semaphores to GuC for Gen12+ John.C.Harrison
2022-07-12 23:31 ` [Intel-gfx] " John.C.Harrison
2022-07-13 0:51 ` Matthew Brost
2022-07-13 0:51 ` [Intel-gfx] " Matthew Brost
2022-07-15 17:21 ` Ceraolo Spurio, Daniele
2022-07-15 17:21 ` [Intel-gfx] " Ceraolo Spurio, Daniele
2022-07-12 23:31 ` [PATCH 08/12] drm/i915/guc: Add selftest for a hung GuC John.C.Harrison
2022-07-12 23:31 ` [Intel-gfx] " John.C.Harrison
2022-07-12 23:31 ` [PATCH 09/12] drm/i915/selftest: Cope with not having an RCS engine John.C.Harrison
2022-07-12 23:31 ` [Intel-gfx] " John.C.Harrison
2022-07-13 0:48 ` Matthew Brost
2022-07-13 0:48 ` [Intel-gfx] " Matthew Brost
2022-07-12 23:31 ` [PATCH 10/12] drm/i915/guc: Support larger contexts on newer hardware John.C.Harrison
2022-07-12 23:31 ` [Intel-gfx] " John.C.Harrison
2022-07-18 12:35 ` Tvrtko Ursulin
2022-07-19 0:13 ` John Harrison
2022-07-19 9:56 ` Tvrtko Ursulin
2022-07-22 19:32 ` John Harrison
2022-07-25 11:24 ` Tvrtko Ursulin
2022-07-12 23:31 ` [PATCH 11/12] drm/i915/guc: Don't abort on CTB_UNUSED status John.C.Harrison
2022-07-12 23:31 ` [Intel-gfx] " John.C.Harrison
2022-07-18 12:36 ` Tvrtko Ursulin
2022-07-19 0:16 ` John Harrison
2022-07-12 23:31 ` [PATCH 12/12] drm/i915/guc: Add a helper for log buffer size John.C.Harrison
2022-07-12 23:31 ` [Intel-gfx] " John.C.Harrison
2022-07-13 0:46 ` Matthew Brost [this message]
2022-07-13 0:46 ` Matthew Brost
2022-07-13 0:31 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning for Random assortment of (mostly) GuC related patches Patchwork
2022-07-13 20:09 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Random assortment of (mostly) GuC related patches (rev2) Patchwork
2022-07-13 20:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-07-14 1:41 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220713004648.GA2991@jons-linux-dev-box \
--to=matthew.brost@intel.com \
--cc=DRI-Devel@Lists.FreeDesktop.Org \
--cc=Intel-GFX@Lists.FreeDesktop.Org \
--cc=John.C.Harrison@Intel.com \
--cc=alan.previn.teres.alexis@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.