From: Mike Christie <michael.christie@oracle.com>
To: Bart Van Assche <bvanassche@acm.org>,
linux-block@vger.kernel.org, dm-devel@redhat.com,
snitzer@kernel.org, axboe@kernel.dk, hch@lst.de,
linux-nvme@lists.infradead.org, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org,
james.bottomley@hansenpartnership.com
Subject: Re: [PATCH v2 04/20] scsi: Add support for block PR read keys/reservation.
Date: Tue, 9 Aug 2022 22:28:28 -0500 [thread overview]
Message-ID: <3d2e8c97-3097-4eb9-8852-3a41e42555df@oracle.com> (raw)
In-Reply-To: <a3117849-420b-65fb-dafa-c2a464482f7b@acm.org>
On 8/9/22 2:26 PM, Bart Van Assche wrote:
> On 8/8/22 17:04, Mike Christie wrote:
>> +static int sd_pr_in_command(struct block_device *bdev, u8 sa,
>> + unsigned char *data, int data_len)
>> +{
>> + struct scsi_disk *sdkp = scsi_disk(bdev->bd_disk);
>> + struct scsi_device *sdev = sdkp->device;
>> + struct scsi_sense_hdr sshdr;
>> + u8 cmd[10] = { 0, };
>> + int result;
>
> Isn't "{ }" instead of "{ 0, }" the preferred way to zero-initialize a data structure?
The original code used { 0, } and that seems common sd.c. { } was not used in sd.c.
I didn't see anything in coding-style.rst. It does not make any difference to me
other than it's better to be consistent unless we are supposed to be transitioning
to a new style.
>
>> +
>> + cmd[0] = PERSISTENT_RESERVE_IN;
>> + cmd[1] = sa;
>
> Can the above two assignments be moved into the initializer of cmd[]?
>
Yes, but it was like the first comment. The original code didn't do
that and it seemed more common to not do it. Do we want to switch
or are we transitioning? It does not matter to me. Both are simple changes.
WARNING: multiple messages have this Message-ID (diff)
From: Mike Christie <michael.christie@oracle.com>
To: Bart Van Assche <bvanassche@acm.org>,
linux-block@vger.kernel.org, dm-devel@redhat.com,
snitzer@kernel.org, axboe@kernel.dk, hch@lst.de,
linux-nvme@lists.infradead.org, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org,
james.bottomley@hansenpartnership.com
Subject: Re: [dm-devel] [PATCH v2 04/20] scsi: Add support for block PR read keys/reservation.
Date: Tue, 9 Aug 2022 22:28:28 -0500 [thread overview]
Message-ID: <3d2e8c97-3097-4eb9-8852-3a41e42555df@oracle.com> (raw)
In-Reply-To: <a3117849-420b-65fb-dafa-c2a464482f7b@acm.org>
On 8/9/22 2:26 PM, Bart Van Assche wrote:
> On 8/8/22 17:04, Mike Christie wrote:
>> +static int sd_pr_in_command(struct block_device *bdev, u8 sa,
>> + unsigned char *data, int data_len)
>> +{
>> + struct scsi_disk *sdkp = scsi_disk(bdev->bd_disk);
>> + struct scsi_device *sdev = sdkp->device;
>> + struct scsi_sense_hdr sshdr;
>> + u8 cmd[10] = { 0, };
>> + int result;
>
> Isn't "{ }" instead of "{ 0, }" the preferred way to zero-initialize a data structure?
The original code used { 0, } and that seems common sd.c. { } was not used in sd.c.
I didn't see anything in coding-style.rst. It does not make any difference to me
other than it's better to be consistent unless we are supposed to be transitioning
to a new style.
>
>> +
>> + cmd[0] = PERSISTENT_RESERVE_IN;
>> + cmd[1] = sa;
>
> Can the above two assignments be moved into the initializer of cmd[]?
>
Yes, but it was like the first comment. The original code didn't do
that and it seemed more common to not do it. Do we want to switch
or are we transitioning? It does not matter to me. Both are simple changes.
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2022-08-10 3:28 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 0:03 [PATCH 0/20] Use block pr_ops in LIO Mike Christie
2022-08-09 0:03 ` [dm-devel] " Mike Christie
2022-08-09 0:04 ` [PATCH v2 01/20] block: Add PR callouts for read keys and reservation Mike Christie
2022-08-09 0:04 ` [dm-devel] " Mike Christie
2022-08-09 0:04 ` [PATCH v2 02/20] scsi: Rename sd_pr_command Mike Christie
2022-08-09 0:04 ` [dm-devel] " Mike Christie
2022-08-09 19:22 ` Bart Van Assche
2022-08-09 19:22 ` [dm-devel] " Bart Van Assche
2022-08-09 0:04 ` [PATCH v2 03/20] scsi: Move sd_pr_type to header to share Mike Christie
2022-08-09 0:04 ` [dm-devel] " Mike Christie
2022-08-09 0:04 ` [PATCH v2 04/20] scsi: Add support for block PR read keys/reservation Mike Christie
2022-08-09 0:04 ` [dm-devel] " Mike Christie
2022-08-09 19:26 ` Bart Van Assche
2022-08-09 19:26 ` [dm-devel] " Bart Van Assche
2022-08-10 3:28 ` Mike Christie [this message]
2022-08-10 3:28 ` Mike Christie
2022-08-09 0:04 ` [PATCH v2 05/20] dm: " Mike Christie
2022-08-09 0:04 ` [dm-devel] " Mike Christie
2022-08-09 0:04 ` [PATCH v2 06/20] nvme: Fix reservation status related structs Mike Christie
2022-08-09 0:04 ` [dm-devel] " Mike Christie
2022-08-09 7:19 ` Christoph Hellwig
2022-08-09 7:19 ` [dm-devel] " Christoph Hellwig
2022-08-09 11:09 ` Chaitanya Kulkarni
2022-08-09 11:09 ` [dm-devel] " Chaitanya Kulkarni
2022-08-09 0:04 ` [PATCH v2 07/20] nvme: Don't hardcode the data len for pr commands Mike Christie
2022-08-09 0:04 ` [dm-devel] " Mike Christie
2022-08-09 7:19 ` Christoph Hellwig
2022-08-09 7:19 ` [dm-devel] " Christoph Hellwig
2022-08-09 0:04 ` [PATCH v2 08/20] nvme: Add helper to convert to a pr_ops PR type Mike Christie
2022-08-09 0:04 ` [dm-devel] " Mike Christie
2022-08-09 7:20 ` Christoph Hellwig
2022-08-09 7:20 ` [dm-devel] " Christoph Hellwig
2022-08-09 11:12 ` Chaitanya Kulkarni
2022-08-09 11:12 ` [dm-devel] " Chaitanya Kulkarni
2022-08-09 0:04 ` [PATCH v2 09/20] nvme: Add helper to execute Reservation Report Mike Christie
2022-08-09 0:04 ` [dm-devel] " Mike Christie
2022-08-09 10:55 ` Chaitanya Kulkarni
2022-08-09 10:55 ` [dm-devel] " Chaitanya Kulkarni
2022-08-09 16:18 ` Mike Christie
2022-08-09 16:18 ` [dm-devel] " Mike Christie
2022-08-09 10:56 ` Chaitanya Kulkarni
2022-08-09 10:56 ` [dm-devel] " Chaitanya Kulkarni
2022-08-09 14:51 ` Keith Busch
2022-08-09 14:51 ` [dm-devel] " Keith Busch
2022-08-09 16:21 ` Mike Christie
2022-08-09 16:21 ` [dm-devel] " Mike Christie
2022-08-10 1:45 ` Chaitanya Kulkarni
2022-08-10 1:45 ` [dm-devel] " Chaitanya Kulkarni
2022-08-10 3:17 ` Keith Busch
2022-08-10 3:17 ` [dm-devel] " Keith Busch
2022-08-10 4:54 ` Chaitanya Kulkarni
2022-08-10 4:54 ` [dm-devel] " Chaitanya Kulkarni
2022-08-09 0:04 ` [PATCH v2 10/20] nvme: Add pr_ops read_keys support Mike Christie
2022-08-09 0:04 ` [dm-devel] " Mike Christie
2022-08-09 0:04 ` [PATCH v2 11/20] nvme: Add pr_ops read_reservation support Mike Christie
2022-08-09 0:04 ` [dm-devel] " Mike Christie
2022-08-09 0:04 ` [PATCH v2 12/20] block,nvme,scsi,dm: Add blk_status to pr_ops callouts Mike Christie
2022-08-09 0:04 ` [dm-devel] [PATCH v2 12/20] block, nvme, scsi, dm: " Mike Christie
2022-08-09 7:21 ` [PATCH v2 12/20] block,nvme,scsi,dm: " Christoph Hellwig
2022-08-09 7:21 ` [dm-devel] [PATCH v2 12/20] block, nvme, scsi, dm: " Christoph Hellwig
2022-08-09 18:08 ` [PATCH v2 12/20] block,nvme,scsi,dm: " Mike Christie
2022-08-09 18:08 ` [dm-devel] [PATCH v2 12/20] block, nvme, scsi, dm: " Mike Christie
2022-08-09 19:33 ` [PATCH v2 12/20] block,nvme,scsi,dm: " Bart Van Assche
2022-08-09 19:33 ` [dm-devel] [PATCH v2 12/20] block, nvme, scsi, dm: " Bart Van Assche
2022-08-10 3:34 ` [PATCH v2 12/20] block,nvme,scsi,dm: " Mike Christie
2022-08-10 3:34 ` [dm-devel] [PATCH v2 12/20] block, nvme, scsi, dm: " Mike Christie
2022-08-09 0:04 ` [PATCH v2 13/20] nvme: Have nvme pr_ops return a blk_status_t Mike Christie
2022-08-09 0:04 ` [dm-devel] " Mike Christie
2022-08-09 10:58 ` Chaitanya Kulkarni
2022-08-09 10:58 ` [dm-devel] " Chaitanya Kulkarni
2022-08-09 0:04 ` [PATCH v2 14/20] scsi: Retry pr_ops commands if a UA is returned Mike Christie
2022-08-09 0:04 ` [dm-devel] " Mike Christie
2022-08-09 7:16 ` Christoph Hellwig
2022-08-09 7:16 ` [dm-devel] " Christoph Hellwig
2022-08-09 16:24 ` Mike Christie
2022-08-09 16:24 ` [dm-devel] " Mike Christie
2022-08-09 19:31 ` Bart Van Assche
2022-08-09 19:31 ` [dm-devel] " Bart Van Assche
2022-08-09 0:04 ` [PATCH v2 15/20] scsi: Export scsi_result_to_blk_status Mike Christie
2022-08-09 0:04 ` [dm-devel] " Mike Christie
2022-08-09 0:04 ` [PATCH v2 16/20] scsi: Have sd pr_ops return a blk_status_t Mike Christie
2022-08-09 0:04 ` [dm-devel] " Mike Christie
2022-08-09 7:18 ` Christoph Hellwig
2022-08-09 7:18 ` [dm-devel] " Christoph Hellwig
2022-08-09 16:22 ` Mike Christie
2022-08-09 16:22 ` [dm-devel] " Mike Christie
2022-08-09 0:04 ` [PATCH v2 17/20] scsi: target: Rename sbc_ops to exec_cmd_ops Mike Christie
2022-08-09 0:04 ` [dm-devel] " Mike Christie
2022-08-09 0:04 ` [dm-devel] [PATCH v2 18/20] scsi: target: Allow backends to hook into PR handling Mike Christie
2022-08-09 0:04 ` Mike Christie
2022-08-09 0:04 ` [dm-devel] [PATCH v2 19/20] scsi: target: Don't support SCSI-2 RESERVE/RELEASE Mike Christie
2022-08-09 0:04 ` Mike Christie
2022-08-09 0:04 ` [PATCH v2 20/20] scsi: target: Add block PR support to iblock Mike Christie
2022-08-09 0:04 ` [dm-devel] " Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d2e8c97-3097-4eb9-8852-3a41e42555df@oracle.com \
--to=michael.christie@oracle.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.