From: "yukuai (C)" <yukuai3@huawei.com>
To: kernel test robot <lkp@intel.com>, <tj@kernel.org>,
<axboe@kernel.dk>, <ming.lei@redhat.com>
Cc: <kbuild-all@lists.01.org>, <cgroups@vger.kernel.org>,
<linux-block@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<yi.zhang@huawei.com>
Subject: Re: [PATCH -next v2 2/2] blk-throttle: fix io hung due to configuration updates
Date: Thu, 19 May 2022 11:01:19 +0800 [thread overview]
Message-ID: <3d6878f4-1902-633d-0af2-276831364a4f@huawei.com> (raw)
In-Reply-To: <84fe296e-6e56-3ca9-73a8-357beb675c6e@huawei.com>
在 2022/05/19 10:11, yukuai (C) 写道:
>
>
> 在 2022/05/18 23:52, kernel test robot 写道:
>> Hi Yu,
>>
>> Thank you for the patch! Yet something to improve:
>>
>> [auto build test ERROR on next-20220517]
>>
>> url:
>> https://github.com/intel-lab-lkp/linux/commits/Yu-Kuai/bugfix-for-blk-throttle/20220518-151713
>>
>> base: 47c1c54d1bcd0a69a56b49473bc20f17b70e5242
>> config: m68k-allyesconfig
>> (https://download.01.org/0day-ci/archive/20220518/202205182347.tMOOqyfL-lkp@intel.com/config)
>>
>> compiler: m68k-linux-gcc (GCC) 11.3.0
>> reproduce (this is a W=1 build):
>> wget
>> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
>> -O ~/bin/make.cross
>> chmod +x ~/bin/make.cross
>> #
>> https://github.com/intel-lab-lkp/linux/commit/f8345dbaf4ed491742aab29834aff66b4930c087
>>
>> git remote add linux-review
>> https://github.com/intel-lab-lkp/linux
>> git fetch --no-tags linux-review
>> Yu-Kuai/bugfix-for-blk-throttle/20220518-151713
>> git checkout f8345dbaf4ed491742aab29834aff66b4930c087
>> # save the config file
>> mkdir build_dir && cp config build_dir/.config
>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0
>> make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> All errors (new ones prefixed by >>):
>>
>> m68k-linux-ld: block/blk-throttle.o: in function `tg_conf_updated':
>>>> blk-throttle.c:(.text+0x25bc): undefined reference to `__udivdi3'
>>>> m68k-linux-ld: blk-throttle.c:(.text+0x2626): undefined reference to
>>>> `__udivdi3'
> Hi,
>
> I'm confused here, the only place that I can relate to this:
>
> return dispatched * new_limit / old_limit;
>
I understand it now. I'm doing (u64 / u64), I should use div64_u64
> However, I don't understand yet why this is problematic...
>> `.exit.text' referenced in section `.data' of
>> sound/soc/codecs/tlv320adc3xxx.o: defined in discarded section
>> `.exit.text' of sound/soc/codecs/tlv320adc3xxx.o
>>
WARNING: multiple messages have this Message-ID (diff)
From: yukuai (C) <yukuai3@huawei.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH -next v2 2/2] blk-throttle: fix io hung due to configuration updates
Date: Thu, 19 May 2022 11:01:19 +0800 [thread overview]
Message-ID: <3d6878f4-1902-633d-0af2-276831364a4f@huawei.com> (raw)
In-Reply-To: <84fe296e-6e56-3ca9-73a8-357beb675c6e@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 2293 bytes --]
在 2022/05/19 10:11, yukuai (C) 写道:
>
>
> 在 2022/05/18 23:52, kernel test robot 写道:
>> Hi Yu,
>>
>> Thank you for the patch! Yet something to improve:
>>
>> [auto build test ERROR on next-20220517]
>>
>> url:
>> https://github.com/intel-lab-lkp/linux/commits/Yu-Kuai/bugfix-for-blk-throttle/20220518-151713
>>
>> base: 47c1c54d1bcd0a69a56b49473bc20f17b70e5242
>> config: m68k-allyesconfig
>> (https://download.01.org/0day-ci/archive/20220518/202205182347.tMOOqyfL-lkp(a)intel.com/config)
>>
>> compiler: m68k-linux-gcc (GCC) 11.3.0
>> reproduce (this is a W=1 build):
>> wget
>> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
>> -O ~/bin/make.cross
>> chmod +x ~/bin/make.cross
>> #
>> https://github.com/intel-lab-lkp/linux/commit/f8345dbaf4ed491742aab29834aff66b4930c087
>>
>> git remote add linux-review
>> https://github.com/intel-lab-lkp/linux
>> git fetch --no-tags linux-review
>> Yu-Kuai/bugfix-for-blk-throttle/20220518-151713
>> git checkout f8345dbaf4ed491742aab29834aff66b4930c087
>> # save the config file
>> mkdir build_dir && cp config build_dir/.config
>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0
>> make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> All errors (new ones prefixed by >>):
>>
>> m68k-linux-ld: block/blk-throttle.o: in function `tg_conf_updated':
>>>> blk-throttle.c:(.text+0x25bc): undefined reference to `__udivdi3'
>>>> m68k-linux-ld: blk-throttle.c:(.text+0x2626): undefined reference to
>>>> `__udivdi3'
> Hi,
>
> I'm confused here, the only place that I can relate to this:
>
> return dispatched * new_limit / old_limit;
>
I understand it now. I'm doing (u64 / u64), I should use div64_u64
> However, I don't understand yet why this is problematic...
>> `.exit.text' referenced in section `.data' of
>> sound/soc/codecs/tlv320adc3xxx.o: defined in discarded section
>> `.exit.text' of sound/soc/codecs/tlv320adc3xxx.o
>>
WARNING: multiple messages have this Message-ID (diff)
From: "yukuai (C)" <yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: kernel test robot <lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org,
ming.lei-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Cc: kbuild-all-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
yi.zhang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH -next v2 2/2] blk-throttle: fix io hung due to configuration updates
Date: Thu, 19 May 2022 11:01:19 +0800 [thread overview]
Message-ID: <3d6878f4-1902-633d-0af2-276831364a4f@huawei.com> (raw)
In-Reply-To: <84fe296e-6e56-3ca9-73a8-357beb675c6e-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
在 2022/05/19 10:11, yukuai (C) 写道:
>
>
> 在 2022/05/18 23:52, kernel test robot 写道:
>> Hi Yu,
>>
>> Thank you for the patch! Yet something to improve:
>>
>> [auto build test ERROR on next-20220517]
>>
>> url:
>> https://github.com/intel-lab-lkp/linux/commits/Yu-Kuai/bugfix-for-blk-throttle/20220518-151713
>>
>> base: 47c1c54d1bcd0a69a56b49473bc20f17b70e5242
>> config: m68k-allyesconfig
>> (https://download.01.org/0day-ci/archive/20220518/202205182347.tMOOqyfL-lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org/config)
>>
>> compiler: m68k-linux-gcc (GCC) 11.3.0
>> reproduce (this is a W=1 build):
>> wget
>> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
>> -O ~/bin/make.cross
>> chmod +x ~/bin/make.cross
>> #
>> https://github.com/intel-lab-lkp/linux/commit/f8345dbaf4ed491742aab29834aff66b4930c087
>>
>> git remote add linux-review
>> https://github.com/intel-lab-lkp/linux
>> git fetch --no-tags linux-review
>> Yu-Kuai/bugfix-for-blk-throttle/20220518-151713
>> git checkout f8345dbaf4ed491742aab29834aff66b4930c087
>> # save the config file
>> mkdir build_dir && cp config build_dir/.config
>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0
>> make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>>
>> All errors (new ones prefixed by >>):
>>
>> m68k-linux-ld: block/blk-throttle.o: in function `tg_conf_updated':
>>>> blk-throttle.c:(.text+0x25bc): undefined reference to `__udivdi3'
>>>> m68k-linux-ld: blk-throttle.c:(.text+0x2626): undefined reference to
>>>> `__udivdi3'
> Hi,
>
> I'm confused here, the only place that I can relate to this:
>
> return dispatched * new_limit / old_limit;
>
I understand it now. I'm doing (u64 / u64), I should use div64_u64
> However, I don't understand yet why this is problematic...
>> `.exit.text' referenced in section `.data' of
>> sound/soc/codecs/tlv320adc3xxx.o: defined in discarded section
>> `.exit.text' of sound/soc/codecs/tlv320adc3xxx.o
>>
next prev parent reply other threads:[~2022-05-19 3:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 7:27 [PATCH -next v2 0/2] bugfix for blk-throttle Yu Kuai
2022-05-18 7:27 ` Yu Kuai
2022-05-18 7:27 ` [PATCH -next v2 1/2] blk-throttle: fix that io throttle can only work for single bio Yu Kuai
2022-05-18 7:27 ` Yu Kuai
2022-05-18 9:50 ` Ming Lei
2022-05-18 7:27 ` [PATCH -next v2 2/2] blk-throttle: fix io hung due to configuration updates Yu Kuai
2022-05-18 7:27 ` Yu Kuai
2022-05-18 15:52 ` kernel test robot
2022-05-18 15:52 ` kernel test robot
2022-05-19 2:11 ` yukuai (C)
2022-05-19 2:11 ` yukuai (C)
2022-05-19 2:11 ` yukuai
2022-05-19 3:01 ` yukuai (C) [this message]
2022-05-19 3:01 ` yukuai (C)
2022-05-19 3:01 ` yukuai
2022-05-19 7:01 ` Geert Uytterhoeven
2022-05-19 7:01 ` Geert Uytterhoeven
2022-05-19 7:06 ` yukuai (C)
2022-05-19 7:06 ` yukuai (C)
2022-05-19 7:06 ` yukuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d6878f4-1902-633d-0af2-276831364a4f@huawei.com \
--to=yukuai3@huawei.com \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=ming.lei@redhat.com \
--cc=tj@kernel.org \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.