Re: [PATCH v2 04/12] riscv: dts: allwinner: Add the D1/D1s SoC devicetree

From: Icenowy Zheng <uwu@icenowy.me>
To: Andre Przywara <andre.przywara@arm.com>,
	Samuel Holland <samuel@sholland.org>
Cc: Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	linux-sunxi@lists.linux.dev, Palmer Dabbelt <palmer@dabbelt.com>,
	Conor Dooley <conor@kernel.org>,
	linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
	 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	 Jisheng Zhang <jszhang@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,  Albert Ou <aou@eecs.berkeley.edu>,
	Anup Patel <apatel@ventanamicro.com>,
	Atish Patra <atishp@rivosinc.com>,
	Christian Hewitt <christianshewitt@gmail.com>,
	Conor Dooley <conor.dooley@microchip.com>,
	Guo Ren <guoren@kernel.org>,
	Heinrich Schuchardt <heinrich.schuchardt@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	 Paul Walmsley <paul.walmsley@sifive.com>,
	Stanislav Jakubek <stano.jakubek@gmail.com>
Subject: Re: [PATCH v2 04/12] riscv: dts: allwinner: Add the D1/D1s SoC devicetree
Date: Fri, 02 Dec 2022 16:29:56 +0800	[thread overview]
Message-ID: <3e0920a446cbc363cee50b5e6174556f75561588.camel@icenowy.me> (raw)
In-Reply-To: <20221127174107.66e6630f@slackpad.lan>

在 2022-11-27星期日的 17:41 +0000，Andre Przywara写道：
> On Fri, 25 Nov 2022 17:46:48 -0600
> Samuel Holland <samuel@sholland.org> wrote:
> 
> > D1 (aka D1-H), D1s (aka F133), R528, and T113 are a family of SoCs
> > based
> > on a single die, or at a pair of dies derived from the same design.
> > 
> > D1 and D1s contain a single T-HEAD Xuantie C906 CPU, whereas R528
> > and
> > T113 contain a pair of Cortex-A7's. D1 and R528 are the full
> > version of
> > the chip with a BGA package, whereas D1s and T113 are low-pin-count
> > QFP
> > variants.
> > 
> > Because the original design supported both ARM and RISC-V CPUs,
> > some
> > peripherals are duplicated. In addition, all variants except D1s
> > contain
> > a HiFi 4 DSP with its own set of peripherals.
> > 
> > The devicetrees are organized to minimize duplication:
> >  - Common perhiperals are described in sunxi-d1s-t113.dtsi
> 
> So I compared all the reg and interrupts properties against the T113
> manual, they match, as far as they are described there. The
> undocumented
> rest matches what we already have in other SoCs.
> 
> I noticed two things, though, mentioned inline below:
> 
> >  - DSP-related peripherals are described in sunxi-d1-t113.dtsi
> >  - RISC-V specific hardware is described in sun20i-d1s.dtsi
> >  - Functionality unique to the D1 variant is described in sun20i-
> > d1.dtsi
> > 
> > The SOC_PERIPHERAL_IRQ macro handles the different #interrupt-cells
> > values between the ARM (GIC) and RISC-V (PLIC) versions of the SoC.
> > 
> > Signed-off-by: Samuel Holland <samuel@sholland.org>
> > ---
> > 
> > Changes in v2:
> >  - Split into separate files for sharing with D1s/R528/T113
> >  - Use SOC_PERIPHERAL_IRQ macro for interrupts
> >  - Rename osc24M to dcxo and move the frequency to the board DTs
> >  - Drop analog LDOs due to the missing binding
> >  - Correct tcon_top DSI clock reference
> >  - Add DMIC, DSI controller, and DPHY (bindings are in linux-next)
> >  - Add CPU OPP table
> > 
> >  arch/riscv/boot/dts/allwinner/sun20i-d1.dtsi  |  66 ++
> >  arch/riscv/boot/dts/allwinner/sun20i-d1s.dtsi |  76 ++
> >  .../boot/dts/allwinner/sunxi-d1-t113.dtsi     |  15 +
> >  .../boot/dts/allwinner/sunxi-d1s-t113.dtsi    | 844
> > ++++++++++++++++++
> >  4 files changed, 1001 insertions(+)
> >  create mode 100644 arch/riscv/boot/dts/allwinner/sun20i-d1.dtsi
> >  create mode 100644 arch/riscv/boot/dts/allwinner/sun20i-d1s.dtsi
> >  create mode 100644 arch/riscv/boot/dts/allwinner/sunxi-d1-
> > t113.dtsi
> >  create mode 100644 arch/riscv/boot/dts/allwinner/sunxi-d1s-
> > t113.dtsi
> > 
> > diff --git a/arch/riscv/boot/dts/allwinner/sun20i-d1.dtsi
> > b/arch/riscv/boot/dts/allwinner/sun20i-d1.dtsi
> > new file mode 100644
> > index 000000000000..97e7cbb32597
> > --- /dev/null
> > +++ b/arch/riscv/boot/dts/allwinner/sun20i-d1.dtsi
> > @@ -0,0 +1,66 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ or MIT)
> > +// Copyright (C) 2021-2022 Samuel Holland <samuel@sholland.org>
> > +
> > +#include "sun20i-d1s.dtsi"
> > +#include "sunxi-d1-t113.dtsi"
> > +
> > +/ {
> > +       soc {
> > +               lradc: keys@2009800 {
> > +                       compatible = "allwinner,sun20i-d1-lradc",
> > +                                    "allwinner,sun50i-r329-lradc";
> > +                       reg = <0x2009800 0x400>;
> > +                       interrupts = <SOC_PERIPHERAL_IRQ(61)
> > IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&ccu CLK_BUS_LRADC>;
> > +                       resets = <&ccu RST_BUS_LRADC>;
> > +                       status = "disabled";
> > +               };
> > +
> > +               i2s0: i2s@2032000 {
> > +                       compatible = "allwinner,sun20i-d1-i2s",
> > +                                    "allwinner,sun50i-r329-i2s";
> > +                       reg = <0x2032000 0x1000>;
> > +                       interrupts = <SOC_PERIPHERAL_IRQ(26)
> > IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&ccu CLK_BUS_I2S0>,
> > +                                <&ccu CLK_I2S0>;
> > +                       clock-names = "apb", "mod";
> > +                       resets = <&ccu RST_BUS_I2S0>;
> > +                       dmas = <&dma 3>, <&dma 3>;
> > +                       dma-names = "rx", "tx";
> > +                       status = "disabled";
> > +                       #sound-dai-cells = <0>;
> > +               };
> > +       };
> > +};
> > +
> > +&pio {
> > +       /omit-if-no-ref/
> > +       dmic_pb11_d0_pin: dmic-pb11-d0-pin {
> > +               pins = "PB11";
> > +               function = "dmic";
> > +       };
> > +
> > +       /omit-if-no-ref/
> > +       dmic_pe17_clk_pin: dmic-pe17-clk-pin {
> > +               pins = "PE17";
> > +               function = "dmic";
> > +       };
> > +
> > +       /omit-if-no-ref/
> > +       i2c0_pb10_pins: i2c0-pb10-pins {
> > +               pins = "PB10", "PB11";
> > +               function = "i2c0";
> > +       };
> > +
> > +       /omit-if-no-ref/
> > +       i2c2_pb0_pins: i2c2-pb0-pins {
> > +               pins = "PB0", "PB1";
> > +               function = "i2c2";
> > +       };
> > +
> > +       /omit-if-no-ref/
> > +       uart0_pb8_pins: uart0-pb8-pins {
> > +               pins = "PB8", "PB9";
> > +               function = "uart0";
> > +       };
> > +};
> > diff --git a/arch/riscv/boot/dts/allwinner/sun20i-d1s.dtsi
> > b/arch/riscv/boot/dts/allwinner/sun20i-d1s.dtsi
> > new file mode 100644
> > index 000000000000..859509832d58
> > --- /dev/null
> > +++ b/arch/riscv/boot/dts/allwinner/sun20i-d1s.dtsi
> > @@ -0,0 +1,76 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ or MIT)
> > +// Copyright (C) 2021-2022 Samuel Holland <samuel@sholland.org>
> > +
> > +#define SOC_PERIPHERAL_IRQ(nr) (nr + 16)
> > +
> > +#include "sunxi-d1s-t113.dtsi"
> > +
> > +/ {
> > +       cpus {
> > +               timebase-frequency = <24000000>;
> > +               #address-cells = <1>;
> > +               #size-cells = <0>;
> > +
> > +               cpu0: cpu@0 {
> > +                       compatible = "thead,c906", "riscv";
> > +                       device_type = "cpu";
> > +                       reg = <0>;
> > +                       clocks = <&ccu CLK_RISCV>;
> > +                       d-cache-block-size = <64>;
> > +                       d-cache-sets = <256>;
> > +                       d-cache-size = <32768>;
> > +                       i-cache-block-size = <64>;
> > +                       i-cache-sets = <128>;
> > +                       i-cache-size = <32768>;
> > +                       mmu-type = "riscv,sv39";
> > +                       operating-points-v2 = <&opp_table_cpu>;
> > +                       riscv,isa = "rv64imafdc";
> > +                       #cooling-cells = <2>;
> > +
> > +                       cpu0_intc: interrupt-controller {
> > +                               compatible = "riscv,cpu-intc";
> > +                               interrupt-controller;
> > +                               #address-cells = <0>;
> > +                               #interrupt-cells = <1>;
> > +                       };
> > +               };
> > +       };
> > +
> > +       opp_table_cpu: opp-table-cpu {
> > +               compatible = "operating-points-v2";
> > +
> > +               opp-408000000 {
> > +                       opp-hz = /bits/ 64 <408000000>;
> > +                       opp-microvolt = <900000 900000 1100000>;
> > +               };
> > +
> > +               opp-1080000000 {
> > +                       opp-hz = /bits/ 64 <1008000000>;
> > +                       opp-microvolt = <900000 900000 1100000>;
> > +               };
> > +       };
> > +
> > +       soc {
> > +               interrupt-parent = <&plic>;
> > +
> > +               riscv_wdt: watchdog@6011000 {
> > +                       compatible = "allwinner,sun20i-d1-wdt";
> > +                       reg = <0x6011000 0x20>;
> > +                       interrupts = <SOC_PERIPHERAL_IRQ(131)
> > IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&dcxo>, <&rtc CLK_OSC32K>;
> > +                       clock-names = "hosc", "losc";
> > +               };
> > +
> > +               plic: interrupt-controller@10000000 {
> > +                       compatible = "allwinner,sun20i-d1-plic",
> > +                                    "thead,c900-plic";
> > +                       reg = <0x10000000 0x4000000>;
> > +                       interrupts-extended = <&cpu0_intc 11>,
> > +                                             <&cpu0_intc 9>;
> > +                       interrupt-controller;
> > +                       riscv,ndev = <176>;
> > +                       #address-cells = <0>;
> > +                       #interrupt-cells = <2>;
> > +               };
> > +       };
> > +};
> > diff --git a/arch/riscv/boot/dts/allwinner/sunxi-d1-t113.dtsi
> > b/arch/riscv/boot/dts/allwinner/sunxi-d1-t113.dtsi
> > new file mode 100644
> > index 000000000000..b7156123df54
> > --- /dev/null
> > +++ b/arch/riscv/boot/dts/allwinner/sunxi-d1-t113.dtsi
> > @@ -0,0 +1,15 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ or MIT)
> > +// Copyright (C) 2021-2022 Samuel Holland <samuel@sholland.org>
> > +
> > +/ {
> > +       soc {
> > +               dsp_wdt: watchdog@1700400 {
> > +                       compatible = "allwinner,sun20i-d1-wdt";
> > +                       reg = <0x1700400 0x20>;
> > +                       interrupts = <SOC_PERIPHERAL_IRQ(122)
> > IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&dcxo>, <&rtc CLK_OSC32K>;
> > +                       clock-names = "hosc", "losc";
> > +                       status = "reserved";
> > +               };
> > +       };
> > +};
> > diff --git a/arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi
> > b/arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi
> > new file mode 100644
> > index 000000000000..c8815cbf0b46
> > --- /dev/null
> > +++ b/arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi
> > @@ -0,0 +1,844 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ or MIT)
> > +// Copyright (C) 2021-2022 Samuel Holland <samuel@sholland.org>
> > +
> > +#include <dt-bindings/clock/sun6i-rtc.h>
> > +#include <dt-bindings/clock/sun8i-de2.h>
> > +#include <dt-bindings/clock/sun8i-tcon-top.h>
> > +#include <dt-bindings/clock/sun20i-d1-ccu.h>
> > +#include <dt-bindings/clock/sun20i-d1-r-ccu.h>
> > +#include <dt-bindings/interrupt-controller/irq.h>
> > +#include <dt-bindings/reset/sun8i-de2.h>
> > +#include <dt-bindings/reset/sun20i-d1-ccu.h>
> > +#include <dt-bindings/reset/sun20i-d1-r-ccu.h>
> > +
> > +/ {
> > +       #address-cells = <1>;
> > +       #size-cells = <1>;
> > +
> > +       dcxo: dcxo-clk {
> > +               compatible = "fixed-clock";
> > +               /* This value must be overridden by the board */
> > +               clock-frequency = <0>;
> > +               clock-output-names = "dcxo";
> > +               #clock-cells = <0>;
> > +       };
> > +
> > +       de: display-engine {
> > +               compatible = "allwinner,sun20i-d1-display-engine";
> > +               allwinner,pipelines = <&mixer0>, <&mixer1>;
> > +               status = "disabled";
> > +       };
> > +
> > +       soc {
> > +               compatible = "simple-bus";
> > +               ranges;
> > +               dma-noncoherent;
> > +               #address-cells = <1>;
> > +               #size-cells = <1>;
> > +
> > +               pio: pinctrl@2000000 {
> > +                       compatible = "allwinner,sun20i-d1-pinctrl";
> > +                       reg = <0x2000000 0x800>;
> > +                       interrupts = <SOC_PERIPHERAL_IRQ(69)
> > IRQ_TYPE_LEVEL_HIGH>,
> > +                                    <SOC_PERIPHERAL_IRQ(71)
> > IRQ_TYPE_LEVEL_HIGH>,
> > +                                    <SOC_PERIPHERAL_IRQ(73)
> > IRQ_TYPE_LEVEL_HIGH>,
> > +                                    <SOC_PERIPHERAL_IRQ(75)
> > IRQ_TYPE_LEVEL_HIGH>,
> > +                                    <SOC_PERIPHERAL_IRQ(77)
> > IRQ_TYPE_LEVEL_HIGH>,
> > +                                    <SOC_PERIPHERAL_IRQ(79)
> > IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&ccu CLK_APB0>,
> > +                                <&dcxo>,
> > +                                <&rtc CLK_OSC32K>;
> > +                       clock-names = "apb", "hosc", "losc";
> > +                       gpio-controller;
> > +                       interrupt-controller;
> > +                       #gpio-cells = <3>;
> > +                       #interrupt-cells = <3>;
> > +
> > +                       /omit-if-no-ref/
> > +                       clk_pg11_pin: clk-pg11-pin {
> > +                               pins = "PG11";
> > +                               function = "clk";
> > +                       };
> > +
> > +                       /omit-if-no-ref/
> > +                       dsi_4lane_pins: dsi-4lane-pins {
> > +                               pins = "PD0", "PD1", "PD2", "PD3",
> > "PD4", "PD5",
> > +                                      "PD6", "PD7", "PD8", "PD9";
> > +                               drive-strength = <30>;
> > +                               function = "dsi";
> > +                       };
> > +
> > +                       /omit-if-no-ref/
> > +                       lcd_rgb666_pins: lcd-rgb666-pins {
> > +                               pins = "PD0", "PD1", "PD2", "PD3",
> > "PD4", "PD5",
> > +                                      "PD6", "PD7", "PD8", "PD9",
> > "PD10", "PD11",
> > +                                      "PD12", "PD13", "PD14",
> > "PD15", "PD16", "PD17",
> > +                                      "PD18", "PD19", "PD20",
> > "PD21";
> > +                               function = "lcd0";
> > +                       };
> > +
> > +                       /omit-if-no-ref/
> > +                       mmc0_pins: mmc0-pins {
> > +                               pins = "PF0", "PF1", "PF2", "PF3",
> > "PF4", "PF5";
> > +                               function = "mmc0";
> > +                       };
> > +
> > +                       /omit-if-no-ref/
> > +                       mmc1_pins: mmc1-pins {
> > +                               pins = "PG0", "PG1", "PG2", "PG3",
> > "PG4", "PG5";
> > +                               function = "mmc1";
> > +                       };
> > +
> > +                       /omit-if-no-ref/
> > +                       mmc2_pins: mmc2-pins {
> > +                               pins = "PC2", "PC3", "PC4", "PC5",
> > "PC6", "PC7";
> > +                               function = "mmc2";
> > +                       };
> > +
> > +                       /omit-if-no-ref/
> > +                       rgmii_pe_pins: rgmii-pe-pins {
> > +                               pins = "PE0", "PE1", "PE2", "PE3",
> > "PE4",
> > +                                      "PE5", "PE6", "PE7", "PE8",
> > "PE9",
> > +                                      "PE11", "PE12", "PE13",
> > "PE14", "PE15";
> > +                               function = "emac";
> > +                       };
> > +
> > +                       /omit-if-no-ref/
> > +                       rmii_pe_pins: rmii-pe-pins {
> > +                               pins = "PE0", "PE1", "PE2", "PE3",
> > "PE4",
> > +                                      "PE5", "PE6", "PE7", "PE8",
> > "PE9";
> > +                               function = "emac";
> > +                       };
> > +
> > +                       /omit-if-no-ref/
> > +                       uart1_pg6_pins: uart1-pg6-pins {
> > +                               pins = "PG6", "PG7";
> > +                               function = "uart1";
> > +                       };
> > +
> > +                       /omit-if-no-ref/
> > +                       uart1_pg8_rts_cts_pins: uart1-pg8-rts-cts-
> > pins {
> > +                               pins = "PG8", "PG9";
> > +                               function = "uart1";
> > +                       };
> > +
> > +                       /omit-if-no-ref/
> > +                       uart3_pb_pins: uart3-pb-pins {
> > +                               pins = "PB6", "PB7";
> > +                               function = "uart3";
> > +                       };
> > +               };
> > +
> > +               ccu: clock-controller@2001000 {
> > +                       compatible = "allwinner,sun20i-d1-ccu";
> > +                       reg = <0x2001000 0x1000>;
> > +                       clocks = <&dcxo>,
> > +                                <&rtc CLK_OSC32K>,
> > +                                <&rtc CLK_IOSC>;
> > +                       clock-names = "hosc", "losc", "iosc";
> > +                       #clock-cells = <1>;
> > +                       #reset-cells = <1>;
> > +               };
> > +
> > +               dmic: dmic@2031000 {
> > +                       compatible = "allwinner,sun20i-d1-dmic",
> > +                                    "allwinner,sun50i-h6-dmic";
> > +                       reg = <0x2031000 0x400>;
> > +                       interrupts = <SOC_PERIPHERAL_IRQ(24)
> > IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&ccu CLK_BUS_DMIC>,
> > +                                <&ccu CLK_DMIC>;
> > +                       clock-names = "bus", "mod";
> > +                       resets = <&ccu RST_BUS_DMIC>;
> > +                       dmas = <&dma 8>;
> > +                       dma-names = "rx";
> > +                       status = "disabled";
> > +                       #sound-dai-cells = <0>;
> > +               };
> > +
> > +               i2s1: i2s@2033000 {
> > +                       compatible = "allwinner,sun20i-d1-i2s",
> > +                                    "allwinner,sun50i-r329-i2s";
> > +                       reg = <0x2033000 0x1000>;
> > +                       interrupts = <SOC_PERIPHERAL_IRQ(27)
> > IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&ccu CLK_BUS_I2S1>,
> > +                                <&ccu CLK_I2S1>;
> > +                       clock-names = "apb", "mod";
> > +                       resets = <&ccu RST_BUS_I2S1>;
> > +                       dmas = <&dma 4>, <&dma 4>;
> > +                       dma-names = "rx", "tx";
> > +                       status = "disabled";
> > +                       #sound-dai-cells = <0>;
> > +               };
> > +
> > +               i2s2: i2s@2034000 {
> > +                       compatible = "allwinner,sun20i-d1-i2s",
> > +                                    "allwinner,sun50i-r329-i2s";
> > +                       reg = <0x2034000 0x1000>;
> > +                       interrupts = <SOC_PERIPHERAL_IRQ(28)
> > IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&ccu CLK_BUS_I2S2>,
> > +                                <&ccu CLK_I2S2>;
> > +                       clock-names = "apb", "mod";
> > +                       resets = <&ccu RST_BUS_I2S2>;
> > +                       dmas = <&dma 5>, <&dma 5>;
> > +                       dma-names = "rx", "tx";
> > +                       status = "disabled";
> > +                       #sound-dai-cells = <0>;
> > +               };
> > +
> > +               timer: timer@2050000 {
> > +                       compatible = "allwinner,sun20i-d1-timer",
> > +                                    "allwinner,sun8i-a23-timer";
> > +                       reg = <0x2050000 0xa0>;
> > +                       interrupts = <SOC_PERIPHERAL_IRQ(59)
> > IRQ_TYPE_LEVEL_HIGH>,
> > +                                    <SOC_PERIPHERAL_IRQ(60)
> > IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&dcxo>;
> > +               };
> > +
> > +               wdt: watchdog@20500a0 {
> > +                       compatible = "allwinner,sun20i-d1-wdt-
> > reset",
> > +                                    "allwinner,sun20i-d1-wdt";
> > +                       reg = <0x20500a0 0x20>;
> > +                       interrupts = <SOC_PERIPHERAL_IRQ(63)
> > IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&dcxo>, <&rtc CLK_OSC32K>;
> > +                       clock-names = "hosc", "losc";
> > +                       status = "reserved";
> > +               };
> > +
> > +               uart0: serial@2500000 {
> > +                       compatible = "snps,dw-apb-uart";
> > +                       reg = <0x2500000 0x400>;
> > +                       reg-io-width = <4>;
> > +                       reg-shift = <2>;
> > +                       interrupts = <SOC_PERIPHERAL_IRQ(2)
> > IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&ccu CLK_BUS_UART0>;
> > +                       resets = <&ccu RST_BUS_UART0>;
> > +                       dmas = <&dma 14>, <&dma 14>;
> > +                       dma-names = "rx", "tx";
> > +                       status = "disabled";
> > +               };
> > +
> > +               uart1: serial@2500400 {
> > +                       compatible = "snps,dw-apb-uart";
> > +                       reg = <0x2500400 0x400>;
> > +                       reg-io-width = <4>;
> > +                       reg-shift = <2>;
> > +                       interrupts = <SOC_PERIPHERAL_IRQ(3)
> > IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&ccu CLK_BUS_UART1>;
> > +                       resets = <&ccu RST_BUS_UART1>;
> > +                       dmas = <&dma 15>, <&dma 15>;
> > +                       dma-names = "rx", "tx";
> > +                       status = "disabled";
> > +               };
> > +
> > +               uart2: serial@2500800 {
> > +                       compatible = "snps,dw-apb-uart";
> > +                       reg = <0x2500800 0x400>;
> > +                       reg-io-width = <4>;
> > +                       reg-shift = <2>;
> > +                       interrupts = <SOC_PERIPHERAL_IRQ(4)
> > IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&ccu CLK_BUS_UART2>;
> > +                       resets = <&ccu RST_BUS_UART2>;
> > +                       dmas = <&dma 16>, <&dma 16>;
> > +                       dma-names = "rx", "tx";
> > +                       status = "disabled";
> > +               };
> > +
> > +               uart3: serial@2500c00 {
> > +                       compatible = "snps,dw-apb-uart";
> > +                       reg = <0x2500c00 0x400>;
> > +                       reg-io-width = <4>;
> > +                       reg-shift = <2>;
> > +                       interrupts = <SOC_PERIPHERAL_IRQ(5)
> > IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&ccu CLK_BUS_UART3>;
> > +                       resets = <&ccu RST_BUS_UART3>;
> > +                       dmas = <&dma 17>, <&dma 17>;
> > +                       dma-names = "rx", "tx";
> > +                       status = "disabled";
> > +               };
> > +
> > +               uart4: serial@2501000 {
> > +                       compatible = "snps,dw-apb-uart";
> > +                       reg = <0x2501000 0x400>;
> > +                       reg-io-width = <4>;
> > +                       reg-shift = <2>;
> > +                       interrupts = <SOC_PERIPHERAL_IRQ(6)
> > IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&ccu CLK_BUS_UART4>;
> > +                       resets = <&ccu RST_BUS_UART4>;
> > +                       dmas = <&dma 18>, <&dma 18>;
> > +                       dma-names = "rx", "tx";
> > +                       status = "disabled";
> > +               };
> > +
> > +               uart5: serial@2501400 {
> > +                       compatible = "snps,dw-apb-uart";
> > +                       reg = <0x2501400 0x400>;
> > +                       reg-io-width = <4>;
> > +                       reg-shift = <2>;
> > +                       interrupts = <SOC_PERIPHERAL_IRQ(7)
> > IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&ccu CLK_BUS_UART5>;
> > +                       resets = <&ccu RST_BUS_UART5>;
> > +                       dmas = <&dma 19>, <&dma 19>;
> > +                       dma-names = "rx", "tx";
> > +                       status = "disabled";
> > +               };
> > +
> > +               i2c0: i2c@2502000 {
> > +                       compatible = "allwinner,sun20i-d1-i2c",
> > +                                    "allwinner,sun8i-v536-i2c",
> > +                                    "allwinner,sun6i-a31-i2c";
> > +                       reg = <0x2502000 0x400>;
> > +                       interrupts = <SOC_PERIPHERAL_IRQ(9)
> > IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&ccu CLK_BUS_I2C0>;
> > +                       resets = <&ccu RST_BUS_I2C0>;
> > +                       dmas = <&dma 43>, <&dma 43>;
> > +                       dma-names = "rx", "tx";
> > +                       status = "disabled";
> > +                       #address-cells = <1>;
> > +                       #size-cells = <0>;
> > +               };
> > +
> > +               i2c1: i2c@2502400 {
> > +                       compatible = "allwinner,sun20i-d1-i2c",
> > +                                    "allwinner,sun8i-v536-i2c",
> > +                                    "allwinner,sun6i-a31-i2c";
> > +                       reg = <0x2502400 0x400>;
> > +                       interrupts = <SOC_PERIPHERAL_IRQ(10)
> > IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&ccu CLK_BUS_I2C1>;
> > +                       resets = <&ccu RST_BUS_I2C1>;
> > +                       dmas = <&dma 44>, <&dma 44>;
> > +                       dma-names = "rx", "tx";
> > +                       status = "disabled";
> > +                       #address-cells = <1>;
> > +                       #size-cells = <0>;
> > +               };
> > +
> > +               i2c2: i2c@2502800 {
> > +                       compatible = "allwinner,sun20i-d1-i2c",
> > +                                    "allwinner,sun8i-v536-i2c",
> > +                                    "allwinner,sun6i-a31-i2c";
> > +                       reg = <0x2502800 0x400>;
> > +                       interrupts = <SOC_PERIPHERAL_IRQ(11)
> > IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&ccu CLK_BUS_I2C2>;
> > +                       resets = <&ccu RST_BUS_I2C2>;
> > +                       dmas = <&dma 45>, <&dma 45>;
> > +                       dma-names = "rx", "tx";
> > +                       status = "disabled";
> > +                       #address-cells = <1>;
> > +                       #size-cells = <0>;
> > +               };
> > +
> > +               i2c3: i2c@2502c00 {
> > +                       compatible = "allwinner,sun20i-d1-i2c",
> > +                                    "allwinner,sun8i-v536-i2c",
> > +                                    "allwinner,sun6i-a31-i2c";
> > +                       reg = <0x2502c00 0x400>;
> > +                       interrupts = <SOC_PERIPHERAL_IRQ(12)
> > IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&ccu CLK_BUS_I2C3>;
> > +                       resets = <&ccu RST_BUS_I2C3>;
> > +                       dmas = <&dma 46>, <&dma 46>;
> > +                       dma-names = "rx", "tx";
> > +                       status = "disabled";
> > +                       #address-cells = <1>;
> > +                       #size-cells = <0>;
> > +               };
> > +
> > +               syscon: syscon@3000000 {
> > +                       compatible = "allwinner,sun20i-d1-system-
> > control";
> > +                       reg = <0x3000000 0x1000>;
> > +                       ranges;
> > +                       #address-cells = <1>;
> > +                       #size-cells = <1>;
> > +
> > +                       regulators@3000150 {
> > +                               compatible = "allwinner,sun20i-d1-
> > system-ldos";
> > +                               reg = <0x3000150 0x4>;
> > +
> > +                               reg_ldoa: ldoa {
> > +                               };
> > +
> > +                               reg_ldob: ldob {
> > +                               };
> > +                       };
> > +               };
> > +
> > +               dma: dma-controller@3002000 {
> > +                       compatible = "allwinner,sun20i-d1-dma";
> > +                       reg = <0x3002000 0x1000>;
> > +                       interrupts = <SOC_PERIPHERAL_IRQ(50)
> > IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&ccu CLK_BUS_DMA>, <&ccu
> > CLK_MBUS_DMA>;
> > +                       clock-names = "bus", "mbus";
> > +                       resets = <&ccu RST_BUS_DMA>;
> > +                       dma-channels = <16>;
> > +                       dma-requests = <48>;
> > +                       #dma-cells = <1>;
> > +               };
> > +
> > +               sid: efuse@3006000 {
> > +                       compatible = "allwinner,sun20i-d1-sid";
> > +                       reg = <0x3006000 0x1000>;
> > +                       #address-cells = <1>;
> > +                       #size-cells = <1>;
> > +               };
> > +
> > +               mbus: dram-controller@3102000 {
> > +                       compatible = "allwinner,sun20i-d1-mbus";
> > +                       reg = <0x3102000 0x1000>,
> > +                             <0x3103000 0x1000>;
> > +                       reg-names = "mbus", "dram";
> > +                       interrupts = <SOC_PERIPHERAL_IRQ(43)
> > IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&ccu CLK_MBUS>,
> > +                                <&ccu CLK_DRAM>,
> > +                                <&ccu CLK_BUS_DRAM>;
> > +                       clock-names = "mbus", "dram", "bus";
> > +                       dma-ranges = <0 0x40000000 0x80000000>;
> > +                       #address-cells = <1>;
> > +                       #size-cells = <1>;
> > +                       #interconnect-cells = <1>;
> > +               };
> > +
> > +               mmc0: mmc@4020000 {
> > +                       compatible = "allwinner,sun20i-d1-mmc";
> > +                       reg = <0x4020000 0x1000>;
> > +                       interrupts = <SOC_PERIPHERAL_IRQ(40)
> > IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&ccu CLK_BUS_MMC0>, <&ccu
> > CLK_MMC0>;
> > +                       clock-names = "ahb", "mmc";
> > +                       resets = <&ccu RST_BUS_MMC0>;
> > +                       reset-names = "ahb";
> > +                       cap-sd-highspeed;
> > +                       max-frequency = <150000000>;
> > +                       no-mmc;
> > +                       status = "disabled";
> > +                       #address-cells = <1>;
> > +                       #size-cells = <0>;
> > +               };
> > +
> > +               mmc1: mmc@4021000 {
> > +                       compatible = "allwinner,sun20i-d1-mmc";
> > +                       reg = <0x4021000 0x1000>;
> > +                       interrupts = <SOC_PERIPHERAL_IRQ(41)
> > IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&ccu CLK_BUS_MMC1>, <&ccu
> > CLK_MMC1>;
> > +                       clock-names = "ahb", "mmc";
> > +                       resets = <&ccu RST_BUS_MMC1>;
> > +                       reset-names = "ahb";
> > +                       cap-sd-highspeed;
> > +                       max-frequency = <150000000>;
> > +                       no-mmc;
> > +                       status = "disabled";
> > +                       #address-cells = <1>;
> > +                       #size-cells = <0>;
> > +               };
> > +
> > +               mmc2: mmc@4022000 {
> > +                       compatible = "allwinner,sun20i-d1-emmc",
> > +                                    "allwinner,sun50i-a100-emmc";
> > +                       reg = <0x4022000 0x1000>;
> > +                       interrupts = <SOC_PERIPHERAL_IRQ(42)
> > IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&ccu CLK_BUS_MMC2>, <&ccu
> > CLK_MMC2>;
> > +                       clock-names = "ahb", "mmc";
> > +                       resets = <&ccu RST_BUS_MMC2>;
> > +                       reset-names = "ahb";
> > +                       cap-mmc-highspeed;
> > +                       max-frequency = <150000000>;
> > +                       mmc-ddr-1_8v;
> > +                       mmc-ddr-3_3v;
> > +                       no-sd;
> > +                       no-sdio;
> > +                       status = "disabled";
> > +                       #address-cells = <1>;
> > +                       #size-cells = <0>;
> > +               };
> > +
> > +               usb_otg: usb@4100000 {
> > +                       compatible = "allwinner,sun20i-d1-musb",
> > +                                    "allwinner,sun8i-a33-musb";
> > +                       reg = <0x4100000 0x400>;
> > +                       interrupts = <SOC_PERIPHERAL_IRQ(29)
> > IRQ_TYPE_LEVEL_HIGH>;
> > +                       interrupt-names = "mc";
> > +                       clocks = <&ccu CLK_BUS_OTG>;
> > +                       resets = <&ccu RST_BUS_OTG>;
> > +                       extcon = <&usbphy 0>;
> > +                       phys = <&usbphy 0>;
> > +                       phy-names = "usb";
> > +                       status = "disabled";
> > +               };
> > +
> > +               usbphy: phy@4100400 {
> > +                       compatible = "allwinner,sun20i-d1-usb-phy";
> > +                       reg = <0x4100400 0x100>,
> > +                             <0x4101800 0x100>,
> > +                             <0x4200800 0x100>;
> > +                       reg-names = "phy_ctrl",
> > +                                   "pmu0",
> > +                                   "pmu1";
> > +                       clocks = <&dcxo>,
> > +                                <&dcxo>;
> > +                       clock-names = "usb0_phy",
> > +                                     "usb1_phy";
> > +                       resets = <&ccu RST_USB_PHY0>,
> > +                                <&ccu RST_USB_PHY1>;
> > +                       reset-names = "usb0_reset",
> > +                                     "usb1_reset";
> > +                       status = "disabled";
> > +                       #phy-cells = <1>;
> > +               };
> > +
> > +               ehci0: usb@4101000 {
> > +                       compatible = "allwinner,sun20i-d1-ehci",
> > +                                    "generic-ehci";
> > +                       reg = <0x4101000 0x100>;
> > +                       interrupts = <SOC_PERIPHERAL_IRQ(30)
> > IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&ccu CLK_BUS_OHCI0>,
> > +                                <&ccu CLK_BUS_EHCI0>,
> > +                                <&ccu CLK_USB_OHCI0>;
> > +                       resets = <&ccu RST_BUS_OHCI0>,
> > +                                <&ccu RST_BUS_EHCI0>;
> > +                       phys = <&usbphy 0>;
> > +                       phy-names = "usb";
> > +                       status = "disabled";
> > +               };
> > +
> > +               ohci0: usb@4101400 {
> > +                       compatible = "allwinner,sun20i-d1-ohci",
> > +                                    "generic-ohci";
> > +                       reg = <0x4101400 0x100>;
> > +                       interrupts = <SOC_PERIPHERAL_IRQ(31)
> > IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&ccu CLK_BUS_OHCI0>,
> > +                                <&ccu CLK_USB_OHCI0>;
> > +                       resets = <&ccu RST_BUS_OHCI0>;
> > +                       phys = <&usbphy 0>;
> > +                       phy-names = "usb";
> > +                       status = "disabled";
> > +               };
> > +
> > +               ehci1: usb@4200000 {
> > +                       compatible = "allwinner,sun20i-d1-ehci",
> > +                                    "generic-ehci";
> > +                       reg = <0x4200000 0x100>;
> > +                       interrupts = <SOC_PERIPHERAL_IRQ(33)
> > IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&ccu CLK_BUS_OHCI1>,
> > +                                <&ccu CLK_BUS_EHCI1>,
> > +                                <&ccu CLK_USB_OHCI1>;
> > +                       resets = <&ccu RST_BUS_OHCI1>,
> > +                                <&ccu RST_BUS_EHCI1>;
> > +                       phys = <&usbphy 1>;
> > +                       phy-names = "usb";
> > +                       status = "disabled";
> > +               };
> > +
> > +               ohci1: usb@4200400 {
> > +                       compatible = "allwinner,sun20i-d1-ohci",
> > +                                    "generic-ohci";
> > +                       reg = <0x4200400 0x100>;
> > +                       interrupts = <SOC_PERIPHERAL_IRQ(34)
> > IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&ccu CLK_BUS_OHCI1>,
> > +                                <&ccu CLK_USB_OHCI1>;
> > +                       resets = <&ccu RST_BUS_OHCI1>;
> > +                       phys = <&usbphy 1>;
> > +                       phy-names = "usb";
> > +                       status = "disabled";
> > +               };
> > +
> > +               emac: ethernet@4500000 {
> > +                       compatible = "allwinner,sun20i-d1-emac",
> > +                                    "allwinner,sun50i-a64-emac";
> > +                       reg = <0x4500000 0x10000>;
> > +                       interrupts = <SOC_PERIPHERAL_IRQ(46)
> > IRQ_TYPE_LEVEL_HIGH>;
> > +                       interrupt-names = "macirq";
> > +                       clocks = <&ccu CLK_BUS_EMAC>;
> > +                       clock-names = "stmmaceth";
> > +                       resets = <&ccu RST_BUS_EMAC>;
> > +                       reset-names = "stmmaceth";
> > +                       syscon = <&syscon>;
> > +                       status = "disabled";
> > +
> > +                       mdio: mdio {
> > +                               compatible = "snps,dwmac-mdio";
> > +                               #address-cells = <1>;
> > +                               #size-cells = <0>;
> > +                       };
> > +               };
> > +
> > +               display_clocks: clock-controller@5000000 {
> 
> The clocks and the two mixers are not children of a bus node anymore,
> IIUC correctly this was to manage the SRAM control. Is that now
> handled
> differently, or does the D1 generation not require this anymore?

I think D1 does not require SRAM control at all, only a few SoCs really
need the SRAM control to be active for DE to work.

> 
> > +                       compatible = "allwinner,sun20i-d1-de2-clk",
> > +                                    "allwinner,sun50i-h5-de2-clk";
> > +                       reg = <0x5000000 0x10000>;
> > +                       clocks = <&ccu CLK_BUS_DE>, <&ccu CLK_DE>;
> > +                       clock-names = "bus", "mod";
> > +                       resets = <&ccu RST_BUS_DE>;
> > +                       #clock-cells = <1>;
> > +                       #reset-cells = <1>;
> > +               };
> > +
> > +               mixer0: mixer@5100000 {
> > +                       compatible = "allwinner,sun20i-d1-de2-
> > mixer-0";
> > +                       reg = <0x5100000 0x100000>;
> > +                       clocks = <&display_clocks CLK_BUS_MIXER0>,
> > +                                <&display_clocks CLK_MIXER0>;
> > +                       clock-names = "bus", "mod";
> > +                       resets = <&display_clocks RST_MIXER0>;
> > +
> > +                       ports {
> > +                               #address-cells = <1>;
> > +                               #size-cells = <0>;
> > +
> > +                               mixer0_out: port@1 {
> > +                                       reg = <1>;
> > +
> > +                                       mixer0_out_tcon_top_mixer0:
> > endpoint {
> > +                                               remote-endpoint =
> > <&tcon_top_mixer0_in_mixer0>;
> > +                                       };
> > +                               };
> > +                       };
> > +               };
> > +
> > +               mixer1: mixer@5200000 {
> > +                       compatible = "allwinner,sun20i-d1-de2-
> > mixer-1";
> > +                       reg = <0x5200000 0x100000>;
> > +                       clocks = <&display_clocks CLK_BUS_MIXER1>,
> > +                                <&display_clocks CLK_MIXER1>;
> > +                       clock-names = "bus", "mod";
> > +                       resets = <&display_clocks RST_MIXER1>;
> > +
> > +                       ports {
> > +                               #address-cells = <1>;
> > +                               #size-cells = <0>;
> > +
> > +                               mixer1_out: port@1 {
> > +                                       reg = <1>;
> > +
> > +                                       mixer1_out_tcon_top_mixer1:
> > endpoint {
> > +                                               remote-endpoint =
> > <&tcon_top_mixer1_in_mixer1>;
> > +                                       };
> > +                               };
> > +                       };
> > +               };
> > +
> > +               dsi: dsi@5450000 {
> > +                       compatible = "allwinner,sun20i-d1-mipi-
> > dsi",
> > +                                    "allwinner,sun50i-a100-mipi-
> > dsi";
> > +                       reg = <0x5450000 0x1000>;
> > +                       interrupts = <SOC_PERIPHERAL_IRQ(92)
> > IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&ccu CLK_BUS_MIPI_DSI>,
> > +                                <&tcon_top CLK_TCON_TOP_DSI>;
> > +                       clock-names = "bus", "mod";
> > +                       resets = <&ccu RST_BUS_MIPI_DSI>;
> > +                       phys = <&dphy>;
> > +                       phy-names = "dphy";
> > +                       status = "disabled";
> > +                       #address-cells = <1>;
> > +                       #size-cells = <0>;
> > +
> > +                       port {
> > +                               dsi_in_tcon_lcd0: endpoint {
> > +                                       remote-endpoint =
> > <&tcon_lcd0_out_dsi>;
> > +                               };
> > +                       };
> > +               };
> > +
> > +               dphy: phy@5451000 {
> > +                       compatible = "allwinner,sun20i-d1-mipi-
> > dphy",
> > +                                    "allwinner,sun50i-a100-mipi-
> > dphy";
> > +                       reg = <0x5451000 0x1000>;
> > +                       interrupts = <SOC_PERIPHERAL_IRQ(92)
> > IRQ_TYPE_LEVEL_HIGH>;
> 
> This is the same interrupt number as for the DSI controller above. Is
> that correct, and can the drivers handle that?

I think this should be correct, and only one driver acquires IRQ now.

> 
> Cheers,
> Andre
> 
> 
> > +                       clocks = <&ccu CLK_BUS_MIPI_DSI>,
> > +                                <&ccu CLK_MIPI_DSI>;
> > +                       clock-names = "bus", "mod";
> > +                       resets = <&ccu RST_BUS_MIPI_DSI>;
> > +                       #phy-cells = <0>;
> > +               };
> > +
> > +               tcon_top: tcon-top@5460000 {
> > +                       compatible = "allwinner,sun20i-d1-tcon-
> > top";
> > +                       reg = <0x5460000 0x1000>;
> > +                       clocks = <&ccu CLK_BUS_DPSS_TOP>,
> > +                                <&ccu CLK_TCON_TV>,
> > +                                <&ccu CLK_TVE>,
> > +                                <&ccu CLK_TCON_LCD0>;
> > +                       clock-names = "bus", "tcon-tv0", "tve0",
> > "dsi";
> > +                       clock-output-names = "tcon-top-tv0", "tcon-
> > top-dsi";
> > +                       resets = <&ccu RST_BUS_DPSS_TOP>;
> > +                       #clock-cells = <1>;
> > +
> > +                       ports {
> > +                               #address-cells = <1>;
> > +                               #size-cells = <0>;
> > +
> > +                               tcon_top_mixer0_in: port@0 {
> > +                                       reg = <0>;
> > +                                       #address-cells = <1>;
> > +                                       #size-cells = <0>;
> > +
> > +                                       tcon_top_mixer0_in_mixer0:
> > endpoint@0 {
> > +                                               reg = <0>;
> > +                                               remote-endpoint =
> > <&mixer0_out_tcon_top_mixer0>;
> > +                                       };
> > +                               };
> > +
> > +                               tcon_top_mixer0_out: port@1 {
> > +                                       reg = <1>;
> > +                                       #address-cells = <1>;
> > +                                       #size-cells = <0>;
> > +
> > +                                       tcon_top_mixer0_out_tcon_lc
> > d0: endpoint@0 {
> > +                                               reg = <0>;
> > +                                               remote-endpoint =
> > <&tcon_lcd0_in_tcon_top_mixer0>;
> > +                                       };
> > +
> > +                                       tcon_top_mixer0_out_tcon_tv
> > 0: endpoint@2 {
> > +                                               reg = <2>;
> > +                                               remote-endpoint =
> > <&tcon_tv0_in_tcon_top_mixer0>;
> > +                                       };
> > +                               };
> > +
> > +                               tcon_top_mixer1_in: port@2 {
> > +                                       reg = <2>;
> > +                                       #address-cells = <1>;
> > +                                       #size-cells = <0>;
> > +
> > +                                       tcon_top_mixer1_in_mixer1:
> > endpoint@1 {
> > +                                               reg = <1>;
> > +                                               remote-endpoint =
> > <&mixer1_out_tcon_top_mixer1>;
> > +                                       };
> > +                               };
> > +
> > +                               tcon_top_mixer1_out: port@3 {
> > +                                       reg = <3>;
> > +                                       #address-cells = <1>;
> > +                                       #size-cells = <0>;
> > +
> > +                                       tcon_top_mixer1_out_tcon_lc
> > d0: endpoint@0 {
> > +                                               reg = <0>;
> > +                                               remote-endpoint =
> > <&tcon_lcd0_in_tcon_top_mixer1>;
> > +                                       };
> > +
> > +                                       tcon_top_mixer1_out_tcon_tv
> > 0: endpoint@2 {
> > +                                               reg = <2>;
> > +                                               remote-endpoint =
> > <&tcon_tv0_in_tcon_top_mixer1>;
> > +                                       };
> > +                               };
> > +
> > +                               tcon_top_hdmi_in: port@4 {
> > +                                       reg = <4>;
> > +
> > +                                       tcon_top_hdmi_in_tcon_tv0:
> > endpoint {
> > +                                               remote-endpoint =
> > <&tcon_tv0_out_tcon_top_hdmi>;
> > +                                       };
> > +                               };
> > +
> > +                               tcon_top_hdmi_out: port@5 {
> > +                                       reg = <5>;
> > +                               };
> > +                       };
> > +               };
> > +
> > +               tcon_lcd0: lcd-controller@5461000 {
> > +                       compatible = "allwinner,sun20i-d1-tcon-
> > lcd";
> > +                       reg = <0x5461000 0x1000>;
> > +                       interrupts = <SOC_PERIPHERAL_IRQ(90)
> > IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&ccu CLK_BUS_TCON_LCD0>,
> > +                                <&ccu CLK_TCON_LCD0>;
> > +                       clock-names = "ahb", "tcon-ch0";
> > +                       clock-output-names = "tcon-pixel-clock";
> > +                       resets = <&ccu RST_BUS_TCON_LCD0>,
> > +                                <&ccu RST_BUS_LVDS0>;
> > +                       reset-names = "lcd", "lvds";
> > +                       #clock-cells = <0>;
> > +
> > +                       ports {
> > +                               #address-cells = <1>;
> > +                               #size-cells = <0>;
> > +
> > +                               tcon_lcd0_in: port@0 {
> > +                                       reg = <0>;
> > +                                       #address-cells = <1>;
> > +                                       #size-cells = <0>;
> > +
> > +                                       tcon_lcd0_in_tcon_top_mixer
> > 0: endpoint@0 {
> > +                                               reg = <0>;
> > +                                               remote-endpoint =
> > <&tcon_top_mixer0_out_tcon_lcd0>;
> > +                                       };
> > +
> > +                                       tcon_lcd0_in_tcon_top_mixer
> > 1: endpoint@1 {
> > +                                               reg = <1>;
> > +                                               remote-endpoint =
> > <&tcon_top_mixer1_out_tcon_lcd0>;
> > +                                       };
> > +                               };
> > +
> > +                               tcon_lcd0_out: port@1 {
> > +                                       reg = <1>;
> > +                                       #address-cells = <1>;
> > +                                       #size-cells = <0>;
> > +
> > +                                       tcon_lcd0_out_dsi:
> > endpoint@1 {
> > +                                               reg = <1>;
> > +                                               remote-endpoint =
> > <&dsi_in_tcon_lcd0>;
> > +                                       };
> > +                               };
> > +                       };
> > +               };
> > +
> > +               tcon_tv0: lcd-controller@5470000 {
> > +                       compatible = "allwinner,sun20i-d1-tcon-tv";
> > +                       reg = <0x5470000 0x1000>;
> > +                       interrupts = <SOC_PERIPHERAL_IRQ(91)
> > IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&ccu CLK_BUS_TCON_TV>,
> > +                                <&tcon_top CLK_TCON_TOP_TV0>;
> > +                       clock-names = "ahb", "tcon-ch1";
> > +                       resets = <&ccu RST_BUS_TCON_TV>;
> > +                       reset-names = "lcd";
> > +
> > +                       ports {
> > +                               #address-cells = <1>;
> > +                               #size-cells = <0>;
> > +
> > +                               tcon_tv0_in: port@0 {
> > +                                       reg = <0>;
> > +                                       #address-cells = <1>;
> > +                                       #size-cells = <0>;
> > +
> > +                                       tcon_tv0_in_tcon_top_mixer0
> > : endpoint@0 {
> > +                                               reg = <0>;
> > +                                               remote-endpoint =
> > <&tcon_top_mixer0_out_tcon_tv0>;
> > +                                       };
> > +
> > +                                       tcon_tv0_in_tcon_top_mixer1
> > : endpoint@1 {
> > +                                               reg = <1>;
> > +                                               remote-endpoint =
> > <&tcon_top_mixer1_out_tcon_tv0>;
> > +                                       };
> > +                               };
> > +
> > +                               tcon_tv0_out: port@1 {
> > +                                       reg = <1>;
> > +
> > +                                       tcon_tv0_out_tcon_top_hdmi:
> > endpoint {
> > +                                               remote-endpoint =
> > <&tcon_top_hdmi_in_tcon_tv0>;
> > +                                       };
> > +                               };
> > +                       };
> > +               };
> > +
> > +               r_ccu: clock-controller@7010000 {
> > +                       compatible = "allwinner,sun20i-d1-r-ccu";
> > +                       reg = <0x7010000 0x400>;
> > +                       clocks = <&dcxo>,
> > +                                <&rtc CLK_OSC32K>,
> > +                                <&rtc CLK_IOSC>,
> > +                                <&ccu CLK_PLL_PERIPH0_DIV3>;
> > +                       clock-names = "hosc", "losc", "iosc", "pll-
> > periph";
> > +                       #clock-cells = <1>;
> > +                       #reset-cells = <1>;
> > +               };
> > +
> > +               rtc: rtc@7090000 {
> > +                       compatible = "allwinner,sun20i-d1-rtc",
> > +                                    "allwinner,sun50i-r329-rtc";
> > +                       reg = <0x7090000 0x400>;
> > +                       interrupts = <SOC_PERIPHERAL_IRQ(144)
> > IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&r_ccu CLK_BUS_R_RTC>,
> > +                                <&dcxo>,
> > +                                <&r_ccu CLK_R_AHB>;
> > +                       clock-names = "bus", "hosc", "ahb";
> > +                       #clock-cells = <1>;
> > +               };
> > +       };
> > +};
> 
> 