RE: [PATCH v5 1/5] mfd: da9062: make register CONFIG_I writable

From: Christoph Niedermaier <cniedermaier@dh-electronics.com>
To: Guenter Roeck <linux@roeck-us.net>,
	"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>
Cc: "wim@linux-watchdog.org" <wim@linux-watchdog.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	"linux-imx@nxp.com" <linux-imx@nxp.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
	Andrej Picej <andrej.picej@norik.com>,
	 Support Opensource <Support.Opensource@diasemi.com>
Subject: RE: [PATCH v5 1/5] mfd: da9062: make register CONFIG_I writable
Date: Mon, 11 Apr 2022 09:06:46 +0000	[thread overview]
Message-ID: <3e49d99036cf4b5793d52891683b867f@dh-electronics.com> (raw)
In-Reply-To: <83fad886-541c-987c-1f38-7029aca41892@roeck-us.net>

From: Guenter Roeck [mailto:groeck7@gmail.com] On Behalf Of Guenter Roeck
Sent: Monday, December 6, 2021 6:12 PM
> On 12/6/21 8:46 AM, Adam Thomson wrote:
>> On 06 December 2021 06:47, Andrej Picej wrote:
>>
>>> From: Stefan Christ <s.christ@phytec.de>
>>>
>>> Make the config register CONFIG_I writable to change the watchdog mode.
>>>
>>> Signed-off-by: Stefan Christ <s.christ@phytec.de>
>>> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
>>
>> I've already provided 'Reviewed-by' tags for the other patches in this set. In
>> the future you can add any received tags on to patch re-submissions where
>> nothing has changed since last review.
>>
>> Anyway, thanks for the work on this, and for the patch set:
>>
>> Reviewed-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
>>
> 
> In this context:
> 
> I expect that tags are present in patchwork. If a submitter drops tags
> in a new revision of a patch series, those will get lost. The underlying
> assumption is that the submitter had a reason to drop tags, such as
> substantial changes in an affected patch. I can not assume that the
> submitter dropped a tag accidentally and re-apply it, unless the reason
> was explicitly provided (obviously that is typically not the case since
> people don't usually add "accidentally dropped Reviewed-by: tags" to
> change logs).
> 
> Also, I do not look into one patch of a series and apply tags to other
> patches of that series. Similar reason, only here it is worse because Wim
> may pull a patch from patchwork, from an e-mail, or from my watchdog-next
> branch. We can't have all of them have different tags, so I take what is
> in patchwork and nothing else (and your updated Reviewed-by: tag will
> not apply to other patches of the series because it isn't in patchwork
> for those).
> 
> I also see that my own Reviewed-by: tag (or tags, I didn't check all
> of them) was/were dropped in v5 of this series. That means I'll have to
> re-review the series to see what changed, which will take time and means
> that the series will end up at the bottom of my review queue.
> Please keep that in mind when dropping tags.

Hi Guenter,

Is there anything against applying the first 4 patches of this series?

Thanks and regards
Christoph
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel