Re: [PATCH -next 1/4] spi: mockup: Add SPI controller testing driver

From: "weiyongjun (A)" <weiyongjun1@huawei.com>
To: Mark Brown <broonie@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Ingo Molnar <mingo@redhat.com>, <linux-kernel@vger.kernel.org>,
	<linux-spi@vger.kernel.org>
Subject: Re: [PATCH -next 1/4] spi: mockup: Add SPI controller testing driver
Date: Wed, 31 Aug 2022 12:39:37 +0800	[thread overview]
Message-ID: <3ec5a47c-ec72-328c-cc69-bb84190f3c1e@huawei.com> (raw)
In-Reply-To: <Yw5g8zalllhRxd9Z@sirena.org.uk>

On 2022/8/31 3:11, Mark Brown wrote:
> On Fri, Aug 26, 2022 at 02:43:38PM +0000, Wei Yongjun wrote:
> 
>> @@ -0,0 +1,221 @@
>> +// SPDX-License-Identifier: GPL-2.0-or-later
>> +/*
>> + * SPI controller Testing Driver
>> + *
>> + * Copyright(c) 2022 Huawei Technologies Co., Ltd.
>> + */
> 
> Please make the entire comment a C++ one so things look more
> intentional.
> 
>> +	master = spi_alloc_master(&pdev->dev, sizeof(struct mockup_spi));
>> +	if (!master) {
>> +		pr_err("failed to alloc spi master\n");
>> +		return -ENOMEM;
>> +	}
> 
> Please use the new _controller() API, we're trying to remove the
> use of outdated terminology.
> 

Will fix them in next version.

Thanks,
Wei Yongjun