From: Mark Brown <broonie@kernel.org>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH -next 2/4] spi: mockup: Add writeable tracepoint for spi transfer
Date: Tue, 30 Aug 2022 19:14:03 +0100 [thread overview]
Message-ID: <Yw5Ta8sO3fMsPLDY@sirena.org.uk> (raw)
In-Reply-To: <20220826144341.532265-3-weiyongjun1@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 685 bytes --]
On Fri, Aug 26, 2022 at 02:43:39PM +0000, Wei Yongjun wrote:
> +#define SPI_BUFSIZ_MAX 0x1000
> +
> +struct spi_msg_ctx {
> + int ret;
> + __u8 data[SPI_BUFSIZ_MAX];
> +};
This has a hard limit on the size of messages of only 4k on the
size of messages, that seems a bit on the low side especially
considering that the example is for a flash device. There's also
things like firmware downloads which can easily exceed 4k. The
driver should at the very least report this limit via the SPI
API, and probably also complain loudly if the limit is exceeded
since it's unlikely that most drivers will actually be checking
for such a low limit given how rare they are.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-08-30 18:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 14:43 [PATCH -next 0/4] spi: Introduce BPF based SPI mockup controller Wei Yongjun
2022-08-26 14:43 ` [PATCH -next 1/4] spi: mockup: Add SPI controller testing driver Wei Yongjun
2022-08-30 19:11 ` Mark Brown
2022-08-31 4:39 ` weiyongjun (A)
2022-08-26 14:43 ` [PATCH -next 2/4] spi: mockup: Add writeable tracepoint for spi transfer Wei Yongjun
2022-08-30 18:14 ` Mark Brown [this message]
2022-08-31 4:43 ` weiyongjun (A)
2022-08-26 14:43 ` [PATCH -next 3/4] spi: mockup: Add runtime device tree overlay interface Wei Yongjun
2022-08-29 21:29 ` Frank Rowand
2022-08-30 3:05 ` weiyongjun (A)
2022-08-30 10:27 ` Mark Brown
2022-08-30 19:24 ` Frank Rowand
2022-08-31 4:44 ` weiyongjun (A)
2022-08-26 14:43 ` [PATCH -next 4/4] spi: mockup: Add documentation Wei Yongjun
2022-08-30 18:21 ` Mark Brown
2022-08-30 19:08 ` [PATCH -next 0/4] spi: Introduce BPF based SPI mockup controller Mark Brown
2022-09-01 10:38 ` Mark Brown
2022-09-01 12:23 ` weiyongjun (A)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yw5Ta8sO3fMsPLDY@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.