All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] pwm: rcar: drop of_match_ptr for ID table
Date: Sun, 12 Mar 2023 14:47:38 +0100	[thread overview]
Message-ID: <3fefcfd9-5783-3f83-da30-c14196958c0b@linaro.org> (raw)
In-Reply-To: <20230312134647.kmjcbilb3puumcu6@pengutronix.de>

On 12/03/2023 14:46, Uwe Kleine-König wrote:
> On Sat, Mar 11, 2023 at 06:37:34PM +0100, Krzysztof Kozlowski wrote:
>> The driver can match only via the DT table so the table should be always
>> used and the of_match_ptr does not have any sense (this also allows ACPI
>> matching via PRP0001, even though it might not be relevant here).
>>
>>   drivers/pwm/pwm-rcar.c:252:34: error: ‘rcar_pwm_of_table’ defined but not used [-Werror=unused-const-variable=]
> 
> The commit log text sounds like a harmless optimisation, but the error
> message here either means you're fixing a compile failure, or (and?) the
> patch was sent out before the commit log was finalized.
> 
> Looking at it this is the error message that triggers if you compile
> this driver with OF unset. I'd like to have that mentioned, then the
> patch looks fine. Ditto for the 2nd patch in this series.

Sure, ack!

Best regards,
Krzysztof


WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] pwm: rcar: drop of_match_ptr for ID table
Date: Sun, 12 Mar 2023 14:47:38 +0100	[thread overview]
Message-ID: <3fefcfd9-5783-3f83-da30-c14196958c0b@linaro.org> (raw)
In-Reply-To: <20230312134647.kmjcbilb3puumcu6@pengutronix.de>

On 12/03/2023 14:46, Uwe Kleine-König wrote:
> On Sat, Mar 11, 2023 at 06:37:34PM +0100, Krzysztof Kozlowski wrote:
>> The driver can match only via the DT table so the table should be always
>> used and the of_match_ptr does not have any sense (this also allows ACPI
>> matching via PRP0001, even though it might not be relevant here).
>>
>>   drivers/pwm/pwm-rcar.c:252:34: error: ‘rcar_pwm_of_table’ defined but not used [-Werror=unused-const-variable=]
> 
> The commit log text sounds like a harmless optimisation, but the error
> message here either means you're fixing a compile failure, or (and?) the
> patch was sent out before the commit log was finalized.
> 
> Looking at it this is the error message that triggers if you compile
> this driver with OF unset. I'd like to have that mentioned, then the
> patch looks fine. Ditto for the 2nd patch in this series.

Sure, ack!

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-03-12 13:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-11 17:37 [PATCH 1/2] pwm: rcar: drop of_match_ptr for ID table Krzysztof Kozlowski
2023-03-11 17:37 ` Krzysztof Kozlowski
2023-03-11 17:37 ` [PATCH 2/2] pwm: stm32-lp: " Krzysztof Kozlowski
2023-03-11 17:37   ` Krzysztof Kozlowski
2023-03-12 13:46 ` [PATCH 1/2] pwm: rcar: " Uwe Kleine-König
2023-03-12 13:46   ` Uwe Kleine-König
2023-03-12 13:47   ` Krzysztof Kozlowski [this message]
2023-03-12 13:47     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3fefcfd9-5783-3f83-da30-c14196958c0b@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=alexandre.torgue@foss.st.com \
    --cc=fabrice.gasnier@foss.st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=thierry.reding@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.