From: "Péter Ujfalusi" <peter.ujfalusi@ti.com>
To: "Balbi, Felipe" <balbi@ti.com>
Cc: "Girdwood, Liam" <lrg@ti.com>, Tony Lindgren <tony@atomide.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"Lopez Cruz, Misael" <misael.lopez@ti.com>
Subject: Re: Re: [PATCH v6 08/18] mfd: twl6040: Add initial support
Date: Mon, 4 Jul 2011 16:09:30 +0300 [thread overview]
Message-ID: <4014234.U3Af1Vqyz9@barack> (raw)
In-Reply-To: <20110704125330.GI2820@legolas.emea.dhcp.ti.com>
Hi Felipe, Samuel,
On Monday 04 July 2011 14:53:30 Balbi, Felipe wrote:
> > + ret = twl6040_request_irq(twl6040, TWL6040_IRQ_READY,
> > + twl6040_naudint_handler, 0,
> > + "twl6040_irq_ready", twl6040);
>
> why don't you use the normal request_threaded_irq() ?? This is a bit of
> obfuscation IMO.
I have left this 'macro' in since it is also used within the twl6040-vibra,
and twl6040 ASoC codec driver to request the irq for them.
But if you think it is better to replace the twl6040_request_irq with direct
request_threaded_irq in those drivers as well, I'll do that.
--
Péter
WARNING: multiple messages have this Message-ID (diff)
From: "Péter Ujfalusi" <peter.ujfalusi@ti.com>
To: "Balbi, Felipe" <balbi@ti.com>
Cc: "Girdwood, Liam" <lrg@ti.com>, Tony Lindgren <tony@atomide.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"Lopez Cruz, Misael" <misael.lopez@ti.com>
Subject: Re: Re: [PATCH v6 08/18] mfd: twl6040: Add initial support
Date: Mon, 4 Jul 2011 16:09:30 +0300 [thread overview]
Message-ID: <4014234.U3Af1Vqyz9@barack> (raw)
In-Reply-To: <20110704125330.GI2820@legolas.emea.dhcp.ti.com>
Hi Felipe, Samuel,
On Monday 04 July 2011 14:53:30 Balbi, Felipe wrote:
> > + ret = twl6040_request_irq(twl6040, TWL6040_IRQ_READY,
> > + twl6040_naudint_handler, 0,
> > + "twl6040_irq_ready", twl6040);
>
> why don't you use the normal request_threaded_irq() ?? This is a bit of
> obfuscation IMO.
I have left this 'macro' in since it is also used within the twl6040-vibra,
and twl6040 ASoC codec driver to request the irq for them.
But if you think it is better to replace the twl6040_request_irq with direct
request_threaded_irq in those drivers as well, I'll do that.
--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-07-04 13:09 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-21 13:38 [PATCH v6 00/18] MFD/ASoC/Input: TWL4030/TWL60X0 changes Peter Ujfalusi
2011-06-21 13:38 ` Peter Ujfalusi
2011-06-21 13:38 ` [PATCH v6 01/18] OMAP: New twl-common for common TWL configuration Peter Ujfalusi
2011-06-21 13:38 ` Peter Ujfalusi
2011-06-21 13:39 ` [PATCH v6 02/18] OMAP4: Move common twl6030 configuration to twl-common Peter Ujfalusi
2011-06-21 13:39 ` Peter Ujfalusi
2011-06-21 13:39 ` [PATCH v6 03/18] OMAP3: Move common twl " Peter Ujfalusi
2011-06-21 13:39 ` Peter Ujfalusi
2011-06-21 13:39 ` [PATCH v6 04/18] OMAP3: Move common regulator " Peter Ujfalusi
2011-06-21 13:39 ` Peter Ujfalusi
2011-06-21 13:39 ` [PATCH v6 05/18] MFD: twl4030-codec: Rename internals from codec to audio Peter Ujfalusi
2011-06-21 13:39 ` Peter Ujfalusi
2011-06-21 13:39 ` [PATCH v6 06/18] MFD: twl4030-codec -> twl4030-audio: Rename the driver Peter Ujfalusi
2011-06-21 13:39 ` Peter Ujfalusi
2011-06-21 13:39 ` [PATCH v6 07/18] MFD: twl4030-audio: Rename platform data Peter Ujfalusi
2011-06-21 13:39 ` Peter Ujfalusi
2011-06-21 13:39 ` [PATCH v6 08/18] mfd: twl6040: Add initial support Peter Ujfalusi
2011-06-21 13:39 ` Peter Ujfalusi
2011-07-04 11:48 ` Samuel Ortiz
2011-07-04 13:11 ` Péter Ujfalusi
2011-07-04 13:11 ` Péter Ujfalusi
2011-07-04 14:08 ` Péter Ujfalusi
2011-07-04 14:08 ` Péter Ujfalusi
2011-07-04 17:39 ` Samuel Ortiz
2011-07-04 17:39 ` Samuel Ortiz
2011-07-05 9:28 ` Péter Ujfalusi
2011-07-05 9:28 ` Péter Ujfalusi
2011-07-04 12:53 ` Felipe Balbi
2011-07-04 13:09 ` Péter Ujfalusi [this message]
2011-07-04 13:09 ` Péter Ujfalusi
2011-07-04 13:27 ` Felipe Balbi
2011-06-21 13:39 ` [PATCH v6 09/18] ASoC: twl6040: Convert into TWL6040 MFD child Peter Ujfalusi
2011-06-21 13:39 ` Peter Ujfalusi
2011-06-21 13:39 ` [PATCH v6 10/18] MFD: twl6040: Change platform data for soc codec driver Peter Ujfalusi
2011-06-21 13:39 ` Peter Ujfalusi
2011-06-21 13:39 ` [PATCH v6 11/18] input: Add initial support for TWL6040 vibrator Peter Ujfalusi
2011-06-21 13:39 ` Peter Ujfalusi
2011-06-21 20:32 ` Dmitry Torokhov
2011-06-22 11:37 ` Péter Ujfalusi
2011-06-22 11:37 ` Péter Ujfalusi
2011-06-21 13:39 ` [PATCH v6 12/18] OMAP4: SDP4430: Add twl6040 vibrator platform support Peter Ujfalusi
2011-06-21 13:39 ` Peter Ujfalusi
2011-06-21 13:39 ` [PATCH v6 13/18] ASoC: twl6040: add all ABE DAIs Peter Ujfalusi
2011-06-21 13:39 ` Peter Ujfalusi
2011-06-21 13:39 ` [PATCH v6 14/18] ASoC: twl6040: Support other sample rates in constraints Peter Ujfalusi
2011-06-21 13:39 ` Peter Ujfalusi
2011-06-21 13:39 ` [PATCH v6 15/18] ASoC: twl6040: Remove pll and headset mode dependency Peter Ujfalusi
2011-06-21 13:39 ` Peter Ujfalusi
2011-06-21 17:35 ` Mark Brown
2011-06-22 11:39 ` Péter Ujfalusi
2011-06-22 11:39 ` Péter Ujfalusi
2011-06-21 13:39 ` [PATCH v6 16/18] ASoC: twl6040: set default constraints Peter Ujfalusi
2011-06-21 13:39 ` Peter Ujfalusi
2011-06-21 13:39 ` [PATCH v6 17/18] ASoC: twl6040: Configure ramp step based on platform Peter Ujfalusi
2011-06-21 13:39 ` Peter Ujfalusi
2011-06-22 11:25 ` [PATCH v6 18/18] OMAP4: SDP4430: Add twl6040 codec platform support Peter Ujfalusi
2011-06-22 11:25 ` Peter Ujfalusi
2011-06-27 9:43 ` [PATCH v6 00/18] MFD/ASoC/Input: TWL4030/TWL60X0 changes Péter Ujfalusi
2011-06-27 9:43 ` Péter Ujfalusi
2011-06-27 10:18 ` Tony Lindgren
2011-06-27 10:18 ` Tony Lindgren
2011-06-27 14:30 ` Péter Ujfalusi
2011-06-27 14:30 ` Péter Ujfalusi
2011-06-28 6:17 ` Tony Lindgren
2011-06-28 6:17 ` Tony Lindgren
2011-06-28 6:44 ` Re: " Péter Ujfalusi
2011-06-28 6:44 ` Péter Ujfalusi
2011-06-28 6:50 ` Re: " Tony Lindgren
2011-06-28 6:50 ` Tony Lindgren
2011-07-04 11:51 ` Samuel Ortiz
2011-07-04 11:51 ` Samuel Ortiz
2011-06-30 6:15 ` Re: [alsa-devel] " Péter Ujfalusi
2011-06-30 6:15 ` Péter Ujfalusi
2011-06-30 8:04 ` Re: [alsa-devel] " Samuel Ortiz
2011-06-30 8:04 ` Samuel Ortiz
2011-06-30 9:41 ` Péter Ujfalusi
2011-06-30 9:41 ` Péter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4014234.U3Af1Vqyz9@barack \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=balbi@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=misael.lopez@ti.com \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.