From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>, dianders@chromium.org
Cc: robdclark@gmail.com, quic_abhinavk@quicinc.com, sean@poorly.run,
airlied@gmail.com, daniel@ffwll.ch,
marijn.suijten@somainline.org, vkoul@kernel.org, marex@denx.de,
vladimir.lypak@gmail.com, linux-arm-msm@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drm/msm/dsi: Drop the redundant fail label
Date: Wed, 18 Jan 2023 03:32:05 +0200 [thread overview]
Message-ID: <40261e85-f501-7326-76b0-b19ca3aceae9@linaro.org> (raw)
In-Reply-To: <20230111011006.6238-1-jiasheng@iscas.ac.cn>
On 11/01/2023 03:10, Jiasheng Jiang wrote:
> Drop the redundant fail label and change the "goto fail" into "return ret"
> since they are the same.
>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> Changelog:
>
> v1 -> v2:
>
> 1. No change of the error handling of the irq_of_parse_and_map.
> ---
> drivers/gpu/drm/msm/dsi/dsi_host.c | 24 ++++++++----------------
> 1 file changed, 8 insertions(+), 16 deletions(-)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>, dianders@chromium.org
Cc: marex@denx.de, vkoul@kernel.org, sean@poorly.run,
vladimir.lypak@gmail.com, quic_abhinavk@quicinc.com,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, marijn.suijten@somainline.org,
freedreno@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/msm/dsi: Drop the redundant fail label
Date: Wed, 18 Jan 2023 03:32:05 +0200 [thread overview]
Message-ID: <40261e85-f501-7326-76b0-b19ca3aceae9@linaro.org> (raw)
In-Reply-To: <20230111011006.6238-1-jiasheng@iscas.ac.cn>
On 11/01/2023 03:10, Jiasheng Jiang wrote:
> Drop the redundant fail label and change the "goto fail" into "return ret"
> since they are the same.
>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> Changelog:
>
> v1 -> v2:
>
> 1. No change of the error handling of the irq_of_parse_and_map.
> ---
> drivers/gpu/drm/msm/dsi/dsi_host.c | 24 ++++++++----------------
> 1 file changed, 8 insertions(+), 16 deletions(-)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
next prev parent reply other threads:[~2023-01-18 1:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 1:10 [PATCH v2] drm/msm/dsi: Drop the redundant fail label Jiasheng Jiang
2023-01-11 1:10 ` Jiasheng Jiang
2023-01-18 1:32 ` Dmitry Baryshkov [this message]
2023-01-18 1:32 ` Dmitry Baryshkov
2023-01-18 2:06 ` Dmitry Baryshkov
2023-01-18 2:06 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40261e85-f501-7326-76b0-b19ca3aceae9@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jiasheng@iscas.ac.cn \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=marijn.suijten@somainline.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=vkoul@kernel.org \
--cc=vladimir.lypak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.