From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Caesar Wang <caesar.wang@rock-chips.com>
Cc: heiko@sntech.de, rui.zhang@intel.com, edubezval@gmail.com,
zyf@rock-chips.com, dianders@chromium.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
cf@rock-chips.com, dbasehore@chromium.org,
huangtao@rock-chips.com, cjf@rock-chips.com,
zhengsq@rock-chips.com
Subject: Re: [PATCH v14 2/5] dt-bindings: document Rockchip thermal
Date: Mon, 27 Oct 2014 17:37:38 -0700 [thread overview]
Message-ID: <4038023.8IINY8khj6@dtor-glaptop> (raw)
In-Reply-To: <544EE42D.3030208@rock-chips.com>
On Tuesday, October 28, 2014 08:32:45 AM Caesar Wang wrote:
> Dmitry,
>
> 在 2014年10月28日 08:29, Dmitry Torokhov 写道:
> > On Mon, Oct 27, 2014 at 10:39:45AM +0800, Caesar Wang wrote:
> >> This add the necessary binding documentation for the thermal
> >> found on Rockchip SoCs
> >>
> >> Signed-off-by: zhaoyifeng <zyf@rock-chips.com>
> >> Signed-off-by: Caesar Wang <caesar.wang@rock-chips.com>
> >> ---
> >>
> >> .../bindings/thermal/rockchip-thermal.txt | 53
> >> ++++++++++++++++++++++ 1 file changed, 53 insertions(+)
> >> create mode 100644
> >> Documentation/devicetree/bindings/thermal/rockchip-thermal.txt>>
> >> diff --git
> >> a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
> >> b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt new
> >> file mode 100644
> >> index 0000000..d5b1401
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
> >> @@ -0,0 +1,53 @@
> >> +* Temperature Sensor ADC (TSADC) on rockchip SoCs
> >> +
> >> +Required properties:
> >> +- compatible : "rockchip,rk3288-tsadc"
> >> +- reg : physical base address of the controller and length of memory
> >> mapped + region.
> >> +- interrupts : The interrupt number to the cpu. The interrupt specifier
> >> format + depends on the interrupt controller.
> >> +- clocks : Must contain an entry for each entry in clock-names.
> >> +- clock-names : Shall be "tsadc" for the converter-clock, and "apb_pclk"
> >> for + the peripheral clock.
> >> +- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a
> >> description.>
> > I think you are missing description of hw-shut-temp, tsadc-tshut-mode
> > and tsadc-tshut-mode
> >
> > and optional pinctrl settings.
>
> If it's really need,we just have hw-shut-temp,tsadc-tshut-mode
> and tsadc-tshut-mode,no need pinctrl setting,I think.
This is more question to DeviceTree guys, but I can see us not documenting
pinctrl since it is generic property used by every driver out there. We should
definitely document driver-specific properties.
Thanks.
--
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: dmitry.torokhov@gmail.com (Dmitry Torokhov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v14 2/5] dt-bindings: document Rockchip thermal
Date: Mon, 27 Oct 2014 17:37:38 -0700 [thread overview]
Message-ID: <4038023.8IINY8khj6@dtor-glaptop> (raw)
In-Reply-To: <544EE42D.3030208@rock-chips.com>
On Tuesday, October 28, 2014 08:32:45 AM Caesar Wang wrote:
> Dmitry,
>
> ? 2014?10?28? 08:29, Dmitry Torokhov ??:
> > On Mon, Oct 27, 2014 at 10:39:45AM +0800, Caesar Wang wrote:
> >> This add the necessary binding documentation for the thermal
> >> found on Rockchip SoCs
> >>
> >> Signed-off-by: zhaoyifeng <zyf@rock-chips.com>
> >> Signed-off-by: Caesar Wang <caesar.wang@rock-chips.com>
> >> ---
> >>
> >> .../bindings/thermal/rockchip-thermal.txt | 53
> >> ++++++++++++++++++++++ 1 file changed, 53 insertions(+)
> >> create mode 100644
> >> Documentation/devicetree/bindings/thermal/rockchip-thermal.txt>>
> >> diff --git
> >> a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
> >> b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt new
> >> file mode 100644
> >> index 0000000..d5b1401
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
> >> @@ -0,0 +1,53 @@
> >> +* Temperature Sensor ADC (TSADC) on rockchip SoCs
> >> +
> >> +Required properties:
> >> +- compatible : "rockchip,rk3288-tsadc"
> >> +- reg : physical base address of the controller and length of memory
> >> mapped + region.
> >> +- interrupts : The interrupt number to the cpu. The interrupt specifier
> >> format + depends on the interrupt controller.
> >> +- clocks : Must contain an entry for each entry in clock-names.
> >> +- clock-names : Shall be "tsadc" for the converter-clock, and "apb_pclk"
> >> for + the peripheral clock.
> >> +- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a
> >> description.>
> > I think you are missing description of hw-shut-temp, tsadc-tshut-mode
> > and tsadc-tshut-mode
> >
> > and optional pinctrl settings.
>
> If it's really need,we just have hw-shut-temp,tsadc-tshut-mode
> and tsadc-tshut-mode,no need pinctrl setting,I think.
This is more question to DeviceTree guys, but I can see us not documenting
pinctrl since it is generic property used by every driver out there. We should
definitely document driver-specific properties.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2014-10-28 0:37 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 2:39 [PATCH v14 0/5] Rockchip soc thermal driver Caesar Wang
2014-10-27 2:39 ` Caesar Wang
2014-10-27 2:39 ` [PATCH v14 1/5] thermal: rockchip: add driver for thermal Caesar Wang
2014-10-27 2:39 ` Caesar Wang
2014-10-28 0:32 ` Dmitry Torokhov
2014-10-28 0:32 ` Dmitry Torokhov
2014-10-28 3:36 ` Caesar Wang
2014-10-28 3:36 ` Caesar Wang
2014-10-27 2:39 ` [PATCH v14 2/5] dt-bindings: document Rockchip thermal Caesar Wang
2014-10-27 2:39 ` Caesar Wang
2014-10-27 2:39 ` Caesar Wang
2014-10-28 0:29 ` Dmitry Torokhov
2014-10-28 0:29 ` Dmitry Torokhov
2014-10-28 0:32 ` Caesar Wang
2014-10-28 0:32 ` Caesar Wang
2014-10-28 0:37 ` Dmitry Torokhov [this message]
2014-10-28 0:37 ` Dmitry Torokhov
2014-10-27 2:39 ` [PATCH v14 3/5] ARM: dts: add RK3288 Thermal data Caesar Wang
2014-10-27 2:39 ` Caesar Wang
2014-10-28 0:25 ` Dmitry Torokhov
2014-10-28 0:25 ` Dmitry Torokhov
2014-10-27 2:39 ` [PATCH v14 4/5] ARM: dts: add main Thermal info to rk3288 Caesar Wang
2014-10-27 2:39 ` Caesar Wang
2014-10-28 0:25 ` Dmitry Torokhov
2014-10-28 0:25 ` Dmitry Torokhov
2014-10-27 2:39 ` [PATCH v14 5/5] ARM: dts: enable Thermal on rk3288-evb board Caesar Wang
2014-10-27 2:39 ` Caesar Wang
2014-10-28 0:26 ` Dmitry Torokhov
2014-10-28 0:26 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4038023.8IINY8khj6@dtor-glaptop \
--to=dmitry.torokhov@gmail.com \
--cc=caesar.wang@rock-chips.com \
--cc=cf@rock-chips.com \
--cc=cjf@rock-chips.com \
--cc=dbasehore@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=edubezval@gmail.com \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=rui.zhang@intel.com \
--cc=zhengsq@rock-chips.com \
--cc=zyf@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.