All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrzej Hajda <a.hajda@samsung.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
	dri-devel@lists.freedesktop.org, David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel.vetter@intel.com>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Sean Paul <seanpaul@chromium.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/28] drm/bridge: fix include notation and remove -Iinclude/drm flag
Date: Fri, 21 Apr 2017 07:51:08 +0200	[thread overview]
Message-ID: <4121ae55-b126-0a3e-b1a8-4cef5c39f5d4@samsung.com> (raw)
In-Reply-To: <1492682232-29769-6-git-send-email-yamada.masahiro@socionext.com>

Hi Masahiro,

On 20.04.2017 11:56, Masahiro Yamada wrote:
> Include <drm/*.h> instead of relative path from include/drm, then
> remove the -Iinclude/drm compiler flag.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
>  drivers/gpu/drm/bridge/Makefile        |  2 --
>  drivers/gpu/drm/bridge/nxp-ptn3460.c   | 10 +++++-----
>  drivers/gpu/drm/bridge/parade-ps8622.c |  8 ++++----
>  3 files changed, 9 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/Makefile b/drivers/gpu/drm/bridge/Makefile
> index 3fe2226..defcf1e 100644
> --- a/drivers/gpu/drm/bridge/Makefile
> +++ b/drivers/gpu/drm/bridge/Makefile
> @@ -1,5 +1,3 @@
> -ccflags-y := -Iinclude/drm
> -
>  obj-$(CONFIG_DRM_ANALOGIX_ANX78XX) += analogix-anx78xx.o
>  obj-$(CONFIG_DRM_DUMB_VGA_DAC) += dumb-vga-dac.o
>  obj-$(CONFIG_DRM_LVDS_ENCODER) += lvds-encoder.o
> diff --git a/drivers/gpu/drm/bridge/nxp-ptn3460.c b/drivers/gpu/drm/bridge/nxp-ptn3460.c
> index 3517043..3fc285a 100644
> --- a/drivers/gpu/drm/bridge/nxp-ptn3460.c
> +++ b/drivers/gpu/drm/bridge/nxp-ptn3460.c
> @@ -24,11 +24,11 @@
>  #include <drm/drm_of.h>
>  #include <drm/drm_panel.h>
>  
> -#include "drm_crtc.h"
> -#include "drm_crtc_helper.h"
> -#include "drm_atomic_helper.h"
> -#include "drm_edid.h"
> -#include "drmP.h"
> +#include <drm/drm_crtc.h>
> +#include <drm/drm_crtc_helper.h>
> +#include <drm/drm_atomic_helper.h>
> +#include <drm/drm_edid.h>
> +#include <drm/drmP.h>

Could you merge these includes with the ones above and sort them
alphabetically.

>  
>  #define PTN3460_EDID_ADDR			0x0
>  #define PTN3460_EDID_EMULATION_ADDR		0x84
> diff --git a/drivers/gpu/drm/bridge/parade-ps8622.c b/drivers/gpu/drm/bridge/parade-ps8622.c
> index 1dcec3b..ada2186 100644
> --- a/drivers/gpu/drm/bridge/parade-ps8622.c
> +++ b/drivers/gpu/drm/bridge/parade-ps8622.c
> @@ -28,10 +28,10 @@
>  #include <drm/drm_of.h>
>  #include <drm/drm_panel.h>
>  
> -#include "drmP.h"
> -#include "drm_crtc.h"
> -#include "drm_crtc_helper.h"
> -#include "drm_atomic_helper.h"
> +#include <drm/drmP.h>
> +#include <drm/drm_crtc.h>
> +#include <drm/drm_crtc_helper.h>
> +#include <drm/drm_atomic_helper.h>

Ditto.

After this change you can add my:
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>

 --
Regards
Andrzej


>  
>  /* Brightness scale on the Parade chip */
>  #define PS8622_MAX_BRIGHTNESS 0xff

WARNING: multiple messages have this Message-ID (diff)
From: Andrzej Hajda <a.hajda@samsung.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
	dri-devel@lists.freedesktop.org, David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel.vetter@intel.com>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Sean Paul <seanpaul@chromium.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/28] drm/bridge: fix include notation and remove -Iinclude/drm flag
Date: Fri, 21 Apr 2017 07:51:08 +0200	[thread overview]
Message-ID: <4121ae55-b126-0a3e-b1a8-4cef5c39f5d4@samsung.com> (raw)
In-Reply-To: <1492682232-29769-6-git-send-email-yamada.masahiro@socionext.com>

Hi Masahiro,

On 20.04.2017 11:56, Masahiro Yamada wrote:
> Include <drm/*.h> instead of relative path from include/drm, then
> remove the -Iinclude/drm compiler flag.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
>  drivers/gpu/drm/bridge/Makefile        |  2 --
>  drivers/gpu/drm/bridge/nxp-ptn3460.c   | 10 +++++-----
>  drivers/gpu/drm/bridge/parade-ps8622.c |  8 ++++----
>  3 files changed, 9 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/Makefile b/drivers/gpu/drm/bridge/Makefile
> index 3fe2226..defcf1e 100644
> --- a/drivers/gpu/drm/bridge/Makefile
> +++ b/drivers/gpu/drm/bridge/Makefile
> @@ -1,5 +1,3 @@
> -ccflags-y := -Iinclude/drm
> -
>  obj-$(CONFIG_DRM_ANALOGIX_ANX78XX) += analogix-anx78xx.o
>  obj-$(CONFIG_DRM_DUMB_VGA_DAC) += dumb-vga-dac.o
>  obj-$(CONFIG_DRM_LVDS_ENCODER) += lvds-encoder.o
> diff --git a/drivers/gpu/drm/bridge/nxp-ptn3460.c b/drivers/gpu/drm/bridge/nxp-ptn3460.c
> index 3517043..3fc285a 100644
> --- a/drivers/gpu/drm/bridge/nxp-ptn3460.c
> +++ b/drivers/gpu/drm/bridge/nxp-ptn3460.c
> @@ -24,11 +24,11 @@
>  #include <drm/drm_of.h>
>  #include <drm/drm_panel.h>
>  
> -#include "drm_crtc.h"
> -#include "drm_crtc_helper.h"
> -#include "drm_atomic_helper.h"
> -#include "drm_edid.h"
> -#include "drmP.h"
> +#include <drm/drm_crtc.h>
> +#include <drm/drm_crtc_helper.h>
> +#include <drm/drm_atomic_helper.h>
> +#include <drm/drm_edid.h>
> +#include <drm/drmP.h>

Could you merge these includes with the ones above and sort them
alphabetically.

>  
>  #define PTN3460_EDID_ADDR			0x0
>  #define PTN3460_EDID_EMULATION_ADDR		0x84
> diff --git a/drivers/gpu/drm/bridge/parade-ps8622.c b/drivers/gpu/drm/bridge/parade-ps8622.c
> index 1dcec3b..ada2186 100644
> --- a/drivers/gpu/drm/bridge/parade-ps8622.c
> +++ b/drivers/gpu/drm/bridge/parade-ps8622.c
> @@ -28,10 +28,10 @@
>  #include <drm/drm_of.h>
>  #include <drm/drm_panel.h>
>  
> -#include "drmP.h"
> -#include "drm_crtc.h"
> -#include "drm_crtc_helper.h"
> -#include "drm_atomic_helper.h"
> +#include <drm/drmP.h>
> +#include <drm/drm_crtc.h>
> +#include <drm/drm_crtc_helper.h>
> +#include <drm/drm_atomic_helper.h>

Ditto.

After this change you can add my:
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>

 --
Regards
Andrzej


>  
>  /* Brightness scale on the Parade chip */
>  #define PS8622_MAX_BRIGHTNESS 0xff


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2017-04-21  5:51 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-20  9:56 [PATCH 00/28] gpu/drm: remove -Iinclude/drm compiler flags from Makefile Masahiro Yamada
2017-04-20  9:56 ` [PATCH 01/28] drm/ttm: fix include notation and remove -Iinclude/drm flag Masahiro Yamada
2017-04-21  9:00   ` Michel Dänzer
2017-04-21  9:00     ` Michel Dänzer
2017-04-20  9:56 ` [PATCH 02/28] drm/amd: " Masahiro Yamada
2017-04-21  9:03   ` Michel Dänzer
2017-04-21  9:03     ` Michel Dänzer
2017-04-20  9:56 ` [PATCH 03/28] drm/ast: " Masahiro Yamada
2017-04-20  9:56 ` [PATCH 04/28] drm/bochs: " Masahiro Yamada
2017-04-20  9:56 ` [PATCH 05/28] drm/bridge: " Masahiro Yamada
2017-04-21  5:51   ` Andrzej Hajda [this message]
2017-04-21  5:51     ` Andrzej Hajda
2017-04-21  8:50     ` Masahiro Yamada
2017-04-20  9:56 ` [PATCH 06/28] drm/cirrus: " Masahiro Yamada
2017-04-20  9:56 ` [PATCH 07/28] drm/hisilicon: " Masahiro Yamada
2017-04-20  9:56 ` [PATCH 08/28] drm/mgag200: " Masahiro Yamada
2017-04-20  9:56 ` [PATCH 09/28] drm/msm: " Masahiro Yamada
2017-04-20  9:56 ` [PATCH 10/28] drm/nouveau: " Masahiro Yamada
2017-04-20  9:56 ` [PATCH 11/28] drm/qxl: " Masahiro Yamada
2017-04-25 17:04   ` Gabriel Krisman Bertazi
2017-04-25 17:04     ` Gabriel Krisman Bertazi
2017-04-20  9:56 ` [PATCH 12/28] drm/radeon: " Masahiro Yamada
2017-04-20  9:56 ` [PATCH 13/28] drm/tilcdc: " Masahiro Yamada
2017-04-20  9:56 ` [PATCH 14/28] drm/vc4: " Masahiro Yamada
2017-04-20  9:56 ` [PATCH 15/28] drm/virtio: " Masahiro Yamada
2017-04-20  9:57 ` [PATCH 16/28] drm/vmwgfx: " Masahiro Yamada
2017-04-20  9:57 ` [PATCH 17/28] drm/gma500: remove unneeded -Iinclude/drm compiler flag Masahiro Yamada
2017-04-20  9:57 ` [PATCH 18/28] drm/i810: " Masahiro Yamada
2017-04-20  9:57 ` [PATCH 19/28] drm/i2c: " Masahiro Yamada
2017-04-20  9:57 ` [PATCH 20/28] drm/mga: " Masahiro Yamada
2017-04-20  9:57 ` [PATCH 21/28] drm/omap: " Masahiro Yamada
2017-04-20  9:57 ` [PATCH 22/28] drm/r128: " Masahiro Yamada
2017-04-20  9:57 ` [PATCH 23/28] drm/savage: " Masahiro Yamada
2017-04-20  9:57 ` [PATCH 24/28] drm/sis: " Masahiro Yamada
2017-04-20  9:57 ` [PATCH 25/28] drm/tdfx: " Masahiro Yamada
2017-04-20  9:57 ` [PATCH 26/28] drm/udl: " Masahiro Yamada
2017-04-20  9:57 ` [PATCH 27/28] drm/vgem: " Masahiro Yamada
2017-04-20  9:57 ` [PATCH 28/28] drm/via: " Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4121ae55-b126-0a3e-b1a8-4cef5c39f5d4@samsung.com \
    --to=a.hajda@samsung.com \
    --cc=airlied@linux.ie \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=seanpaul@chromium.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.