From: David Lechner <david@lechnology.com> To: William Breathitt Gray <vilhelm.gray@gmail.com>, jic23@kernel.org Cc: kernel@pengutronix.de, linux-stm32@st-md-mailman.stormreply.com, a.fatoum@pengutronix.de, kamel.bouhara@bootlin.com, gwendal@chromium.org, alexandre.belloni@bootlin.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, syednwaris@gmail.com, patrick.havelange@essensium.com, fabrice.gasnier@st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com Subject: Re: [PATCH v7 4/5] docs: counter: Document character device interface Date: Wed, 30 Dec 2020 12:18:48 -0600 [thread overview] Message-ID: <416fe56e-bfb3-3f46-7f03-17009fa27dee@lechnology.com> (raw) In-Reply-To: <1e69b7beae4cf352bddb379220d0d52b20db0634.1608935587.git.vilhelm.gray@gmail.com> On 12/25/20 6:15 PM, William Breathitt Gray wrote: > +Userspace > +--------- > +Userspace applications can configure Counter events via ioctl operations > +on the Counter character device node. There following ioctl codes are > +supported and provided by the `linux/counter.h` userspace header file: > + > +* COUNTER_CLEAR_WATCHES_IOCTL: > + Clear all Counter watches from all events > + > +* COUNTER_ADD_WATCH_IOCTL: > + Add a Counter watch for the specified event > + > +* COUNTER_LOAD_WATCHES_IOCTL: > + Activates the Counter watches added earlier Would it make more sense to call the last and first ones COUNTER_ENABLE_EVENTS_IOCTL and COUNTER_DISABLE_EVENTS_IOCTL? In any case, more explanation would be helpful. * COUNTER_ADD_WATCH_IOCTL: Queues a Counter watch for the specified event. The queued watches will not be applied until COUNTER_ENABLE_EVENTS_IOCTL is called. * COUNTER_ENABLE_EVENTS_IOCTL: Enables monitoring the events specified by the Counter watches that were queued by COUNTER_ADD_WATCH_IOCTL. If events are already enabled, the new set of watches replaces the old one. Calling this ioctl also has the effect of clearing the queue of watches added by COUNTER_ADD_WATCH_IOCTL. * COUNTER_DISABLE_EVENTS_IOCTL: Stops monitoring the previously enabled events. > + > +To configure events to gather Counter data, users first populate a > +`struct counter_watch` with the relevant event id, event channel id, and > +the information for the desired Counter component from which to read, > +and then pass it via the `COUNTER_ADD_WATCH_IOCTL` ioctl command. for restructured text, two backticks are needed for ``code`` formatting
WARNING: multiple messages have this Message-ID (diff)
From: David Lechner <david@lechnology.com> To: William Breathitt Gray <vilhelm.gray@gmail.com>, jic23@kernel.org Cc: kamel.bouhara@bootlin.com, gwendal@chromium.org, a.fatoum@pengutronix.de, mcoquelin.stm32@gmail.com, linux-iio@vger.kernel.org, patrick.havelange@essensium.com, alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org, kernel@pengutronix.de, fabrice.gasnier@st.com, syednwaris@gmail.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, alexandre.torgue@st.com Subject: Re: [PATCH v7 4/5] docs: counter: Document character device interface Date: Wed, 30 Dec 2020 12:18:48 -0600 [thread overview] Message-ID: <416fe56e-bfb3-3f46-7f03-17009fa27dee@lechnology.com> (raw) In-Reply-To: <1e69b7beae4cf352bddb379220d0d52b20db0634.1608935587.git.vilhelm.gray@gmail.com> On 12/25/20 6:15 PM, William Breathitt Gray wrote: > +Userspace > +--------- > +Userspace applications can configure Counter events via ioctl operations > +on the Counter character device node. There following ioctl codes are > +supported and provided by the `linux/counter.h` userspace header file: > + > +* COUNTER_CLEAR_WATCHES_IOCTL: > + Clear all Counter watches from all events > + > +* COUNTER_ADD_WATCH_IOCTL: > + Add a Counter watch for the specified event > + > +* COUNTER_LOAD_WATCHES_IOCTL: > + Activates the Counter watches added earlier Would it make more sense to call the last and first ones COUNTER_ENABLE_EVENTS_IOCTL and COUNTER_DISABLE_EVENTS_IOCTL? In any case, more explanation would be helpful. * COUNTER_ADD_WATCH_IOCTL: Queues a Counter watch for the specified event. The queued watches will not be applied until COUNTER_ENABLE_EVENTS_IOCTL is called. * COUNTER_ENABLE_EVENTS_IOCTL: Enables monitoring the events specified by the Counter watches that were queued by COUNTER_ADD_WATCH_IOCTL. If events are already enabled, the new set of watches replaces the old one. Calling this ioctl also has the effect of clearing the queue of watches added by COUNTER_ADD_WATCH_IOCTL. * COUNTER_DISABLE_EVENTS_IOCTL: Stops monitoring the previously enabled events. > + > +To configure events to gather Counter data, users first populate a > +`struct counter_watch` with the relevant event id, event channel id, and > +the information for the desired Counter component from which to read, > +and then pass it via the `COUNTER_ADD_WATCH_IOCTL` ioctl command. for restructured text, two backticks are needed for ``code`` formatting _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-30 18:19 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-26 0:15 [PATCH v7 0/5] Introduce the Counter character device interface William Breathitt Gray 2020-12-26 0:15 ` William Breathitt Gray 2020-12-26 0:15 ` [PATCH v7 1/5] counter: Internalize sysfs interface code William Breathitt Gray 2020-12-30 14:37 ` Jonathan Cameron 2021-01-06 5:29 ` William Breathitt Gray 2021-01-06 5:29 ` William Breathitt Gray 2020-12-30 23:24 ` David Lechner 2020-12-30 23:24 ` David Lechner 2021-01-06 5:30 ` William Breathitt Gray 2021-01-06 5:30 ` William Breathitt Gray 2020-12-26 0:15 ` [PATCH v7 2/5] docs: counter: Update to reflect sysfs internalization William Breathitt Gray 2020-12-26 0:15 ` William Breathitt Gray 2020-12-30 14:41 ` Jonathan Cameron 2020-12-30 14:41 ` Jonathan Cameron 2020-12-26 0:15 ` [PATCH v7 3/5] counter: Add character device interface William Breathitt Gray 2020-12-26 0:15 ` William Breathitt Gray 2020-12-30 15:04 ` Jonathan Cameron 2020-12-30 15:04 ` Jonathan Cameron 2021-02-12 6:32 ` William Breathitt Gray 2021-02-12 6:32 ` William Breathitt Gray 2020-12-30 21:36 ` David Lechner 2020-12-30 21:36 ` David Lechner 2021-01-30 4:59 ` William Breathitt Gray 2021-01-30 4:59 ` William Breathitt Gray 2021-01-04 18:15 ` Dan Carpenter 2021-01-04 18:15 ` Dan Carpenter 2021-01-28 9:01 ` Oleksij Rempel 2021-01-28 9:01 ` Oleksij Rempel 2021-01-30 5:15 ` William Breathitt Gray 2021-01-30 5:15 ` William Breathitt Gray 2020-12-26 0:15 ` [PATCH v7 4/5] docs: counter: Document " William Breathitt Gray 2020-12-26 0:15 ` William Breathitt Gray 2020-12-30 14:47 ` Jonathan Cameron 2020-12-30 14:47 ` Jonathan Cameron 2020-12-30 18:18 ` David Lechner [this message] 2020-12-30 18:18 ` David Lechner 2020-12-26 0:15 ` [PATCH v7 5/5] counter: 104-quad-8: Add IRQ support for the ACCES 104-QUAD-8 William Breathitt Gray 2020-12-26 0:15 ` William Breathitt Gray 2020-12-30 15:31 ` Jonathan Cameron 2020-12-30 15:31 ` Jonathan Cameron 2021-02-12 6:04 ` William Breathitt Gray 2021-02-12 6:04 ` William Breathitt Gray 2020-12-30 17:36 ` David Lechner 2020-12-30 17:36 ` David Lechner 2021-02-11 23:56 ` William Breathitt Gray 2021-02-11 23:56 ` William Breathitt Gray 2021-02-12 1:10 ` David Lechner 2021-02-12 1:10 ` David Lechner 2020-12-30 23:34 ` [PATCH v7 0/5] Introduce the Counter character device interface David Lechner 2020-12-30 23:34 ` David Lechner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=416fe56e-bfb3-3f46-7f03-17009fa27dee@lechnology.com \ --to=david@lechnology.com \ --cc=a.fatoum@pengutronix.de \ --cc=alexandre.belloni@bootlin.com \ --cc=alexandre.torgue@st.com \ --cc=fabrice.gasnier@st.com \ --cc=gwendal@chromium.org \ --cc=jic23@kernel.org \ --cc=kamel.bouhara@bootlin.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=mcoquelin.stm32@gmail.com \ --cc=patrick.havelange@essensium.com \ --cc=syednwaris@gmail.com \ --cc=vilhelm.gray@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.