From: Heiko Stuebner <heiko@sntech.de>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
linux-rockchip@lists.infradead.org,
Daniel Vetter <daniel.vetter@intel.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 21/26] drm/rockchip: Use drm_fb_helper_fill_info
Date: Sun, 27 Jan 2019 20:18:58 +0100 [thread overview]
Message-ID: <4175833.BHsNDjujy6@phil> (raw)
In-Reply-To: <20190124165831.16427-22-daniel.vetter@ffwll.ch>
Am Donnerstag, 24. Januar 2019, 17:58:26 CET schrieb Daniel Vetter:
> This will set an fb name for the first time!
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Sandy Huang <hjc@rock-chips.com>
> Cc: "Heiko Stübner" <heiko@sntech.de>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-rockchip@lists.infradead.org
After looking up the rest of the series and also realizing that
fbi->par seems to be set when a client attaches to the fb,
this looks good to me, so
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> ---
> drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
> index 7bd3b89022be..d12164878e05 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
> @@ -90,13 +90,11 @@ static int rockchip_drm_fbdev_create(struct drm_fb_helper *helper,
> goto out;
> }
>
> - fbi->par = helper;
> fbi->flags = FBINFO_FLAG_DEFAULT;
> fbi->fbops = &rockchip_drm_fbdev_ops;
>
> fb = helper->fb;
> - drm_fb_helper_fill_fix(fbi, fb->pitches[0], fb->format->depth);
> - drm_fb_helper_fill_var(fbi, helper, sizes->fb_width, sizes->fb_height);
> + drm_fb_helper_fill_info(fbi, helper);
>
> offset = fbi->var.xoffset * bytes_per_pixel;
> offset += fbi->var.yoffset * fb->pitches[0];
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Sandy Huang <hjc@rock-chips.com>,
DRI Development <dri-devel@lists.freedesktop.org>,
linux-rockchip@lists.infradead.org,
Daniel Vetter <daniel.vetter@intel.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 21/26] drm/rockchip: Use drm_fb_helper_fill_info
Date: Sun, 27 Jan 2019 20:18:58 +0100 [thread overview]
Message-ID: <4175833.BHsNDjujy6@phil> (raw)
In-Reply-To: <20190124165831.16427-22-daniel.vetter@ffwll.ch>
Am Donnerstag, 24. Januar 2019, 17:58:26 CET schrieb Daniel Vetter:
> This will set an fb name for the first time!
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Sandy Huang <hjc@rock-chips.com>
> Cc: "Heiko Stübner" <heiko@sntech.de>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-rockchip@lists.infradead.org
After looking up the rest of the series and also realizing that
fbi->par seems to be set when a client attaches to the fb,
this looks good to me, so
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> ---
> drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
> index 7bd3b89022be..d12164878e05 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
> @@ -90,13 +90,11 @@ static int rockchip_drm_fbdev_create(struct drm_fb_helper *helper,
> goto out;
> }
>
> - fbi->par = helper;
> fbi->flags = FBINFO_FLAG_DEFAULT;
> fbi->fbops = &rockchip_drm_fbdev_ops;
>
> fb = helper->fb;
> - drm_fb_helper_fill_fix(fbi, fb->pitches[0], fb->format->depth);
> - drm_fb_helper_fill_var(fbi, helper, sizes->fb_width, sizes->fb_height);
> + drm_fb_helper_fill_info(fbi, helper);
>
> offset = fbi->var.xoffset * bytes_per_pixel;
> offset += fbi->var.yoffset * fb->pitches[0];
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-27 19:18 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 16:58 [PATCH 00/26] some cleanups, mostly around fbdev emulation Daniel Vetter
2019-01-24 16:58 ` [PATCH 01/26] drm/irq: Don't check for DRIVER_HAVE_IRQ in drm_irq_(un)install Daniel Vetter
2019-01-24 16:58 ` Daniel Vetter
2019-01-24 16:58 ` Daniel Vetter
2019-01-24 16:58 ` Daniel Vetter
[not found] ` <20190124165831.16427-2-daniel.vetter-/w4YWyX8dFk@public.gmane.org>
2019-01-25 10:40 ` Sam Ravnborg
2019-01-25 10:40 ` Sam Ravnborg
2019-01-25 10:40 ` Sam Ravnborg
2019-01-25 10:40 ` Sam Ravnborg
2019-01-25 10:40 ` Sam Ravnborg
2019-01-25 15:09 ` Emil Velikov
2019-01-25 15:09 ` Emil Velikov
2019-01-25 15:09 ` Emil Velikov
2019-01-25 15:09 ` Emil Velikov
2019-01-25 15:09 ` Emil Velikov
2019-01-24 16:58 ` [PATCH 02/26] drm: Switch DRIVER_ flags to an enum Daniel Vetter
2019-01-24 17:38 ` Sam Ravnborg
2019-01-25 9:35 ` Daniel Vetter
2019-01-24 16:58 ` [PATCH 03/26] drm/irq: Ditch DRIVER_IRQ_SHARED Daniel Vetter
2019-01-25 14:46 ` Emil Velikov
2019-01-25 16:14 ` [Intel-gfx] " Daniel Vetter
2019-01-28 11:47 ` Emil Velikov
2019-01-24 16:58 ` [PATCH 04/26] drm/fb-helper: Add fill_info() functions Daniel Vetter
2019-01-24 17:40 ` Noralf Trønnes
2019-01-25 8:48 ` Daniel Vetter
2019-01-25 9:46 ` Noralf Trønnes
2019-01-25 10:15 ` Daniel Vetter
2019-01-24 16:58 ` [PATCH 05/26] drm/fb-helper: set fbi->fix.id in fill_info() Daniel Vetter
2019-01-24 17:28 ` Daniel Vetter
2019-01-24 16:58 ` [PATCH 06/26] drm/fb_helper: set info->par " Daniel Vetter
2019-01-24 17:45 ` Sam Ravnborg
2019-01-25 8:44 ` Daniel Vetter
2019-01-25 18:25 ` Sam Ravnborg
2019-01-24 16:58 ` [PATCH 07/26] drm/amdgpu: Use drm_fb_helper_fill_info Daniel Vetter
2019-01-24 16:58 ` [PATCH 08/26] drm/armada: " Daniel Vetter
2019-01-24 16:58 ` [PATCH 09/26] drm/ast: " Daniel Vetter
2019-01-24 18:00 ` Sam Ravnborg
2019-01-25 8:51 ` Daniel Vetter
2019-01-24 16:58 ` [PATCH 10/26] drm/cirrus: " Daniel Vetter
2019-01-24 16:58 ` [PATCH 11/26] drm/exynos: " Daniel Vetter
2019-01-24 16:58 ` Daniel Vetter
2019-01-24 16:58 ` [PATCH 12/26] drm/gma500: " Daniel Vetter
2019-01-24 16:58 ` [PATCH 13/26] drm/hibmc: " Daniel Vetter
2019-01-24 16:58 ` [PATCH 14/26] drm/i915: " Daniel Vetter
2019-01-24 16:58 ` [PATCH 15/26] drm/mga200g: " Daniel Vetter
[not found] ` <20190124165831.16427-1-daniel.vetter-/w4YWyX8dFk@public.gmane.org>
2019-01-24 16:58 ` [PATCH 16/26] drm/bochs: " Daniel Vetter
2019-01-24 16:58 ` [PATCH 26/26] drm/<drivers>: Don't set FBINFO_(FLAG_)DEFAULT Daniel Vetter
2019-01-24 16:58 ` Daniel Vetter
2019-01-25 15:02 ` Emil Velikov
2019-01-25 15:02 ` [Intel-gfx] " Emil Velikov
2019-01-29 9:58 ` Daniel Vetter
2019-01-29 9:58 ` Daniel Vetter
2019-01-25 15:14 ` Thierry Reding
2019-01-25 15:14 ` Thierry Reding
2019-01-24 16:58 ` [PATCH 17/26] drm/nouveau: Use drm_fb_helper_fill_info Daniel Vetter
2019-01-24 16:58 ` [PATCH 18/26] drm/omap: " Daniel Vetter
2019-01-24 16:58 ` [PATCH 19/26] drm/qxl: " Daniel Vetter
2019-01-25 6:39 ` Gerd Hoffmann
2019-01-25 6:39 ` Gerd Hoffmann
2019-01-25 8:52 ` Daniel Vetter
2019-01-25 8:52 ` Daniel Vetter
2019-01-24 16:58 ` [PATCH 20/26] drm/radeon: " Daniel Vetter
2019-01-24 16:58 ` [PATCH 21/26] drm/rockchip: " Daniel Vetter
2019-01-27 19:18 ` Heiko Stuebner [this message]
2019-01-27 19:18 ` Heiko Stuebner
2019-01-24 16:58 ` [PATCH 22/26] drm/qxl: " Daniel Vetter
2019-01-25 15:14 ` Thierry Reding
2019-01-24 16:58 ` [PATCH 23/26] drm/udl: " Daniel Vetter
2019-01-24 16:58 ` [PATCH 24/26] staging/vboxvideo: " Daniel Vetter
2019-01-25 8:51 ` Greg Kroah-Hartman
2019-01-24 16:58 ` [PATCH 25/26] drm/fb-helper: Unexport fill_{var,info} Daniel Vetter
2019-01-24 17:01 ` ✗ Fi.CI.BAT: failure for some cleanups, mostly around fbdev emulation Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4175833.BHsNDjujy6@phil \
--to=heiko@sntech.de \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.