From: Suman Anna <s-anna@ti.com> To: Tony Lindgren <tony@atomide.com> Cc: <linux-omap@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, Tero Kristo <t-kristo@ti.com> Subject: Re: [PATCH 00/13] Add IPU & DSP remoteprocs on OMAP4 and OMAP5 Date: Fri, 10 Jul 2020 12:17:51 -0500 [thread overview] Message-ID: <41bd2bb4-06fe-5f70-22cf-ce9cedc8bbc3@ti.com> (raw) In-Reply-To: <20200710165814.GF5849@atomide.com> On 7/10/20 11:58 AM, Tony Lindgren wrote: > Hi, > > * Suman Anna <s-anna@ti.com> [200709 16:20]: >> Hi Tony, >> >> The following series contains all the necessary DT pieces to boot the >> IPU and DSP remote processors on OMAP4 and OMAP5 SoCs. They are >> enabled specifically on the TI OMAP4 PandaBoard and OMAP5 uEVM boards. >> This is the last DT piece that now completes the support for IPUs and >> DSPs on all OMAP4+ SoCs, similar patches were merged for 5.8 covering >> the DRA7xx/AM57xx SoCs. Appreciate it if you can pick up the series for >> 5.9 if it isn't too late. > > Great and good to hear things are working with only dts changes now :) > Yes let's try to get these merged. Thanks. > >> There is one issue that I have run into while testing this series on >> the latest kernel. I am seeing a l3_noc error for OMAP4 DSP when it >> attempts to auto-suspend or stop after it is booted. The issue is a >> L4CFG read error that happens in the sysc_disable_module() function >> in ti-sysc code. >> >> I do not have any issues on my downstream 5.4 based SDK kernel. I have >> root-caused this to the OMAP4 voltage controller patches you added for >> 5.5 kernel through your omap-for-v5.5/pm branch, specifically the >> commit 4873843718f9 ("ARM: OMAP2+: Initialize voltage controller for omap4"). >> The VOLTCTRL register value is 0x300 before that patch, and modifying >> this register either through omap4_vc_init_pmic_signaling() or >> omap4_vc_set_pmic_signaling() will trigger this. A debug print in >> sysc_disable_module() also seems to help. > > Hmm interesting, not sure how the VOLTCTRL register affects this. > > I wonder the following commit in v5.8-rc3 might help with this though: > > 5ce8aee81be6 ("bus: ti-sysc: Flush posted write on enable and disable") > I had already tested on v5.8-rc4 when I posted the patches, so this patch doesn't help. OMAP5 DSP is fine, because Think it has to do with this automated So, I am looking at the TRM, and the three VDD_{IVA,MPU,CORE}_I2C_DISABLE bits in VOLTCTRL are marked debug-purpose only, so I don't think we should be setting those to begin with. Any reason why you want to set those? Anyway, these bits were not an issue, I have specifically tried that already. regards Suman > I was seeing that occasionally with mcspi, but never had anything > reproducable. > > Regards, > > Tony >
WARNING: multiple messages have this Message-ID (diff)
From: Suman Anna <s-anna@ti.com> To: Tony Lindgren <tony@atomide.com> Cc: Tero Kristo <t-kristo@ti.com>, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 00/13] Add IPU & DSP remoteprocs on OMAP4 and OMAP5 Date: Fri, 10 Jul 2020 12:17:51 -0500 [thread overview] Message-ID: <41bd2bb4-06fe-5f70-22cf-ce9cedc8bbc3@ti.com> (raw) In-Reply-To: <20200710165814.GF5849@atomide.com> On 7/10/20 11:58 AM, Tony Lindgren wrote: > Hi, > > * Suman Anna <s-anna@ti.com> [200709 16:20]: >> Hi Tony, >> >> The following series contains all the necessary DT pieces to boot the >> IPU and DSP remote processors on OMAP4 and OMAP5 SoCs. They are >> enabled specifically on the TI OMAP4 PandaBoard and OMAP5 uEVM boards. >> This is the last DT piece that now completes the support for IPUs and >> DSPs on all OMAP4+ SoCs, similar patches were merged for 5.8 covering >> the DRA7xx/AM57xx SoCs. Appreciate it if you can pick up the series for >> 5.9 if it isn't too late. > > Great and good to hear things are working with only dts changes now :) > Yes let's try to get these merged. Thanks. > >> There is one issue that I have run into while testing this series on >> the latest kernel. I am seeing a l3_noc error for OMAP4 DSP when it >> attempts to auto-suspend or stop after it is booted. The issue is a >> L4CFG read error that happens in the sysc_disable_module() function >> in ti-sysc code. >> >> I do not have any issues on my downstream 5.4 based SDK kernel. I have >> root-caused this to the OMAP4 voltage controller patches you added for >> 5.5 kernel through your omap-for-v5.5/pm branch, specifically the >> commit 4873843718f9 ("ARM: OMAP2+: Initialize voltage controller for omap4"). >> The VOLTCTRL register value is 0x300 before that patch, and modifying >> this register either through omap4_vc_init_pmic_signaling() or >> omap4_vc_set_pmic_signaling() will trigger this. A debug print in >> sysc_disable_module() also seems to help. > > Hmm interesting, not sure how the VOLTCTRL register affects this. > > I wonder the following commit in v5.8-rc3 might help with this though: > > 5ce8aee81be6 ("bus: ti-sysc: Flush posted write on enable and disable") > I had already tested on v5.8-rc4 when I posted the patches, so this patch doesn't help. OMAP5 DSP is fine, because Think it has to do with this automated So, I am looking at the TRM, and the three VDD_{IVA,MPU,CORE}_I2C_DISABLE bits in VOLTCTRL are marked debug-purpose only, so I don't think we should be setting those to begin with. Any reason why you want to set those? Anyway, these bits were not an issue, I have specifically tried that already. regards Suman > I was seeing that occasionally with mcspi, but never had anything > reproducable. > > Regards, > > Tony > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-10 17:17 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-09 23:19 [PATCH 00/13] Add IPU & DSP remoteprocs on OMAP4 and OMAP5 Suman Anna 2020-07-09 23:19 ` Suman Anna 2020-07-09 23:19 ` [PATCH 01/13] ARM: dts: omap4: Add timer_sys_ck clocks for timers Suman Anna 2020-07-09 23:19 ` Suman Anna 2020-07-09 23:19 ` [PATCH 02/13] ARM: dts: omap5: " Suman Anna 2020-07-09 23:19 ` Suman Anna 2020-07-09 23:19 ` [PATCH 03/13] ARM: dts: omap4: Update the DSP node Suman Anna 2020-07-09 23:19 ` Suman Anna 2020-07-09 23:19 ` [PATCH 04/13] ARM: dts: omap4: Add IPU DT node Suman Anna 2020-07-09 23:19 ` Suman Anna 2020-07-09 23:19 ` [PATCH 05/13] ARM: dts: omap4: Add aliases for rproc nodes Suman Anna 2020-07-09 23:19 ` Suman Anna 2020-07-09 23:19 ` [PATCH 06/13] ARM: dts: omap4-panda-common: Add CMA pools and enable IPU & DSP Suman Anna 2020-07-09 23:19 ` Suman Anna 2020-08-12 5:31 ` Guillaume Tucker 2020-08-12 5:31 ` Guillaume Tucker 2020-08-14 14:32 ` Guillaume Tucker 2020-08-14 14:32 ` Guillaume Tucker 2020-08-14 15:26 ` Suman Anna 2020-08-14 15:26 ` Suman Anna 2020-08-14 16:33 ` Guillaume Tucker 2020-08-14 16:33 ` Guillaume Tucker 2020-08-14 19:33 ` Suman Anna 2020-08-14 19:33 ` Suman Anna 2020-08-20 9:17 ` Guillaume Tucker 2020-08-20 9:17 ` Guillaume Tucker 2020-07-09 23:19 ` [PATCH 07/13] ARM: dts: omap4-panda-common:: Add system timers to DSP and IPU Suman Anna 2020-07-09 23:19 ` Suman Anna 2020-07-09 23:19 ` [PATCH 08/13] ARM: dts: omap5: Add DSP and IPU nodes Suman Anna 2020-07-09 23:19 ` Suman Anna 2020-07-09 23:19 ` [PATCH 09/13] ARM: dts: omap5: Add aliases for rproc nodes Suman Anna 2020-07-09 23:19 ` Suman Anna 2020-07-09 23:19 ` [PATCH 10/13] ARM: dts: omap5-uevm: Add CMA pools and enable IPU & DSP Suman Anna 2020-07-09 23:19 ` Suman Anna 2020-07-09 23:19 ` [PATCH 11/13] ARM: dts: omap5-uevm: Add system timers to DSP and IPU Suman Anna 2020-07-09 23:19 ` Suman Anna 2020-07-09 23:19 ` [PATCH 12/13] ARM: dts: omap4-panda-common: Add watchdog timers for IPU and DSP Suman Anna 2020-07-09 23:19 ` Suman Anna 2020-07-09 23:19 ` [PATCH 13/13] ARM: dts: omap5-uevm: " Suman Anna 2020-07-09 23:19 ` Suman Anna 2020-07-10 16:58 ` [PATCH 00/13] Add IPU & DSP remoteprocs on OMAP4 and OMAP5 Tony Lindgren 2020-07-10 16:58 ` Tony Lindgren 2020-07-10 17:17 ` Suman Anna [this message] 2020-07-10 17:17 ` Suman Anna 2020-07-10 17:28 ` Suman Anna 2020-07-10 17:28 ` Suman Anna 2020-07-10 17:59 ` Tony Lindgren 2020-07-10 17:59 ` Tony Lindgren 2020-07-10 18:29 ` Suman Anna 2020-07-10 18:29 ` Suman Anna 2020-07-10 20:45 ` Suman Anna 2020-07-10 20:45 ` Suman Anna 2020-07-10 22:08 ` Tony Lindgren 2020-07-10 22:08 ` Tony Lindgren 2020-07-10 17:40 ` Tony Lindgren 2020-07-10 17:40 ` Tony Lindgren 2020-07-10 18:24 ` Suman Anna 2020-07-10 18:24 ` Suman Anna 2020-07-13 18:24 ` Tony Lindgren 2020-07-13 18:24 ` Tony Lindgren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=41bd2bb4-06fe-5f70-22cf-ce9cedc8bbc3@ti.com \ --to=s-anna@ti.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=t-kristo@ti.com \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.