From: Arnaud POULIQUEN <arnaud.pouliquen@st.com> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Ohad Ben-Cohen <ohad@wizery.com>, Bjorn Andersson <bjorn.andersson@linaro.org>, Jiri Slaby <jslaby@suse.com>, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, Mathieu Poirier <mathieu.poirier@linaro.org>, Suman Anna <s-anna@ti.com>, Fabien DESSENNE <fabien.dessenne@st.com>, linux-stm32@st-md-mailman.stormreply.com, Alan Cox <gnomes@lxorguk.ukuu.org.uk>, xiang xiao <xiaoxiang781216@gmail.com> Subject: Re: [PATCH v7 2/2] tty: add rpmsg driver Date: Wed, 25 Mar 2020 12:34:25 +0100 [thread overview] Message-ID: <426f24cb-025b-f497-e9dc-9823181c4056@st.com> (raw) In-Reply-To: <20200324171806.GB2522961@kroah.com> On 3/24/20 6:18 PM, Greg Kroah-Hartman wrote: > On Tue, Mar 24, 2020 at 06:04:07PM +0100, Arnaud Pouliquen wrote: >> This driver exposes a standard TTY interface on top of the rpmsg >> framework through a rpmsg service. >> >> This driver supports multi-instances, offering a /dev/ttyRPMSGx entry >> per rpmsg endpoint. >> >> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@st.com> >> --- >> Documentation/serial/tty_rpmsg.rst | 45 ++++ >> drivers/tty/Kconfig | 9 + >> drivers/tty/Makefile | 1 + >> drivers/tty/rpmsg_tty.c | 417 +++++++++++++++++++++++++++++ >> 4 files changed, 472 insertions(+) >> create mode 100644 Documentation/serial/tty_rpmsg.rst >> create mode 100644 drivers/tty/rpmsg_tty.c >> >> diff --git a/Documentation/serial/tty_rpmsg.rst b/Documentation/serial/tty_rpmsg.rst >> new file mode 100644 >> index 000000000000..fc1d3fba73c5 >> --- /dev/null >> +++ b/Documentation/serial/tty_rpmsg.rst >> @@ -0,0 +1,45 @@ >> +.. SPDX-License-Identifier: GPL-2.0 >> + >> +============= >> +The rpmsg TTY >> +============= >> + >> +The rpmsg tty driver implements serial communication on the RPMsg bus to makes possible for user-space programs to send and receive rpmsg messages as a standard tty protocol. > > Can you wrap your lines properly for this file? My apologize for this, I've been relying a little too much on the checkpatch tool here. Thanks for the review, Arnaud > > thanks, > > greg k-h >
WARNING: multiple messages have this Message-ID (diff)
From: Arnaud POULIQUEN <arnaud.pouliquen@st.com> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Ohad Ben-Cohen <ohad@wizery.com>, Bjorn Andersson <bjorn.andersson@linaro.org>, Jiri Slaby <jslaby@suse.com>, <linux-kernel@vger.kernel.org>, <linux-remoteproc@vger.kernel.org>, Mathieu Poirier <mathieu.poirier@linaro.org>, Suman Anna <s-anna@ti.com>, Fabien DESSENNE <fabien.dessenne@st.com>, <linux-stm32@st-md-mailman.stormreply.com>, Alan Cox <gnomes@lxorguk.ukuu.org.uk>, xiang xiao <xiaoxiang781216@gmail.com> Subject: Re: [PATCH v7 2/2] tty: add rpmsg driver Date: Wed, 25 Mar 2020 12:34:25 +0100 [thread overview] Message-ID: <426f24cb-025b-f497-e9dc-9823181c4056@st.com> (raw) In-Reply-To: <20200324171806.GB2522961@kroah.com> On 3/24/20 6:18 PM, Greg Kroah-Hartman wrote: > On Tue, Mar 24, 2020 at 06:04:07PM +0100, Arnaud Pouliquen wrote: >> This driver exposes a standard TTY interface on top of the rpmsg >> framework through a rpmsg service. >> >> This driver supports multi-instances, offering a /dev/ttyRPMSGx entry >> per rpmsg endpoint. >> >> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@st.com> >> --- >> Documentation/serial/tty_rpmsg.rst | 45 ++++ >> drivers/tty/Kconfig | 9 + >> drivers/tty/Makefile | 1 + >> drivers/tty/rpmsg_tty.c | 417 +++++++++++++++++++++++++++++ >> 4 files changed, 472 insertions(+) >> create mode 100644 Documentation/serial/tty_rpmsg.rst >> create mode 100644 drivers/tty/rpmsg_tty.c >> >> diff --git a/Documentation/serial/tty_rpmsg.rst b/Documentation/serial/tty_rpmsg.rst >> new file mode 100644 >> index 000000000000..fc1d3fba73c5 >> --- /dev/null >> +++ b/Documentation/serial/tty_rpmsg.rst >> @@ -0,0 +1,45 @@ >> +.. SPDX-License-Identifier: GPL-2.0 >> + >> +============= >> +The rpmsg TTY >> +============= >> + >> +The rpmsg tty driver implements serial communication on the RPMsg bus to makes possible for user-space programs to send and receive rpmsg messages as a standard tty protocol. > > Can you wrap your lines properly for this file? My apologize for this, I've been relying a little too much on the checkpatch tool here. Thanks for the review, Arnaud > > thanks, > > greg k-h >
next prev parent reply other threads:[~2020-03-25 11:34 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-24 17:04 [PATCH v7 0/2] Add rpmsg tty driver Arnaud Pouliquen 2020-03-24 17:04 ` Arnaud Pouliquen 2020-03-24 17:04 ` [PATCH v7 1/2] rpmsg: core: add API to get MTU Arnaud Pouliquen 2020-03-24 17:04 ` Arnaud Pouliquen 2020-03-31 17:36 ` Mathieu Poirier 2020-04-01 6:28 ` Jiri Slaby 2020-04-01 6:29 ` Jiri Slaby 2020-04-01 11:34 ` Arnaud POULIQUEN 2020-04-01 11:34 ` Arnaud POULIQUEN 2020-03-24 17:04 ` [PATCH v7 2/2] tty: add rpmsg driver Arnaud Pouliquen 2020-03-24 17:04 ` Arnaud Pouliquen 2020-03-24 17:18 ` Greg Kroah-Hartman 2020-03-25 11:34 ` Arnaud POULIQUEN [this message] 2020-03-25 11:34 ` Arnaud POULIQUEN 2020-03-24 17:23 ` Joe Perches 2020-03-25 11:36 ` Arnaud POULIQUEN 2020-03-25 11:36 ` Arnaud POULIQUEN 2020-03-24 17:44 ` Randy Dunlap 2020-03-25 8:10 ` Jiri Slaby 2020-03-25 11:39 ` Arnaud POULIQUEN 2020-03-25 11:39 ` Arnaud POULIQUEN 2020-03-24 20:52 ` Bjorn Andersson 2020-03-24 20:52 ` Bjorn Andersson 2020-03-25 16:57 ` Arnaud POULIQUEN 2020-03-25 16:57 ` Arnaud POULIQUEN 2020-04-06 14:18 ` Arnaud POULIQUEN 2020-04-06 14:18 ` Arnaud POULIQUEN 2020-05-06 2:54 ` Bjorn Andersson 2020-05-06 10:21 ` Arnaud POULIQUEN 2020-03-25 8:45 ` Jiri Slaby 2020-03-25 13:15 ` Arnaud POULIQUEN 2020-03-25 13:15 ` Arnaud POULIQUEN 2020-03-25 13:31 ` Jiri Slaby 2020-03-26 0:01 ` Joe Perches 2020-03-26 6:38 ` Jiri Slaby 2020-03-26 10:59 ` Arnaud POULIQUEN 2020-03-26 10:59 ` Arnaud POULIQUEN 2020-03-26 12:31 ` Jiri Slaby 2020-03-26 11:40 ` Arnaud POULIQUEN 2020-03-26 11:40 ` Arnaud POULIQUEN 2020-03-26 11:45 ` Jiri Slaby 2020-04-01 18:06 ` Mathieu Poirier 2020-04-02 15:25 ` Arnaud POULIQUEN 2020-04-02 15:25 ` Arnaud POULIQUEN 2020-04-03 20:18 ` Mathieu Poirier 2020-07-15 16:06 ` [PATCH v7 0/2] Add rpmsg tty driver Arnaud POULIQUEN
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=426f24cb-025b-f497-e9dc-9823181c4056@st.com \ --to=arnaud.pouliquen@st.com \ --cc=bjorn.andersson@linaro.org \ --cc=fabien.dessenne@st.com \ --cc=gnomes@lxorguk.ukuu.org.uk \ --cc=gregkh@linuxfoundation.org \ --cc=jslaby@suse.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-remoteproc@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=mathieu.poirier@linaro.org \ --cc=ohad@wizery.com \ --cc=s-anna@ti.com \ --cc=xiaoxiang781216@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.