Re: [PATCH v4 00/68] clk: Make determine_rate mandatory for muxes

From: Stephen Boyd <sboyd@kernel.org>
To: Maxime Ripard <maxime@cerno.tech>,
	Michael Turquette <mturquette@baylibre.com>
Cc: "Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Peng Fan" <peng.fan@nxp.com>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Sekhar Nori" <nsekhar@ti.com>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	dri-devel@lists.freedesktop.org,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Paul Cercueil" <paul@crapouillou.net>,
	"Max Filippov" <jcmvbkbc@gmail.com>,
	"Prashant Gaikwad" <pgaikwad@nvidia.com>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	linux-phy@lists.infradead.org, linux-clk@vger.kernel.org,
	"Abel Vesa" <abelvesa@kernel.org>,
	"Kishon Vijay Abraham I" <kishon@kernel.org>,
	"Samuel Holland" <samuel@sholland.org>,
	"Chunyan Zhang" <zhang.lyra@gmail.com>,
	"Takashi Iwai" <tiwai@suse.com>, "Vinod Koul" <vkoul@kernel.org>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	"Chen-Yu Tsai" <wens@csie.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	"Chen-Yu Tsai" <wenst@chromium.org>,
	"Orson Zhai" <orsonzhai@gmail.com>,
	"Ulf Hansson" <ulf.hansson@linaro.org>,
	linux-mips@vger.kernel.org,
	"Luca Ceresoli" <luca.ceresoli@bootlin.com>,
	linux-sunxi@lists.linux.dev,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	linux-rtc@vger.kernel.org,
	"Charles Keepax" <ckeepax@opensource.cirrus.com>,
	"David Lechner" <david@lechnology.com>,
	"Pawel Moll" <pawel.moll@arm.com>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Nicolas Ferre" <nicolas.ferre@microchip.com>,
	linux-actions@lists.infradead.org,
	"Markus Schneider-Pargmann" <msp@baylibre.com>,
	"Richard Fitzgerald" <rf@opensource.cirrus.com>,
	"Mark Brown" <broonie@kernel.org>,
	linux-mediatek@lists.infradead.org,
	"Maxime Ripard" <maxime@cerno.tech>,
	"Baolin Wang" <baolin.wang@linux.alibaba.com>,
	linux-tegra@vger.kernel.org,
	"Mikko Perttunen" <mperttunen@nvidia.com>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	linux-arm-kernel@lists.infradead.org,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Alessandro Zummo" <a.zummo@towertech.it>,
	patches@opensource.cirrus.com,
	"Peter De Schrijver" <pdeschrijver@nvidia.com>,
	linux-stm32@st-md-mailman.stormreply.com,
	"Liam Girdw ood" <lgirdwood@gmail.com>,
	"Claudiu Beznea" <claudiu.beznea@microchip.com>,
	linux-renesas-soc@vger.kernel.org,
	"Dinh Nguyen" <dinguyen@kernel.org>,
	"Miles Chen" <miles.chen@mediatek.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Liam Beguin" <liambeguin@gmail.com>,
	alsa-devel@alsa-project.org, "Shawn Guo" <shawnguo@kernel.org>,
	"Andreas Färber" <afaerber@suse.de>
Subject: Re: [PATCH v4 00/68] clk: Make determine_rate mandatory for muxes
Date: Thu, 08 Jun 2023 18:49:28 -0700	[thread overview]
Message-ID: <431d1ae3993d1fc78decbcd065442f29.sboyd@kernel.org> (raw)
In-Reply-To: <20221018-clk-range-checks-fixes-v4-0-971d5077e7d2@cerno.tech>

Quoting Maxime Ripard (2023-05-05 04:25:02)
> Hi,
> 
> This is a follow-up to a previous series that was printing a warning
> when a mux has a set_parent implementation but is missing
> determine_rate().
> 
> The rationale is that set_parent() is very likely to be useful when
> changing the rate, but it's determine_rate() that takes the parenting
> decision. If we're missing it, then the current parent is always going
> to be used, and thus set_parent() will not be used. The only exception
> being a direct call to clk_set_parent(), but those are fairly rare
> compared to clk_set_rate().
> 
> Stephen then asked to promote the warning to an error, and to fix up all
> the muxes that are in that situation first. So here it is :)
> 

I've applied this to clk-next after squashing in an export. Thanks for
taking this on.

I'll have to monitor for wreckage with any in-flight drivers. I suspect
I'll have to take out the last commit, but maybe we can just let those
in-flight drivers get fixed up later.