Re: [PATCH] can: don't count arbitration lose as an error - Marc Kleine-Budde

From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Jeroen Hofstee <jhofstee@victronenergy.com>, linux-can@vger.kernel.org
Cc: Oliver Hartkopp <socketcan@hartkopp.net>,
	Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@siol.net>,
	"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
	"moderated list:ARM/Allwinner sunXi SoC support" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] can: don't count arbitration lose as an error
Date: Fri, 27 Nov 2020 11:30:15 +0100	[thread overview]
Message-ID: <434167b4-c2df-02bf-8a9c-2d4716c5435f@pengutronix.de> (raw)
In-Reply-To: <20201127095941.21609-1-jhofstee@victronenergy.com>

[-- Attachment #1.1: Type: text/plain, Size: 1271 bytes --]

On 11/27/20 10:59 AM, Jeroen Hofstee wrote:
> Losing arbitration is normal in a CAN-bus network, it means that a
> higher priority frame is being send and the pending message will be
> retried later. Hence most driver only increment arbitration_lost, but
> the sja1000 and sun4i driver also incremeant tx_error, causing errors
> to be reported on a normal functioning CAN-bus. So stop counting them
> as errors.

Sounds plausible.

> For completeness, the Kvaser USB hybra also increments the tx_error
> on arbitration lose, but it does so in single shot. Since in that
> case the message is not retried, that behaviour is kept.

You mean only in one shot mode? What about one shot mode on the sja1000 cores?

> Signed-off-by: Jeroen Hofstee <jhofstee@victronenergy.com>

I've split this into two patches, and added Fixes: lines, and pushed this for
now to linux-can/sja1000.

https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git/log/?h=sja1000

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]