From: Christophe JAILLET <christophe.jaillet@wanadoo.fr> To: Matthias Brugger <matthias.bgg@gmail.com>, broonie@kernel.org, gregkh@linuxfoundation.org, neil@brown.name, blogic@openwrt.org Cc: linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 4/4] spi: mt7621: Remove 'clk' from 'struct mt7621_spi' Date: Mon, 29 Aug 2022 19:23:06 +0200 [thread overview] Message-ID: <444669a0-6328-0bc4-8073-9ec4baaf893e@wanadoo.fr> (raw) In-Reply-To: <a8c87417-f37e-7c7a-a4a4-c5a01118e7a8@gmail.com> Le 29/08/2022 à 13:18, Matthias Brugger a écrit : > > > On 27/08/2022 13:42, Christophe JAILLET wrote: >> The 'clk' field in 'struct mt7621_spi' is useless, remove it. >> >> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > > IMHO should be part of patch 2/4. Ok, I'll send a v2 of the serie to merge patch 2 & 4. CJ > > Regards, > Matthias > >> --- >> drivers/spi/spi-mt7621.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/spi/spi-mt7621.c b/drivers/spi/spi-mt7621.c >> index 114f98dcae5e..c4cc8e2f85e2 100644 >> --- a/drivers/spi/spi-mt7621.c >> +++ b/drivers/spi/spi-mt7621.c >> @@ -55,7 +55,6 @@ struct mt7621_spi { >> void __iomem *base; >> unsigned int sys_freq; >> unsigned int speed; >> - struct clk *clk; >> int pending_write; >> }; >> @@ -361,9 +360,8 @@ static int mt7621_spi_probe(struct platform_device >> *pdev) >> rs = spi_controller_get_devdata(master); >> rs->base = base; >> - rs->clk = clk; >> rs->master = master; >> - rs->sys_freq = clk_get_rate(rs->clk); >> + rs->sys_freq = clk_get_rate(clk); >> rs->pending_write = 0; >> dev_info(&pdev->dev, "sys_freq: %u\n", rs->sys_freq);
WARNING: multiple messages have this Message-ID (diff)
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr> To: Matthias Brugger <matthias.bgg@gmail.com>, broonie@kernel.org, gregkh@linuxfoundation.org, neil@brown.name, blogic@openwrt.org Cc: linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 4/4] spi: mt7621: Remove 'clk' from 'struct mt7621_spi' Date: Mon, 29 Aug 2022 19:23:06 +0200 [thread overview] Message-ID: <444669a0-6328-0bc4-8073-9ec4baaf893e@wanadoo.fr> (raw) In-Reply-To: <a8c87417-f37e-7c7a-a4a4-c5a01118e7a8@gmail.com> Le 29/08/2022 à 13:18, Matthias Brugger a écrit : > > > On 27/08/2022 13:42, Christophe JAILLET wrote: >> The 'clk' field in 'struct mt7621_spi' is useless, remove it. >> >> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > > IMHO should be part of patch 2/4. Ok, I'll send a v2 of the serie to merge patch 2 & 4. CJ > > Regards, > Matthias > >> --- >> drivers/spi/spi-mt7621.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/spi/spi-mt7621.c b/drivers/spi/spi-mt7621.c >> index 114f98dcae5e..c4cc8e2f85e2 100644 >> --- a/drivers/spi/spi-mt7621.c >> +++ b/drivers/spi/spi-mt7621.c >> @@ -55,7 +55,6 @@ struct mt7621_spi { >> void __iomem *base; >> unsigned int sys_freq; >> unsigned int speed; >> - struct clk *clk; >> int pending_write; >> }; >> @@ -361,9 +360,8 @@ static int mt7621_spi_probe(struct platform_device >> *pdev) >> rs = spi_controller_get_devdata(master); >> rs->base = base; >> - rs->clk = clk; >> rs->master = master; >> - rs->sys_freq = clk_get_rate(rs->clk); >> + rs->sys_freq = clk_get_rate(clk); >> rs->pending_write = 0; >> dev_info(&pdev->dev, "sys_freq: %u\n", rs->sys_freq); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-29 17:23 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-27 11:41 [PATCH 0/4] spi: mt7621: Fix an erroneous message + clean-ups Christophe JAILLET 2022-08-27 11:41 ` Christophe JAILLET 2022-08-27 11:42 ` [PATCH 1/4] spi: mt7621: Fix an error message in mt7621_spi_probe() Christophe JAILLET 2022-08-27 11:42 ` Christophe JAILLET 2022-08-29 11:07 ` Matthias Brugger 2022-08-29 11:07 ` Matthias Brugger 2022-08-30 9:46 ` AngeloGioacchino Del Regno 2022-08-30 9:46 ` AngeloGioacchino Del Regno 2022-08-27 11:42 ` [PATCH 2/4] spi: mt7621: Use the devm_clk_get_enabled() helper to simplify error handling Christophe JAILLET 2022-08-27 11:42 ` Christophe JAILLET 2022-08-29 11:14 ` Matthias Brugger 2022-08-29 11:14 ` Matthias Brugger 2022-08-30 9:46 ` AngeloGioacchino Del Regno 2022-08-30 9:46 ` AngeloGioacchino Del Regno 2022-08-27 11:42 ` [PATCH 3/4] spi: mt7621: Use devm_spi_register_controller() Christophe JAILLET 2022-08-27 11:42 ` Christophe JAILLET 2022-08-29 11:16 ` Matthias Brugger 2022-08-29 11:16 ` Matthias Brugger 2022-08-27 11:42 ` [PATCH 4/4] spi: mt7621: Remove 'clk' from 'struct mt7621_spi' Christophe JAILLET 2022-08-27 11:42 ` Christophe JAILLET 2022-08-29 11:18 ` Matthias Brugger 2022-08-29 11:18 ` Matthias Brugger 2022-08-29 17:23 ` Christophe JAILLET [this message] 2022-08-29 17:23 ` Christophe JAILLET 2022-08-29 20:54 ` [PATCH 0/4] spi: mt7621: Fix an erroneous message + clean-ups Mark Brown 2022-08-29 20:54 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=444669a0-6328-0bc4-8073-9ec4baaf893e@wanadoo.fr \ --to=christophe.jaillet@wanadoo.fr \ --cc=blogic@openwrt.org \ --cc=broonie@kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-spi@vger.kernel.org \ --cc=matthias.bgg@gmail.com \ --cc=neil@brown.name \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.