Re: [PATCH 12/12] drm: rockchip: Add VOP2 driver

From: Dan Johansen <strit@manjaro.org>
To: linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 12/12] drm: rockchip: Add VOP2 driver
Date: Wed, 17 Nov 2021 19:38:32 +0100	[thread overview]
Message-ID: <44b7f906-b1e5-c998-4dcf-8eb3b326ce9b@manjaro.org> (raw)
In-Reply-To: <7182753.rMVL1d3Icj@archbook>

Den 17.11.2021 kl. 19.05 skrev Nicolas Frattaroli:
> On Mittwoch, 17. November 2021 15:33:47 CET Sascha Hauer wrote:
>> The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568.
>> It replaces the VOP unit found in the older Rockchip SoCs.
>>
>> This driver has been derived from the downstream Rockchip Kernel and
>> heavily modified:
>>
>> - All nonstandard DRM properties have been removed
>> - dropped struct vop2_plane_state and pass around less data between
>>    functions
>> - Dropped all DRM_FORMAT_* not known on upstream
>> - rework register access to get rid of excessively used macros
>>
>> The driver is tested with HDMI and MIPI-DSI display on a RK3568-EVB
>> board. Overlay support is tested with the modetest utility. AFBC support
>> is still present in the driver, but currently untested due to the lack
>> of suitable image sources. Also the driver has been tested with weston
>> using pixman and (yet to be upstreamed) panfrost driver support.
>>
>> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
>> ---
> Hi Sascha,
>
> thank you very much for your work on this! I gave it a try tonight,
> and unfortunately it appears to currently always attempt to use
> 1920x1080p60 as the mode regardless of the monitor. For example,
> on an old 720p monitor I had laying around:
>
> 	[  225.732342] rockchip-drm display-subsystem: [drm] Update mode to 1920x1080p60, type: 11 for vp0, output 0x00000800  HDMI0
>
> This results in a broken picture (all white with occasional glitches).
> Somebody else observed the same behaviour on a 1440p monitor.

Yes, my 1440p Dell screen showed white noise picture and so does my Sony 
Bravia 1080p TV, but that is likely not running at 60 hertz.

In any case, nice work as I've heard it works on regular 1080p monitors.

>
> Thanks,
> Nicolas Frattaroli
>
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
-- 
Kind regards
*Dan Johansen*
Project lead of the *Manjaro ARM* project
Manjaro-ARM <https://manjaro.org>

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip