From: Kever Yang <kever.yang@rock-chips.com>
To: Sascha Hauer <s.hauer@pengutronix.de>, dri-devel@lists.freedesktop.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
kernel@pengutronix.de,
"Benjamin Gaignard" <benjamin.gaignard@collabora.com>,
"Michael Riesch" <michael.riesch@wolfvision.net>,
"Sandy Huang" <hjc@rock-chips.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Peter Geis" <pgwipeout@gmail.com>, 闫孝军 <andy.yan@rock-chips.com>
Subject: Re: [PATCH v1 00/12] drm/rockchip: RK356x VOP2 support
Date: Thu, 18 Nov 2021 09:27:10 +0800 [thread overview]
Message-ID: <3bbf42f3-bd9c-ed66-e421-8d78fbeb22ad@rock-chips.com> (raw)
In-Reply-To: <20211117143347.314294-1-s.hauer@pengutronix.de>
Hi Sascha Hauer,
On 2021/11/17 下午10:33, Sascha Hauer wrote:
> This series adds initial graphics support for the Rockchip RK356[68]
> SoCs. Graphics support is based around the VOP2 controller which
> replaces the VOP controller found on earlier Rockchip SoCs. The driver
> has been tested with HDMI support included in this series and MIPI-DSI
> which is not included because it needs some more work. The driver is
> taken from the downstream Rockchip kernel
Yes, you do know this is from Rockchip kernel.
Could you point me out where is the information about original author
in your commit?
> and heavily polished, most non
> standard features have been removed for now.
I don't agree with this, we do believe you have do some clean up to meet
the requirement
of upstream, but all the framework and feature implement are from
Rockchip engineer,
we have made a great effort to make everything work which block us to
upstream this driver for now.
NAK for this series.
- Kever
WARNING: multiple messages have this Message-ID (diff)
From: Kever Yang <kever.yang@rock-chips.com>
To: Sascha Hauer <s.hauer@pengutronix.de>, dri-devel@lists.freedesktop.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
kernel@pengutronix.de,
"Benjamin Gaignard" <benjamin.gaignard@collabora.com>,
"Michael Riesch" <michael.riesch@wolfvision.net>,
"Sandy Huang" <hjc@rock-chips.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Peter Geis" <pgwipeout@gmail.com>, 闫孝军 <andy.yan@rock-chips.com>
Subject: Re: [PATCH v1 00/12] drm/rockchip: RK356x VOP2 support
Date: Thu, 18 Nov 2021 09:27:10 +0800 [thread overview]
Message-ID: <3bbf42f3-bd9c-ed66-e421-8d78fbeb22ad@rock-chips.com> (raw)
In-Reply-To: <20211117143347.314294-1-s.hauer@pengutronix.de>
Hi Sascha Hauer,
On 2021/11/17 下午10:33, Sascha Hauer wrote:
> This series adds initial graphics support for the Rockchip RK356[68]
> SoCs. Graphics support is based around the VOP2 controller which
> replaces the VOP controller found on earlier Rockchip SoCs. The driver
> has been tested with HDMI support included in this series and MIPI-DSI
> which is not included because it needs some more work. The driver is
> taken from the downstream Rockchip kernel
Yes, you do know this is from Rockchip kernel.
Could you point me out where is the information about original author
in your commit?
> and heavily polished, most non
> standard features have been removed for now.
I don't agree with this, we do believe you have do some clean up to meet
the requirement
of upstream, but all the framework and feature implement are from
Rockchip engineer,
we have made a great effort to make everything work which block us to
upstream this driver for now.
NAK for this series.
- Kever
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Kever Yang <kever.yang@rock-chips.com>
To: Sascha Hauer <s.hauer@pengutronix.de>, dri-devel@lists.freedesktop.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
kernel@pengutronix.de,
"Benjamin Gaignard" <benjamin.gaignard@collabora.com>,
"Michael Riesch" <michael.riesch@wolfvision.net>,
"Sandy Huang" <hjc@rock-chips.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Peter Geis" <pgwipeout@gmail.com>, 闫孝军 <andy.yan@rock-chips.com>
Subject: Re: [PATCH v1 00/12] drm/rockchip: RK356x VOP2 support
Date: Thu, 18 Nov 2021 09:27:10 +0800 [thread overview]
Message-ID: <3bbf42f3-bd9c-ed66-e421-8d78fbeb22ad@rock-chips.com> (raw)
In-Reply-To: <20211117143347.314294-1-s.hauer@pengutronix.de>
Hi Sascha Hauer,
On 2021/11/17 下午10:33, Sascha Hauer wrote:
> This series adds initial graphics support for the Rockchip RK356[68]
> SoCs. Graphics support is based around the VOP2 controller which
> replaces the VOP controller found on earlier Rockchip SoCs. The driver
> has been tested with HDMI support included in this series and MIPI-DSI
> which is not included because it needs some more work. The driver is
> taken from the downstream Rockchip kernel
Yes, you do know this is from Rockchip kernel.
Could you point me out where is the information about original author
in your commit?
> and heavily polished, most non
> standard features have been removed for now.
I don't agree with this, we do believe you have do some clean up to meet
the requirement
of upstream, but all the framework and feature implement are from
Rockchip engineer,
we have made a great effort to make everything work which block us to
upstream this driver for now.
NAK for this series.
- Kever
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Kever Yang <kever.yang@rock-chips.com>
To: Sascha Hauer <s.hauer@pengutronix.de>, dri-devel@lists.freedesktop.org
Cc: devicetree@vger.kernel.org,
"Benjamin Gaignard" <benjamin.gaignard@collabora.com>,
"Sandy Huang" <hjc@rock-chips.com>,
linux-rockchip@lists.infradead.org,
"Michael Riesch" <michael.riesch@wolfvision.net>,
kernel@pengutronix.de, 闫孝军 <andy.yan@rock-chips.com>,
"Peter Geis" <pgwipeout@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 00/12] drm/rockchip: RK356x VOP2 support
Date: Thu, 18 Nov 2021 09:27:10 +0800 [thread overview]
Message-ID: <3bbf42f3-bd9c-ed66-e421-8d78fbeb22ad@rock-chips.com> (raw)
In-Reply-To: <20211117143347.314294-1-s.hauer@pengutronix.de>
Hi Sascha Hauer,
On 2021/11/17 下午10:33, Sascha Hauer wrote:
> This series adds initial graphics support for the Rockchip RK356[68]
> SoCs. Graphics support is based around the VOP2 controller which
> replaces the VOP controller found on earlier Rockchip SoCs. The driver
> has been tested with HDMI support included in this series and MIPI-DSI
> which is not included because it needs some more work. The driver is
> taken from the downstream Rockchip kernel
Yes, you do know this is from Rockchip kernel.
Could you point me out where is the information about original author
in your commit?
> and heavily polished, most non
> standard features have been removed for now.
I don't agree with this, we do believe you have do some clean up to meet
the requirement
of upstream, but all the framework and feature implement are from
Rockchip engineer,
we have made a great effort to make everything work which block us to
upstream this driver for now.
NAK for this series.
- Kever
next prev parent reply other threads:[~2021-11-18 1:27 UTC|newest]
Thread overview: 201+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 14:33 [PATCH v1 00/12] drm/rockchip: RK356x VOP2 support Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-17 14:33 ` [PATCH 01/12] dt-bindings: display: rockchip: Add compatible for rk3568 HDMI Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-27 15:07 ` Heiko Stuebner
2021-11-27 15:07 ` Heiko Stuebner
2021-11-27 15:07 ` Heiko Stuebner
2021-11-27 15:07 ` Heiko Stuebner
2021-11-17 14:33 ` [PATCH 02/12] drm/rockchip: dw_hdmi: Do not leave clock enabled in error case Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-17 14:33 ` [PATCH 03/12] drm/rockchip: dw_hdmi: add rk3568 support Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-17 14:33 ` [PATCH 04/12] drm/rockchip: dw_hdmi: add regulator support Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-29 22:46 ` Rob Herring
2021-11-29 22:46 ` Rob Herring
2021-11-29 22:46 ` Rob Herring
2021-11-29 22:46 ` Rob Herring
2021-12-07 17:01 ` Robin Murphy
2021-12-07 17:01 ` Robin Murphy
2021-12-07 17:01 ` Robin Murphy
2021-12-07 17:01 ` Robin Murphy
2021-11-17 14:33 ` [PATCH 05/12] of: graph: Allow disabled endpoints Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-17 14:33 ` [PATCH 06/12] dt-bindings: " Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-17 14:33 ` [PATCH 07/12] dt-bindings: display: rockchip: Add binding for VOP2 Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-17 16:10 ` Rob Herring
2021-11-17 16:10 ` Rob Herring
2021-11-17 16:10 ` Rob Herring
2021-11-17 16:10 ` Rob Herring
2021-11-17 14:33 ` [PATCH 08/12] arm64: dts: rockchip: rk356x: Add VOP2 nodes Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-25 20:25 ` Johan Jonker
2021-11-25 20:25 ` Johan Jonker
2021-11-25 20:25 ` Johan Jonker
2021-11-25 20:25 ` Johan Jonker
2021-11-26 7:40 ` Sascha Hauer
2021-11-26 7:40 ` Sascha Hauer
2021-11-26 7:40 ` Sascha Hauer
2021-11-26 7:40 ` Sascha Hauer
2021-11-26 8:15 ` Heiko Stübner
2021-11-26 8:15 ` Heiko Stübner
2021-11-26 8:15 ` Heiko Stübner
2021-11-26 8:15 ` Heiko Stübner
2021-11-17 14:33 ` [PATCH 09/12] arm64: dts: rockchip: rk356x: Add HDMI nodes Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-17 15:13 ` Rob Herring
2021-11-17 15:13 ` Rob Herring
2021-11-17 15:13 ` Rob Herring
2021-11-17 15:13 ` Rob Herring
2021-12-01 16:04 ` Sascha Hauer
2021-12-01 16:04 ` Sascha Hauer
2021-12-01 16:04 ` Sascha Hauer
2021-12-01 16:04 ` Sascha Hauer
2021-11-17 14:33 ` [PATCH 10/12] arm64: dts: rockchip: rk3568-evb: Enable VOP2 and hdmi Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-17 15:19 ` Rob Herring
2021-11-17 15:19 ` Rob Herring
2021-11-17 15:19 ` Rob Herring
2021-11-17 15:19 ` Rob Herring
2021-12-02 15:34 ` Sascha Hauer
2021-12-02 15:34 ` Sascha Hauer
2021-12-02 15:34 ` Sascha Hauer
2021-12-02 15:34 ` Sascha Hauer
2021-12-02 15:41 ` Heiko Stübner
2021-12-02 15:41 ` Heiko Stübner
2021-12-02 15:41 ` Heiko Stübner
2021-12-02 15:41 ` Heiko Stübner
2021-12-02 16:09 ` Sascha Hauer
2021-12-02 16:09 ` Sascha Hauer
2021-12-02 16:09 ` Sascha Hauer
2021-12-02 16:09 ` Sascha Hauer
2021-11-17 15:20 ` Michael Riesch
2021-11-17 15:20 ` Michael Riesch
2021-11-17 15:20 ` Michael Riesch
2021-11-17 15:20 ` Michael Riesch
2021-11-17 15:44 ` [PATCH] arm64: dts: rockchip: enable vop2 and hdmi tx on quartz64a Michael Riesch
2021-11-17 15:44 ` Michael Riesch
2021-11-17 15:44 ` Michael Riesch
2021-11-17 15:44 ` Michael Riesch
2021-11-25 19:44 ` Johan Jonker
2021-11-25 19:44 ` Johan Jonker
2021-11-25 19:44 ` Johan Jonker
2021-11-25 19:44 ` Johan Jonker
2021-11-17 14:33 ` [PATCH 11/12] drm/rockchip: Make VOP driver optional Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-17 14:40 ` Heiko Stübner
2021-11-17 14:40 ` Heiko Stübner
2021-11-17 14:40 ` Heiko Stübner
2021-11-17 14:40 ` Heiko Stübner
2021-11-17 14:50 ` Sascha Hauer
2021-11-17 14:50 ` Sascha Hauer
2021-11-17 14:50 ` Sascha Hauer
2021-11-17 14:50 ` Sascha Hauer
2021-11-17 15:16 ` Heiko Stübner
2021-11-17 15:16 ` Heiko Stübner
2021-11-17 15:16 ` Heiko Stübner
2021-11-17 15:16 ` Heiko Stübner
2021-11-17 14:33 ` [PATCH 12/12] drm: rockchip: Add VOP2 driver Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-17 14:33 ` Sascha Hauer
2021-11-17 18:05 ` Nicolas Frattaroli
2021-11-17 18:05 ` Nicolas Frattaroli
2021-11-17 18:05 ` Nicolas Frattaroli
2021-11-17 18:05 ` Nicolas Frattaroli
2021-11-17 18:38 ` Dan Johansen
2021-11-17 19:45 ` Sascha Hauer
2021-11-17 19:45 ` Sascha Hauer
2021-11-17 19:45 ` Sascha Hauer
2021-11-17 19:45 ` Sascha Hauer
2021-11-26 6:44 ` kernel test robot
2021-11-26 6:44 ` kernel test robot
2021-11-26 6:44 ` kernel test robot
2021-11-26 6:44 ` kernel test robot
2021-11-26 6:44 ` kernel test robot
2021-11-17 14:54 ` [PATCH v1 00/12] drm/rockchip: RK356x VOP2 support Rob Herring
2021-11-17 14:54 ` Rob Herring
2021-11-17 14:54 ` Rob Herring
2021-11-17 14:54 ` Rob Herring
2021-11-17 15:41 ` Sascha Hauer
2021-11-17 15:41 ` Sascha Hauer
2021-11-17 15:41 ` Sascha Hauer
2021-11-17 15:41 ` Sascha Hauer
2021-11-18 1:27 ` Kever Yang [this message]
2021-11-18 1:27 ` Kever Yang
2021-11-18 1:27 ` Kever Yang
2021-11-18 1:27 ` Kever Yang
2021-11-18 9:26 ` Heiko Stübner
2021-11-18 9:26 ` Heiko Stübner
2021-11-18 9:26 ` Heiko Stübner
2021-11-18 9:26 ` Heiko Stübner
2021-11-18 9:53 ` Daniel Stone
2021-11-18 9:53 ` Daniel Stone
2021-11-18 9:53 ` Daniel Stone
2021-11-18 9:53 ` Daniel Stone
2021-11-18 10:50 ` Kever Yang
2021-11-18 10:50 ` Kever Yang
2021-11-18 10:50 ` Kever Yang
2021-11-18 10:50 ` Kever Yang
2021-11-18 11:08 ` Michael Riesch
2021-11-18 11:08 ` Michael Riesch
2021-11-18 11:08 ` Michael Riesch
2021-11-18 11:08 ` Michael Riesch
2021-11-18 12:07 ` Daniel Stone
2021-11-18 12:07 ` Daniel Stone
2021-11-18 12:07 ` Daniel Stone
2021-11-18 12:07 ` Daniel Stone
2021-11-18 13:14 ` Andy Yan
2021-11-18 13:14 ` Andy Yan
2021-11-18 13:14 ` Andy Yan
2021-11-18 13:14 ` Andy Yan
2021-11-18 13:24 ` Daniel Stone
2021-11-18 13:24 ` Daniel Stone
2021-11-18 13:24 ` Daniel Stone
2021-11-18 13:24 ` Daniel Stone
2021-11-18 10:03 ` Sascha Hauer
2021-11-18 10:03 ` Sascha Hauer
2021-11-18 10:03 ` Sascha Hauer
2021-11-18 10:03 ` Sascha Hauer
2021-11-21 23:18 ` Alex Bee
2021-11-21 23:18 ` Alex Bee
2021-11-21 23:18 ` Alex Bee
2021-11-21 23:18 ` Alex Bee
2021-11-22 8:10 ` Sascha Hauer
2021-11-22 8:10 ` Sascha Hauer
2021-11-22 8:10 ` Sascha Hauer
2021-11-22 8:10 ` Sascha Hauer
2021-11-22 17:47 ` Alex Bee
2021-11-22 17:47 ` Alex Bee
2021-11-22 17:47 ` Alex Bee
2021-11-22 17:47 ` Alex Bee
2021-11-22 19:21 ` Robin Murphy
2021-11-22 19:21 ` Robin Murphy
2021-11-22 19:21 ` Robin Murphy
2021-11-22 19:21 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bbf42f3-bd9c-ed66-e421-8d78fbeb22ad@rock-chips.com \
--to=kever.yang@rock-chips.com \
--cc=andy.yan@rock-chips.com \
--cc=benjamin.gaignard@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=michael.riesch@wolfvision.net \
--cc=pgwipeout@gmail.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.