From: Matthias Brugger <matthias.bgg@gmail.com>
To: Frank Wunderlich <linux@fw-web.de>, linux-mediatek@lists.infradead.org
Cc: Frank Wunderlich <frank-w@public-files.de>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Sean Wang <sean.wang@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org
Subject: Re: [RFC 1/3] dts64: mt7622: enable all pwm for bananapi r64
Date: Fri, 27 Nov 2020 17:07:21 +0100 [thread overview]
Message-ID: <4568d457-50d6-924f-c2ad-d6e508a543e4@gmail.com> (raw)
In-Reply-To: <20201016204019.2606-2-linux@fw-web.de>
On 16/10/2020 22:40, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> mt7622 only supports 6 pwm-channels so drop pwm7
>
> third pwm (pwm2) is inverted and connected to fan-socket
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
Patch 1 and 2 now pushed to v5.10-next/dts64
Thanks!
> ---
> .../boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
> index 1cc4dcb0008c..ad5b1592182d 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
> @@ -414,10 +414,15 @@ mux {
> };
> };
>
> - pwm7_pins: pwm1-2-pins {
> + pwm_pins: pwm-pins {
> mux {
> function = "pwm";
> - groups = "pwm_ch7_2";
> + groups = "pwm_ch1_0", /* mt7622_pwm_ch1_0_pins[] = { 51, }; */
> + "pwm_ch2_0", /* mt7622_pwm_ch2_0_pins[] = { 52, }; */
> + "pwm_ch3_2", /* mt7622_pwm_ch3_2_pins[] = { 97, }; */
> + "pwm_ch4_1", /* mt7622_pwm_ch4_1_pins[] = { 67, }; */
> + "pwm_ch5_0", /* mt7622_pwm_ch5_0_pins[] = { 68, }; */
> + "pwm_ch6_0"; /* mt7622_pwm_ch6_0_pins[] = { 69, }; */
> };
> };
>
> @@ -537,7 +542,7 @@ mux {
>
> &pwm {
> pinctrl-names = "default";
> - pinctrl-0 = <&pwm7_pins>;
> + pinctrl-0 = <&pwm_pins>;
> status = "okay";
> };
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Frank Wunderlich <linux@fw-web.de>, linux-mediatek@lists.infradead.org
Cc: devicetree@vger.kernel.org,
Frank Wunderlich <frank-w@public-files.de>,
Linus Walleij <linus.walleij@linaro.org>,
Sean Wang <sean.wang@kernel.org>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC 1/3] dts64: mt7622: enable all pwm for bananapi r64
Date: Fri, 27 Nov 2020 17:07:21 +0100 [thread overview]
Message-ID: <4568d457-50d6-924f-c2ad-d6e508a543e4@gmail.com> (raw)
In-Reply-To: <20201016204019.2606-2-linux@fw-web.de>
On 16/10/2020 22:40, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> mt7622 only supports 6 pwm-channels so drop pwm7
>
> third pwm (pwm2) is inverted and connected to fan-socket
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
Patch 1 and 2 now pushed to v5.10-next/dts64
Thanks!
> ---
> .../boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
> index 1cc4dcb0008c..ad5b1592182d 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
> @@ -414,10 +414,15 @@ mux {
> };
> };
>
> - pwm7_pins: pwm1-2-pins {
> + pwm_pins: pwm-pins {
> mux {
> function = "pwm";
> - groups = "pwm_ch7_2";
> + groups = "pwm_ch1_0", /* mt7622_pwm_ch1_0_pins[] = { 51, }; */
> + "pwm_ch2_0", /* mt7622_pwm_ch2_0_pins[] = { 52, }; */
> + "pwm_ch3_2", /* mt7622_pwm_ch3_2_pins[] = { 97, }; */
> + "pwm_ch4_1", /* mt7622_pwm_ch4_1_pins[] = { 67, }; */
> + "pwm_ch5_0", /* mt7622_pwm_ch5_0_pins[] = { 68, }; */
> + "pwm_ch6_0"; /* mt7622_pwm_ch6_0_pins[] = { 69, }; */
> };
> };
>
> @@ -537,7 +542,7 @@ mux {
>
> &pwm {
> pinctrl-names = "default";
> - pinctrl-0 = <&pwm7_pins>;
> + pinctrl-0 = <&pwm_pins>;
> status = "okay";
> };
>
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Frank Wunderlich <linux@fw-web.de>, linux-mediatek@lists.infradead.org
Cc: devicetree@vger.kernel.org,
Frank Wunderlich <frank-w@public-files.de>,
Linus Walleij <linus.walleij@linaro.org>,
Sean Wang <sean.wang@kernel.org>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC 1/3] dts64: mt7622: enable all pwm for bananapi r64
Date: Fri, 27 Nov 2020 17:07:21 +0100 [thread overview]
Message-ID: <4568d457-50d6-924f-c2ad-d6e508a543e4@gmail.com> (raw)
In-Reply-To: <20201016204019.2606-2-linux@fw-web.de>
On 16/10/2020 22:40, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> mt7622 only supports 6 pwm-channels so drop pwm7
>
> third pwm (pwm2) is inverted and connected to fan-socket
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
Patch 1 and 2 now pushed to v5.10-next/dts64
Thanks!
> ---
> .../boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
> index 1cc4dcb0008c..ad5b1592182d 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
> @@ -414,10 +414,15 @@ mux {
> };
> };
>
> - pwm7_pins: pwm1-2-pins {
> + pwm_pins: pwm-pins {
> mux {
> function = "pwm";
> - groups = "pwm_ch7_2";
> + groups = "pwm_ch1_0", /* mt7622_pwm_ch1_0_pins[] = { 51, }; */
> + "pwm_ch2_0", /* mt7622_pwm_ch2_0_pins[] = { 52, }; */
> + "pwm_ch3_2", /* mt7622_pwm_ch3_2_pins[] = { 97, }; */
> + "pwm_ch4_1", /* mt7622_pwm_ch4_1_pins[] = { 67, }; */
> + "pwm_ch5_0", /* mt7622_pwm_ch5_0_pins[] = { 68, }; */
> + "pwm_ch6_0"; /* mt7622_pwm_ch6_0_pins[] = { 69, }; */
> };
> };
>
> @@ -537,7 +542,7 @@ mux {
>
> &pwm {
> pinctrl-names = "default";
> - pinctrl-0 = <&pwm7_pins>;
> + pinctrl-0 = <&pwm_pins>;
> status = "okay";
> };
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-27 16:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 20:40 [RFC 0/3] add available pwm for bananapi-r64 Frank Wunderlich
2020-10-16 20:40 ` Frank Wunderlich
2020-10-16 20:40 ` Frank Wunderlich
2020-10-16 20:40 ` [RFC 1/3] dts64: mt7622: enable all pwm for bananapi r64 Frank Wunderlich
2020-10-16 20:40 ` Frank Wunderlich
2020-10-16 20:40 ` Frank Wunderlich
2020-11-27 16:07 ` Matthias Brugger [this message]
2020-11-27 16:07 ` Matthias Brugger
2020-11-27 16:07 ` Matthias Brugger
2020-10-16 20:40 ` [RFC 2/3] dts64: mt7622: disable spi1 and uart2 because pins are used by pwm Frank Wunderlich
2020-10-16 20:40 ` Frank Wunderlich
2020-10-16 20:40 ` Frank Wunderlich
2020-10-16 20:40 ` [RFC 3/3] pinctl: mt7622: drop pwm ch7 as mt7622 only has 6 channels Frank Wunderlich
2020-10-16 20:40 ` Frank Wunderlich
2020-10-16 20:40 ` Frank Wunderlich
2020-10-29 17:09 ` Linus Walleij
2020-10-29 17:09 ` Linus Walleij
2020-10-29 17:09 ` Linus Walleij
2020-10-30 18:36 ` Sean Wang
2020-10-30 18:36 ` Sean Wang
2020-10-30 18:36 ` Sean Wang
2020-11-06 13:40 ` Linus Walleij
2020-11-06 13:40 ` Linus Walleij
2020-11-06 13:40 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4568d457-50d6-924f-c2ad-d6e508a543e4@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=frank-w@public-files.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@fw-web.de \
--cc=robh+dt@kernel.org \
--cc=sean.wang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.