From: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Sjoerd Simons
<sjoerd.simons-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>,
arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] ARM: multi_v7_defconfig: Change RTC_DRV_HYM8563 to builtin
Date: Sat, 09 Jan 2016 20:33:51 +0100 [thread overview]
Message-ID: <4578616.QcQm44RoCq@phil> (raw)
In-Reply-To: <1452367683-11160-1-git-send-email-sjoerd.simons-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
Am Samstag, 9. Januar 2016, 20:28:02 schrieb Sjoerd Simons:
> Apart from providing an RTC the hym8563 chip on some rockchip boards
> (e.g. rock2 square and firefly) also provide the 32khz clock used by the
> SoCs thermal sensors.
>
> Switch the driver from a module to builtin such that the thermal
> protection can work even if modules aren't used/loaded.
>
> Signed-off-by: Sjoerd Simons <sjoerd.simons-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
Personally I'm ok with the reasoning for requiring rtc to be build in,
but I guess others might disagree. Nevertheless
Acked-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
and we'll let armsoc-people decide ;-) .
Ideally we would do the same for the rk808 rtc as well - as it is exactly
the same argument / case.
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: multi_v7_defconfig: Change RTC_DRV_HYM8563 to builtin
Date: Sat, 09 Jan 2016 20:33:51 +0100 [thread overview]
Message-ID: <4578616.QcQm44RoCq@phil> (raw)
In-Reply-To: <1452367683-11160-1-git-send-email-sjoerd.simons@collabora.co.uk>
Am Samstag, 9. Januar 2016, 20:28:02 schrieb Sjoerd Simons:
> Apart from providing an RTC the hym8563 chip on some rockchip boards
> (e.g. rock2 square and firefly) also provide the 32khz clock used by the
> SoCs thermal sensors.
>
> Switch the driver from a module to builtin such that the thermal
> protection can work even if modules aren't used/loaded.
>
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Personally I'm ok with the reasoning for requiring rtc to be build in,
but I guess others might disagree. Nevertheless
Acked-by: Heiko Stuebner <heiko@sntech.de>
and we'll let armsoc-people decide ;-) .
Ideally we would do the same for the rk808 rtc as well - as it is exactly
the same argument / case.
Heiko
next prev parent reply other threads:[~2016-01-09 19:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-09 19:28 [PATCH] ARM: multi_v7_defconfig: Change RTC_DRV_HYM8563 to builtin Sjoerd Simons
2016-01-09 19:28 ` Sjoerd Simons
[not found] ` <1452367683-11160-1-git-send-email-sjoerd.simons-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2016-01-09 19:33 ` Heiko Stuebner [this message]
2016-01-09 19:33 ` Heiko Stuebner
2016-01-09 22:45 ` Heiko Stuebner
2016-01-09 22:45 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4578616.QcQm44RoCq@phil \
--to=heiko-4mtyjxux2i+zqb+pc5nmwq@public.gmane.org \
--cc=arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=sjoerd.simons-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.