All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qu Wenruo <wqu@suse.com>
To: u-boot@lists.denx.de
Cc: marek.behun@nic.cz, linux-btrfs@vger.kernel.org,
	jnhuang95@gmail.com, linux-erofs@lists.ozlabs.org,
	trini@konsulko.com, joaomarcos.costa@bootlin.com,
	thomas.petazzoni@bootlin.com, miquel.raynal@bootlin.com
Subject: [PATCH v3 1/8] fs: fat: unexport file_fat_read_at()
Date: Mon, 15 Aug 2022 19:45:12 +0800	[thread overview]
Message-ID: <45a6f44305500b3f7f3d5488ae8bfa9463ba8b31.1660563403.git.wqu@suse.com> (raw)
In-Reply-To: <cover.1660563403.git.wqu@suse.com>

That function is only utilized inside fat driver, unexport it.

Signed-off-by: Qu Wenruo <wqu@suse.com>
---
 fs/fat/fat.c  | 4 ++--
 include/fat.h | 2 --
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/fs/fat/fat.c b/fs/fat/fat.c
index df9ea2c028fc..dcceccbcee0a 100644
--- a/fs/fat/fat.c
+++ b/fs/fat/fat.c
@@ -1243,8 +1243,8 @@ out_free_itr:
 	return ret;
 }
 
-int file_fat_read_at(const char *filename, loff_t pos, void *buffer,
-		     loff_t maxsize, loff_t *actread)
+static int file_fat_read_at(const char *filename, loff_t pos, void *buffer,
+			    loff_t maxsize, loff_t *actread)
 {
 	fsdata fsdata;
 	fat_itr *itr;
diff --git a/include/fat.h b/include/fat.h
index bd8e450b33a3..a9756fb4cd1b 100644
--- a/include/fat.h
+++ b/include/fat.h
@@ -200,8 +200,6 @@ static inline u32 sect_to_clust(fsdata *fsdata, int sect)
 int file_fat_detectfs(void);
 int fat_exists(const char *filename);
 int fat_size(const char *filename, loff_t *size);
-int file_fat_read_at(const char *filename, loff_t pos, void *buffer,
-		     loff_t maxsize, loff_t *actread);
 int file_fat_read(const char *filename, void *buffer, int maxsize);
 int fat_set_blk_dev(struct blk_desc *rbdd, struct disk_partition *info);
 int fat_register_device(struct blk_desc *dev_desc, int part_no);
-- 
2.37.1


WARNING: multiple messages have this Message-ID (diff)
From: Qu Wenruo via Linux-erofs <linux-erofs@lists.ozlabs.org>
To: u-boot@lists.denx.de
Cc: trini@konsulko.com, joaomarcos.costa@bootlin.com,
	marek.behun@nic.cz, thomas.petazzoni@bootlin.com,
	miquel.raynal@bootlin.com, linux-erofs@lists.ozlabs.org,
	linux-btrfs@vger.kernel.org
Subject: [PATCH v3 1/8] fs: fat: unexport file_fat_read_at()
Date: Mon, 15 Aug 2022 19:45:12 +0800	[thread overview]
Message-ID: <45a6f44305500b3f7f3d5488ae8bfa9463ba8b31.1660563403.git.wqu@suse.com> (raw)
In-Reply-To: <cover.1660563403.git.wqu@suse.com>

That function is only utilized inside fat driver, unexport it.

Signed-off-by: Qu Wenruo <wqu@suse.com>
---
 fs/fat/fat.c  | 4 ++--
 include/fat.h | 2 --
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/fs/fat/fat.c b/fs/fat/fat.c
index df9ea2c028fc..dcceccbcee0a 100644
--- a/fs/fat/fat.c
+++ b/fs/fat/fat.c
@@ -1243,8 +1243,8 @@ out_free_itr:
 	return ret;
 }
 
-int file_fat_read_at(const char *filename, loff_t pos, void *buffer,
-		     loff_t maxsize, loff_t *actread)
+static int file_fat_read_at(const char *filename, loff_t pos, void *buffer,
+			    loff_t maxsize, loff_t *actread)
 {
 	fsdata fsdata;
 	fat_itr *itr;
diff --git a/include/fat.h b/include/fat.h
index bd8e450b33a3..a9756fb4cd1b 100644
--- a/include/fat.h
+++ b/include/fat.h
@@ -200,8 +200,6 @@ static inline u32 sect_to_clust(fsdata *fsdata, int sect)
 int file_fat_detectfs(void);
 int fat_exists(const char *filename);
 int fat_size(const char *filename, loff_t *size);
-int file_fat_read_at(const char *filename, loff_t pos, void *buffer,
-		     loff_t maxsize, loff_t *actread);
 int file_fat_read(const char *filename, void *buffer, int maxsize);
 int fat_set_blk_dev(struct blk_desc *rbdd, struct disk_partition *info);
 int fat_register_device(struct blk_desc *dev_desc, int part_no);
-- 
2.37.1


  reply	other threads:[~2022-08-15 11:45 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-15 11:45 [PATCH v3 0/8] U-boot: fs: add generic unaligned read offset handling Qu Wenruo via Linux-erofs
2022-08-15 11:45 ` Qu Wenruo
2022-08-15 11:45 ` Qu Wenruo [this message]
2022-08-15 11:45   ` [PATCH v3 1/8] fs: fat: unexport file_fat_read_at() Qu Wenruo via Linux-erofs
2022-08-15 11:45 ` [PATCH v3 2/8] fs: btrfs: fix a bug which no data get read if the length is not 0 Qu Wenruo
2022-08-15 11:45   ` Qu Wenruo via Linux-erofs
2022-08-15 11:45 ` [PATCH v3 3/8] fs: btrfs: fix a crash if specified range is beyond file size Qu Wenruo
2022-08-15 11:45   ` Qu Wenruo via Linux-erofs
2022-08-15 11:45 ` [PATCH v3 4/8] fs: btrfs: move the unaligned read code to _fs_read() for btrfs Qu Wenruo
2022-08-15 11:45   ` Qu Wenruo via Linux-erofs
2022-08-15 11:45 ` [PATCH v3 5/8] fs: ext4: rely on _fs_read() to handle leading unaligned block read Qu Wenruo
2022-08-15 11:45   ` Qu Wenruo via Linux-erofs
2022-08-15 11:45 ` [PATCH v3 6/8] fs: fat: rely on higher layer to get block aligned read range Qu Wenruo
2022-08-15 11:45   ` Qu Wenruo via Linux-erofs
2022-08-15 11:45 ` [PATCH v3 7/8] fs: ubifs: rely on higher layer to do unaligned read Qu Wenruo
2022-08-15 11:45   ` Qu Wenruo via Linux-erofs
2022-08-15 11:45 ` [PATCH v3 8/8] fs: erofs: add unaligned read range handling Qu Wenruo
2022-08-15 11:45   ` Qu Wenruo via Linux-erofs
2022-08-26 14:29 ` [PATCH v3 0/8] U-boot: fs: add generic unaligned read offset handling Tom Rini
2022-08-26 14:29   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45a6f44305500b3f7f3d5488ae8bfa9463ba8b31.1660563403.git.wqu@suse.com \
    --to=wqu@suse.com \
    --cc=jnhuang95@gmail.com \
    --cc=joaomarcos.costa@bootlin.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=marek.behun@nic.cz \
    --cc=miquel.raynal@bootlin.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.