From: "André Przywara" <andre.przywara@arm.com> To: Rob Herring <robh@kernel.org>, Liviu Dudau <liviu.dudau@arm.com>, Sudeep Holla <sudeep.holla@arm.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Mark Rutland <mark.rutland@arm.com>, Marc Zyngier <maz@kernel.org> Subject: Re: [PATCH v2 07/17] arm64: dts: arm: Fix GIC child nodes Date: Mon, 11 May 2020 09:48:21 +0100 [thread overview] Message-ID: <45a822aa-4cf6-3d83-7ebb-d354cd8380fa@arm.com> (raw) In-Reply-To: <20200507112430.183940-8-andre.przywara@arm.com> On 07/05/2020 12:24, Andre Przywara wrote: > The GIC DT nodes for the Arm Ltd. boards were not fully compliant with > the DT binding, which has certain expectations about child nodes and > their size and address cells values. > > Use smaller #address-cells and #size-cells values, as the binding > requests, and adjust the reg properties accordingly. ... and as innocent as this looks, this of course affects all interrupt-map properties *everywhere* in the tree, as they all refer to the GIC node and use its number of #address-cells for the map. My Juno r0 board still boots (which is why I haven't spotted this before), but some devices (timers) fail to initialise. Will adjust the maps accordingly in v3. Cheers, Andre > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > --- > arch/arm64/boot/dts/arm/foundation-v8-gicv2.dtsi | 2 +- > arch/arm64/boot/dts/arm/juno-base.dtsi | 14 +++++++------- > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/arch/arm64/boot/dts/arm/foundation-v8-gicv2.dtsi b/arch/arm64/boot/dts/arm/foundation-v8-gicv2.dtsi > index 61a1750fcdd6..c8ebffca12a7 100644 > --- a/arch/arm64/boot/dts/arm/foundation-v8-gicv2.dtsi > +++ b/arch/arm64/boot/dts/arm/foundation-v8-gicv2.dtsi > @@ -8,7 +8,7 @@ > gic: interrupt-controller@2c001000 { > compatible = "arm,cortex-a15-gic"; > #interrupt-cells = <3>; > - #address-cells = <2>; > + #address-cells = <0>; > interrupt-controller; > reg = <0x0 0x2c001000 0 0x1000>, > <0x0 0x2c002000 0 0x2000>, > diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi > index 3feefd61eb76..6d7b24a8e761 100644 > --- a/arch/arm64/boot/dts/arm/juno-base.dtsi > +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi > @@ -74,35 +74,35 @@ > <0x0 0x2c02f000 0 0x2000>, > <0x0 0x2c04f000 0 0x2000>, > <0x0 0x2c06f000 0 0x2000>; > - #address-cells = <2>; > + #address-cells = <1>; > #interrupt-cells = <3>; > - #size-cells = <2>; > + #size-cells = <1>; > interrupt-controller; > interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(6) | IRQ_TYPE_LEVEL_HIGH)>; > - ranges = <0 0 0 0x2c1c0000 0 0x40000>; > + ranges = <0 0 0x2c1c0000 0x40000>; > > v2m_0: v2m@0 { > compatible = "arm,gic-v2m-frame"; > msi-controller; > - reg = <0 0 0 0x10000>; > + reg = <0 0x10000>; > }; > > v2m@10000 { > compatible = "arm,gic-v2m-frame"; > msi-controller; > - reg = <0 0x10000 0 0x10000>; > + reg = <0x10000 0x10000>; > }; > > v2m@20000 { > compatible = "arm,gic-v2m-frame"; > msi-controller; > - reg = <0 0x20000 0 0x10000>; > + reg = <0x20000 0x10000>; > }; > > v2m@30000 { > compatible = "arm,gic-v2m-frame"; > msi-controller; > - reg = <0 0x30000 0 0x10000>; > + reg = <0x30000 0x10000>; > }; > }; > >
WARNING: multiple messages have this Message-ID (diff)
From: "André Przywara" <andre.przywara@arm.com> To: Rob Herring <robh@kernel.org>, Liviu Dudau <liviu.dudau@arm.com>, Sudeep Holla <sudeep.holla@arm.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Marc Zyngier <maz@kernel.org> Subject: Re: [PATCH v2 07/17] arm64: dts: arm: Fix GIC child nodes Date: Mon, 11 May 2020 09:48:21 +0100 [thread overview] Message-ID: <45a822aa-4cf6-3d83-7ebb-d354cd8380fa@arm.com> (raw) In-Reply-To: <20200507112430.183940-8-andre.przywara@arm.com> On 07/05/2020 12:24, Andre Przywara wrote: > The GIC DT nodes for the Arm Ltd. boards were not fully compliant with > the DT binding, which has certain expectations about child nodes and > their size and address cells values. > > Use smaller #address-cells and #size-cells values, as the binding > requests, and adjust the reg properties accordingly. ... and as innocent as this looks, this of course affects all interrupt-map properties *everywhere* in the tree, as they all refer to the GIC node and use its number of #address-cells for the map. My Juno r0 board still boots (which is why I haven't spotted this before), but some devices (timers) fail to initialise. Will adjust the maps accordingly in v3. Cheers, Andre > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > --- > arch/arm64/boot/dts/arm/foundation-v8-gicv2.dtsi | 2 +- > arch/arm64/boot/dts/arm/juno-base.dtsi | 14 +++++++------- > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/arch/arm64/boot/dts/arm/foundation-v8-gicv2.dtsi b/arch/arm64/boot/dts/arm/foundation-v8-gicv2.dtsi > index 61a1750fcdd6..c8ebffca12a7 100644 > --- a/arch/arm64/boot/dts/arm/foundation-v8-gicv2.dtsi > +++ b/arch/arm64/boot/dts/arm/foundation-v8-gicv2.dtsi > @@ -8,7 +8,7 @@ > gic: interrupt-controller@2c001000 { > compatible = "arm,cortex-a15-gic"; > #interrupt-cells = <3>; > - #address-cells = <2>; > + #address-cells = <0>; > interrupt-controller; > reg = <0x0 0x2c001000 0 0x1000>, > <0x0 0x2c002000 0 0x2000>, > diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi > index 3feefd61eb76..6d7b24a8e761 100644 > --- a/arch/arm64/boot/dts/arm/juno-base.dtsi > +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi > @@ -74,35 +74,35 @@ > <0x0 0x2c02f000 0 0x2000>, > <0x0 0x2c04f000 0 0x2000>, > <0x0 0x2c06f000 0 0x2000>; > - #address-cells = <2>; > + #address-cells = <1>; > #interrupt-cells = <3>; > - #size-cells = <2>; > + #size-cells = <1>; > interrupt-controller; > interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(6) | IRQ_TYPE_LEVEL_HIGH)>; > - ranges = <0 0 0 0x2c1c0000 0 0x40000>; > + ranges = <0 0 0x2c1c0000 0x40000>; > > v2m_0: v2m@0 { > compatible = "arm,gic-v2m-frame"; > msi-controller; > - reg = <0 0 0 0x10000>; > + reg = <0 0x10000>; > }; > > v2m@10000 { > compatible = "arm,gic-v2m-frame"; > msi-controller; > - reg = <0 0x10000 0 0x10000>; > + reg = <0x10000 0x10000>; > }; > > v2m@20000 { > compatible = "arm,gic-v2m-frame"; > msi-controller; > - reg = <0 0x20000 0 0x10000>; > + reg = <0x20000 0x10000>; > }; > > v2m@30000 { > compatible = "arm,gic-v2m-frame"; > msi-controller; > - reg = <0 0x30000 0 0x10000>; > + reg = <0x30000 0x10000>; > }; > }; > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-11 8:49 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-07 11:24 [PATCH v2 00/17] dts/dt-bindings: Fix Arm Ltd. ARMv8 "boards" Andre Przywara 2020-05-07 11:24 ` Andre Przywara 2020-05-07 11:24 ` [PATCH v2 01/17] dt-bindings: arm-smmu: Allow mmu-400,smmu-v1 compatible Andre Przywara 2020-05-07 11:24 ` [PATCH v2 01/17] dt-bindings: arm-smmu: Allow mmu-400, smmu-v1 compatible Andre Przywara 2020-05-07 11:24 ` Andre Przywara 2020-05-07 11:24 ` [PATCH v2 02/17] dt-bindings: arm: gic: Allow combining arm,gic-400 compatible strings Andre Przywara 2020-05-07 11:24 ` [PATCH v2 02/17] dt-bindings: arm: gic: Allow combining arm, gic-400 " Andre Przywara 2020-05-07 11:24 ` [PATCH v2 03/17] arm64: dts: arm: Fix node address fields Andre Przywara 2020-05-07 11:24 ` Andre Przywara 2020-05-07 11:24 ` [PATCH v2 04/17] arm64: dts: arm: FVP: Fix motherboard .dtsi Andre Przywara 2020-05-07 11:24 ` Andre Przywara 2020-05-07 11:24 ` [PATCH v2 05/17] arm64: dts: juno: Fix mem-timer Andre Przywara 2020-05-07 11:24 ` Andre Przywara 2020-05-07 11:24 ` [PATCH v2 06/17] arm64: dts: arm: Fix GIC compatible names Andre Przywara 2020-05-07 11:24 ` Andre Przywara 2020-05-11 8:56 ` Marc Zyngier 2020-05-11 8:56 ` Marc Zyngier 2020-05-07 11:24 ` [PATCH v2 07/17] arm64: dts: arm: Fix GIC child nodes Andre Przywara 2020-05-07 11:24 ` Andre Przywara 2020-05-11 8:48 ` André Przywara [this message] 2020-05-11 8:48 ` André Przywara 2020-05-07 11:24 ` [PATCH v2 08/17] arm64: dts: arm: Fix ITS node names and #msi-cells Andre Przywara 2020-05-07 11:24 ` Andre Przywara 2020-05-07 11:24 ` [PATCH v2 09/17] arm64: dts: juno: usb: Use proper DT node name Andre Przywara 2020-05-07 11:24 ` Andre Przywara 2020-05-07 11:24 ` [PATCH v2 10/17] arm64: dts: arm: Fix serial node names Andre Przywara 2020-05-07 11:24 ` Andre Przywara 2020-05-07 11:24 ` [PATCH v2 11/17] arm64: dts: fvp: Fix SMMU DT node Andre Przywara 2020-05-07 11:24 ` Andre Przywara 2020-05-07 11:24 ` [PATCH v2 12/17] arm64: dts: arm: Fix bus node names Andre Przywara 2020-05-07 11:24 ` Andre Przywara 2020-05-07 11:24 ` [PATCH v2 13/17] arm64: dts: juno: Fix GPU interrupt order Andre Przywara 2020-05-07 11:24 ` Andre Przywara 2020-05-07 11:24 ` [PATCH v2 14/17] arm64: dts: arm: Fix VExpress LED names Andre Przywara 2020-05-07 11:24 ` Andre Przywara 2020-05-07 11:24 ` [PATCH v2 15/17] arm64: dts: juno: Fix SCPI shared mem node name Andre Przywara 2020-05-07 11:24 ` Andre Przywara 2020-05-07 11:24 ` [PATCH v2 16/17] dt-bindings: mali-midgard: Allow dma-coherent Andre Przywara 2020-05-07 11:24 ` Andre Przywara 2020-05-07 11:24 ` Andre Przywara 2020-05-07 11:24 ` [PATCH v2 17/17] dt-bindings: ehci/ohci: Allow iommus property Andre Przywara 2020-05-07 11:24 ` Andre Przywara 2020-05-07 14:04 ` [PATCH v2 00/17] dts/dt-bindings: Fix Arm Ltd. ARMv8 "boards" Will Deacon 2020-05-07 14:04 ` Will Deacon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=45a822aa-4cf6-3d83-7ebb-d354cd8380fa@arm.com \ --to=andre.przywara@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=liviu.dudau@arm.com \ --cc=lorenzo.pieralisi@arm.com \ --cc=mark.rutland@arm.com \ --cc=maz@kernel.org \ --cc=robh@kernel.org \ --cc=sudeep.holla@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.