From: Jaewon Kim <jaewon02.kim@samsung.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Tomasz Figa <tomasz.figa@gmail.com>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Alim Akhtar <alim.akhtar@samsung.com>, Linus Walleij <linus.walleij@linaro.org>, Rob Herring <robh+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Peter Griffin <peter.griffin@linaro.org>, semen.protsenko@linaro.org Subject: Re: [PATCH 1/3] dt-bindings: pinctrl: samsung: use Exynos7 fallbacks for newer wake-up controllers Date: Thu, 23 Nov 2023 16:06:00 +0900 [thread overview] Message-ID: <45b0f9e2-f97a-1b60-b40f-d84831027d00@samsung.com> (raw) In-Reply-To: <20231122200407.423264-1-krzysztof.kozlowski@linaro.org> On 23. 11. 23. 05:04, Krzysztof Kozlowski wrote: > Older ARM8 SoCs like Exynos5433, Exynos7 and Exynos7885 have the pin > controller with wake-up interrupts muxed, thus the wake-up interrupt > controller device node has interrupts property, while its pin banks > might not (because they are muxed by the wake-up controller). > > Newer SoCs like Exynos850 and ExynosAutov9 do not used muxed wake-up > interrupts: > 1. Wake-up interrupt controller device node has no interrupts, > 2. Its pin banks have interrupts (since there is no muxing). > > Their programming interface is however still compatible with Exynos7, > thus change the bindings to express this: retain compatibility with > Exynos7 and add new compatibility fallback of Exynos850 in newer > designs. > > No driver changes are needed. This is necessary only to properly > describe DTS. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Acked-by: Jaewon Kim <jaewon02.kim@samsung.com> I will also apply it to ExynosAutov920 DT patch. Thanks Jaewon Kim > > --- > > Cc: Peter Griffin <peter.griffin@linaro.org> > Cc: semen.protsenko@linaro.org > Cc: Jaewon Kim <jaewon02.kim@samsung.com> > --- > .../samsung,pinctrl-wakeup-interrupt.yaml | 25 +++++++++++-------- > 1 file changed, 15 insertions(+), 10 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml > index 1b75abebb953..2bafa867aea2 100644 > --- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml > @@ -36,13 +36,17 @@ properties: > - samsung,s5pv210-wakeup-eint > - samsung,exynos4210-wakeup-eint > - samsung,exynos7-wakeup-eint > - - samsung,exynos850-wakeup-eint > - - samsung,exynosautov9-wakeup-eint > - - samsung,exynosautov920-wakeup-eint > - items: > - enum: > - samsung,exynos5433-wakeup-eint > - samsung,exynos7885-wakeup-eint > + - samsung,exynos850-wakeup-eint > + - const: samsung,exynos7-wakeup-eint > + - items: > + - enum: > + - samsung,exynosautov9-wakeup-eint > + - samsung,exynosautov920-wakeup-eint > + - const: samsung,exynos850-wakeup-eint > - const: samsung,exynos7-wakeup-eint > > interrupts: > @@ -86,11 +90,14 @@ allOf: > - if: > properties: > compatible: > - contains: > - enum: > - - samsung,s5pv210-wakeup-eint > - - samsung,exynos4210-wakeup-eint > - - samsung,exynos7-wakeup-eint > + # Match without "contains", to skip newer variants which are still > + # compatible with samsung,exynos7-wakeup-eint > + enum: > + - samsung,s5pv210-wakeup-eint > + - samsung,exynos4210-wakeup-eint > + - samsung,exynos5433-wakeup-eint > + - samsung,exynos7-wakeup-eint > + - samsung,exynos7885-wakeup-eint > then: > properties: > interrupts: > @@ -105,8 +112,6 @@ allOf: > contains: > enum: > - samsung,exynos850-wakeup-eint > - - samsung,exynosautov9-wakeup-eint > - - samsung,exynosautov920-wakeup-eint > then: > properties: > interrupts: false
WARNING: multiple messages have this Message-ID (diff)
From: Jaewon Kim <jaewon02.kim@samsung.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Tomasz Figa <tomasz.figa@gmail.com>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Alim Akhtar <alim.akhtar@samsung.com>, Linus Walleij <linus.walleij@linaro.org>, Rob Herring <robh+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Peter Griffin <peter.griffin@linaro.org>, semen.protsenko@linaro.org Subject: Re: [PATCH 1/3] dt-bindings: pinctrl: samsung: use Exynos7 fallbacks for newer wake-up controllers Date: Thu, 23 Nov 2023 16:06:00 +0900 [thread overview] Message-ID: <45b0f9e2-f97a-1b60-b40f-d84831027d00@samsung.com> (raw) In-Reply-To: <20231122200407.423264-1-krzysztof.kozlowski@linaro.org> On 23. 11. 23. 05:04, Krzysztof Kozlowski wrote: > Older ARM8 SoCs like Exynos5433, Exynos7 and Exynos7885 have the pin > controller with wake-up interrupts muxed, thus the wake-up interrupt > controller device node has interrupts property, while its pin banks > might not (because they are muxed by the wake-up controller). > > Newer SoCs like Exynos850 and ExynosAutov9 do not used muxed wake-up > interrupts: > 1. Wake-up interrupt controller device node has no interrupts, > 2. Its pin banks have interrupts (since there is no muxing). > > Their programming interface is however still compatible with Exynos7, > thus change the bindings to express this: retain compatibility with > Exynos7 and add new compatibility fallback of Exynos850 in newer > designs. > > No driver changes are needed. This is necessary only to properly > describe DTS. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Acked-by: Jaewon Kim <jaewon02.kim@samsung.com> I will also apply it to ExynosAutov920 DT patch. Thanks Jaewon Kim > > --- > > Cc: Peter Griffin <peter.griffin@linaro.org> > Cc: semen.protsenko@linaro.org > Cc: Jaewon Kim <jaewon02.kim@samsung.com> > --- > .../samsung,pinctrl-wakeup-interrupt.yaml | 25 +++++++++++-------- > 1 file changed, 15 insertions(+), 10 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml > index 1b75abebb953..2bafa867aea2 100644 > --- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml > @@ -36,13 +36,17 @@ properties: > - samsung,s5pv210-wakeup-eint > - samsung,exynos4210-wakeup-eint > - samsung,exynos7-wakeup-eint > - - samsung,exynos850-wakeup-eint > - - samsung,exynosautov9-wakeup-eint > - - samsung,exynosautov920-wakeup-eint > - items: > - enum: > - samsung,exynos5433-wakeup-eint > - samsung,exynos7885-wakeup-eint > + - samsung,exynos850-wakeup-eint > + - const: samsung,exynos7-wakeup-eint > + - items: > + - enum: > + - samsung,exynosautov9-wakeup-eint > + - samsung,exynosautov920-wakeup-eint > + - const: samsung,exynos850-wakeup-eint > - const: samsung,exynos7-wakeup-eint > > interrupts: > @@ -86,11 +90,14 @@ allOf: > - if: > properties: > compatible: > - contains: > - enum: > - - samsung,s5pv210-wakeup-eint > - - samsung,exynos4210-wakeup-eint > - - samsung,exynos7-wakeup-eint > + # Match without "contains", to skip newer variants which are still > + # compatible with samsung,exynos7-wakeup-eint > + enum: > + - samsung,s5pv210-wakeup-eint > + - samsung,exynos4210-wakeup-eint > + - samsung,exynos5433-wakeup-eint > + - samsung,exynos7-wakeup-eint > + - samsung,exynos7885-wakeup-eint > then: > properties: > interrupts: > @@ -105,8 +112,6 @@ allOf: > contains: > enum: > - samsung,exynos850-wakeup-eint > - - samsung,exynosautov9-wakeup-eint > - - samsung,exynosautov920-wakeup-eint > then: > properties: > interrupts: false _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-11-23 7:08 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20231122200609epcas2p1da5f138359da3a0be4af4fbc25f2a8f5@epcas2p1.samsung.com> 2023-11-22 20:04 ` [PATCH 1/3] dt-bindings: pinctrl: samsung: use Exynos7 fallbacks for newer wake-up controllers Krzysztof Kozlowski 2023-11-22 20:04 ` Krzysztof Kozlowski 2023-11-22 20:04 ` [PATCH 2/3] arm64: dts: exynos850: use Exynos7 fallbacks for pin " Krzysztof Kozlowski 2023-11-22 20:04 ` Krzysztof Kozlowski 2023-11-24 7:43 ` (subset) " Krzysztof Kozlowski 2023-11-24 7:43 ` Krzysztof Kozlowski 2023-11-22 20:04 ` [PATCH 3/3] arm64: dts: exynosautov9: " Krzysztof Kozlowski 2023-11-22 20:04 ` Krzysztof Kozlowski 2023-11-24 7:43 ` (subset) " Krzysztof Kozlowski 2023-11-24 7:43 ` Krzysztof Kozlowski 2023-11-23 7:06 ` Jaewon Kim [this message] 2023-11-23 7:06 ` [PATCH 1/3] dt-bindings: pinctrl: samsung: use Exynos7 fallbacks for newer " Jaewon Kim 2023-11-23 17:42 ` Conor Dooley 2023-11-23 17:42 ` Conor Dooley 2023-11-24 7:41 ` (subset) " Krzysztof Kozlowski 2023-11-24 7:41 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=45b0f9e2-f97a-1b60-b40f-d84831027d00@samsung.com \ --to=jaewon02.kim@samsung.com \ --cc=alim.akhtar@samsung.com \ --cc=conor+dt@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=krzysztof.kozlowski@linaro.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=peter.griffin@linaro.org \ --cc=robh+dt@kernel.org \ --cc=s.nawrocki@samsung.com \ --cc=semen.protsenko@linaro.org \ --cc=tomasz.figa@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.