Re: [PATCH 3/3] reftable tests: avoid "int" overflow, use "uint64_t"

From: Johannes Sixt <j6t@kdbg.org>
To: Taylor Blau <me@ttaylorr.com>, Han-Wen Nienhuys <hanwen@google.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
	"Johannes Schindelin" <johannes.schindelin@gmx.de>
Subject: Re: [PATCH 3/3] reftable tests: avoid "int" overflow, use "uint64_t"
Date: Tue, 11 Jan 2022 21:08:46 +0100	[thread overview]
Message-ID: <45baffd7-c9f3-cc52-47b4-ea0fee0182a8@kdbg.org> (raw)
In-Reply-To: <Yd3dao5Qh5yl/cBs@nand.local>

Am 11.01.22 um 20:41 schrieb Taylor Blau:
> On Tue, Jan 11, 2022 at 08:31:47PM +0100, Han-Wen Nienhuys wrote:
>> On Tue, Jan 11, 2022 at 8:28 PM Taylor Blau <me@ttaylorr.com> wrote:
>>> In any case, you're only setting the lower half of `min` high. Maybe:
>>>
>>>     uint64_t min = ~0ul;
>>
>> yeah, that works.
> 
> I'm pretty sure this is OK on 32-bit systems, too, but confirmation from
> somebody more confident than I in this area would be welcome :).

It does not work on Windows: unsigned long is 32 bits wide. You have to
make it

   uint64_t min = ~(uint64_t)0;

-- Hannes