From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com> To: git@vger.kernel.org Cc: "Junio C Hamano" <gitster@pobox.com>, "Johannes Schindelin" <Johannes.Schindelin@gmx.de>, "Han-Wen Nienhuys" <hanwen@google.com>, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com> Subject: [PATCH 0/3] Fix SunCC compiler complaints new in v2.35.0-rc0 Date: Tue, 11 Jan 2022 17:40:20 +0100 [thread overview] Message-ID: <cover-0.3-00000000000-20220111T163908Z-avarab@gmail.com> (raw) This trivial set of patches fixes compiler complaints from SunCC on Solaris that are new in v2.35.0-rc0. The first two are only a minor annoyance, and not the first or only warnings of those categories that we emit, but if we can avoid adding new ones... The third one is a generic integer overflow bug, and will probably result in logic errors or failures in the reftable tests on some other platform. Ævar Arnfjörð Bjarmason (3): test-tool genzeros: initialize "zeros" to avoid SunCC warning reftable: remove unreachable "return" statements reftable tests: avoid "int" overflow, use "uint64_t" reftable/merged_test.c | 4 ++-- reftable/refname.c | 1 - reftable/writer.c | 1 - t/helper/test-genzeros.c | 3 +-- 4 files changed, 3 insertions(+), 6 deletions(-) -- 2.35.0.rc0.844.gb5945183dcf
WARNING: multiple messages have this Message-ID (diff)
From: Emily Shaffer <emilyshaffer@google.com> To: git-core-auto+context-review@google.com, git@vger.kernel.org Subject: [PATCH 0/3] Fix SunCC compiler complaints new in v2.35.0-rc0 Date: Tue, 11 Jan 2022 17:21:30 -0800 [thread overview] Message-ID: <cover-0.3-00000000000-20220111T163908Z-avarab@gmail.com> (raw) Message-ID: <20220112012130.oJLS-HIfgXXTRt8-YaKc-N_UzKBKqz23dw82jFg3w0w@z> (raw) From: Ævar Arnfjörð Bjarmason <avarab@gmail.com> This trivial set of patches fixes compiler complaints from SunCC on Solaris that are new in v2.35.0-rc0. The first two are only a minor annoyance, and not the first or only warnings of those categories that we emit, but if we can avoid adding new ones... The third one is a generic integer overflow bug, and will probably result in logic errors or failures in the reftable tests on some other platform. Ævar Arnfjörð Bjarmason (3): test-tool genzeros: initialize "zeros" to avoid SunCC warning reftable: remove unreachable "return" statements reftable tests: avoid "int" overflow, use "uint64_t" reftable/merged_test.c | 4 ++-- reftable/refname.c | 1 - reftable/writer.c | 1 - t/helper/test-genzeros.c | 3 +-- 4 files changed, 3 insertions(+), 6 deletions(-)
next reply other threads:[~2022-01-11 16:40 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-11 16:40 Ævar Arnfjörð Bjarmason [this message] 2022-01-12 1:21 ` [PATCH 0/3] Fix SunCC compiler complaints new in v2.35.0-rc0 Emily Shaffer 2022-01-11 16:40 ` [PATCH 1/3] test-tool genzeros: initialize "zeros" to avoid SunCC warning Ævar Arnfjörð Bjarmason 2022-01-11 19:06 ` Taylor Blau 2022-01-12 14:21 ` Johannes Schindelin 2022-01-12 19:10 ` Taylor Blau 2022-01-13 10:08 ` Ævar Arnfjörð Bjarmason 2022-01-13 15:31 ` Johannes Schindelin 2022-01-13 17:38 ` Junio C Hamano 2022-01-11 16:40 ` [PATCH 2/3] reftable: remove unreachable "return" statements Ævar Arnfjörð Bjarmason 2022-01-11 19:16 ` Taylor Blau 2022-01-12 12:47 ` Ævar Arnfjörð Bjarmason 2022-01-12 19:19 ` Taylor Blau 2022-01-13 10:29 ` Ævar Arnfjörð Bjarmason 2022-01-13 15:39 ` Johannes Schindelin 2022-01-13 20:17 ` Johannes Sixt 2022-01-13 21:37 ` Junio C Hamano 2022-01-11 16:40 ` [PATCH 3/3] reftable tests: avoid "int" overflow, use "uint64_t" Ævar Arnfjörð Bjarmason 2022-01-11 19:28 ` Taylor Blau 2022-01-11 19:31 ` Han-Wen Nienhuys 2022-01-11 19:41 ` Taylor Blau 2022-01-11 20:08 ` Johannes Sixt 2022-01-11 20:18 ` Taylor Blau 2022-01-11 20:21 ` Johannes Sixt 2022-01-11 20:24 ` Taylor Blau 2022-01-12 14:18 ` Johannes Schindelin 2022-01-12 19:02 ` Junio C Hamano 2022-01-12 19:07 ` Taylor Blau 2022-01-13 10:04 ` Ævar Arnfjörð Bjarmason 2022-01-13 21:38 ` Junio C Hamano 2022-01-11 17:06 ` [PATCH 0/3] Fix SunCC compiler complaints new in v2.35.0-rc0 Han-Wen Nienhuys 2022-01-11 18:36 ` René Scharfe 2022-01-12 1:22 ` Emily Shaffer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover-0.3-00000000000-20220111T163908Z-avarab@gmail.com \ --to=avarab@gmail.com \ --cc=Johannes.Schindelin@gmx.de \ --cc=git@vger.kernel.org \ --cc=gitster@pobox.com \ --cc=hanwen@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.