From: David Hildenbrand <david@redhat.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
linux-mips@linux-mips.org, kvm-ppc@vger.kernel.org,
linux-s390@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Christoffer Dall <cdall@linaro.org>,
Marc Zyngier <marc.zyngier@arm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Cornelia Huck <cohuck@redhat.com>,
James Hogan <james.hogan@imgtec.com>,
Paul Mackerras <paulus@ozlabs.org>,
Alexander Graf <agraf@suse.com>
Subject: Re: [PATCH RFC v3 7/9] KVM: add kvm_free_vcpus and kvm_arch_free_vcpus
Date: Tue, 22 Aug 2017 16:18:59 +0200 [thread overview]
Message-ID: <45e07499-e60c-5289-f439-9c51f59866ec@redhat.com> (raw)
In-Reply-To: <20170821203530.9266-8-rkrcmar@redhat.com>
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 33a15e176927..0d2d8b0c785c 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -750,6 +750,23 @@ static void kvm_destroy_devices(struct kvm *kvm)
> }
> }
>
> +void kvm_free_vcpus(struct kvm *kvm)
> +{
> + int i;
> +
> + kvm_arch_free_vcpus(kvm);
I wonder if it would be possible to get rid of kvm_arch_free_vcpus(kvm)
completely and simply call
kvm_for_each_vcpu(i, vcpu, kvm)
kvm_arch_vcpu_free(vcpu);
at that point.
Would certainly require some refactoring, and I am not sure if we could
modify the special mmu handling for x86 ("Unpin any mmu pages first.").
But if in doubt, that part could be moved to kvm_arch_destroy_vm(), just
before calling kvm_free_vcpus().
> +
> + mutex_lock(&kvm->lock);
> +
> + i = atomic_read(&kvm->online_vcpus);
> + atomic_set(&kvm->online_vcpus, 0);
i = atomic_xchg(&kvm->online_vcpus, 0);
> +
> + while (i--)
> + kvm->vcpus[i] = NULL;
> +
> + mutex_unlock(&kvm->lock);
> +}
> +
> static void kvm_destroy_vm(struct kvm *kvm)
> {
> int i;
>
--
Thanks,
David
WARNING: multiple messages have this Message-ID (diff)
From: david@redhat.com (David Hildenbrand)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC v3 7/9] KVM: add kvm_free_vcpus and kvm_arch_free_vcpus
Date: Tue, 22 Aug 2017 16:18:59 +0200 [thread overview]
Message-ID: <45e07499-e60c-5289-f439-9c51f59866ec@redhat.com> (raw)
In-Reply-To: <20170821203530.9266-8-rkrcmar@redhat.com>
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 33a15e176927..0d2d8b0c785c 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -750,6 +750,23 @@ static void kvm_destroy_devices(struct kvm *kvm)
> }
> }
>
> +void kvm_free_vcpus(struct kvm *kvm)
> +{
> + int i;
> +
> + kvm_arch_free_vcpus(kvm);
I wonder if it would be possible to get rid of kvm_arch_free_vcpus(kvm)
completely and simply call
kvm_for_each_vcpu(i, vcpu, kvm)
kvm_arch_vcpu_free(vcpu);
at that point.
Would certainly require some refactoring, and I am not sure if we could
modify the special mmu handling for x86 ("Unpin any mmu pages first.").
But if in doubt, that part could be moved to kvm_arch_destroy_vm(), just
before calling kvm_free_vcpus().
> +
> + mutex_lock(&kvm->lock);
> +
> + i = atomic_read(&kvm->online_vcpus);
> + atomic_set(&kvm->online_vcpus, 0);
i = atomic_xchg(&kvm->online_vcpus, 0);
> +
> + while (i--)
> + kvm->vcpus[i] = NULL;
> +
> + mutex_unlock(&kvm->lock);
> +}
> +
> static void kvm_destroy_vm(struct kvm *kvm)
> {
> int i;
>
--
Thanks,
David
WARNING: multiple messages have this Message-ID (diff)
From: David Hildenbrand <david@redhat.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
linux-mips@linux-mips.org, kvm-ppc@vger.kernel.org,
linux-s390@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Christoffer Dall <cdall@linaro.org>,
Marc Zyngier <marc.zyngier@arm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Cornelia Huck <cohuck@redhat.com>,
James Hogan <james.hogan@imgtec.com>,
Paul Mackerras <paulus@ozlabs.org>,
Alexander Graf <agraf@suse.com>
Subject: Re: [PATCH RFC v3 7/9] KVM: add kvm_free_vcpus and kvm_arch_free_vcpus
Date: Tue, 22 Aug 2017 14:18:59 +0000 [thread overview]
Message-ID: <45e07499-e60c-5289-f439-9c51f59866ec@redhat.com> (raw)
In-Reply-To: <20170821203530.9266-8-rkrcmar@redhat.com>
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 33a15e176927..0d2d8b0c785c 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -750,6 +750,23 @@ static void kvm_destroy_devices(struct kvm *kvm)
> }
> }
>
> +void kvm_free_vcpus(struct kvm *kvm)
> +{
> + int i;
> +
> + kvm_arch_free_vcpus(kvm);
I wonder if it would be possible to get rid of kvm_arch_free_vcpus(kvm)
completely and simply call
kvm_for_each_vcpu(i, vcpu, kvm)
kvm_arch_vcpu_free(vcpu);
at that point.
Would certainly require some refactoring, and I am not sure if we could
modify the special mmu handling for x86 ("Unpin any mmu pages first.").
But if in doubt, that part could be moved to kvm_arch_destroy_vm(), just
before calling kvm_free_vcpus().
> +
> + mutex_lock(&kvm->lock);
> +
> + i = atomic_read(&kvm->online_vcpus);
> + atomic_set(&kvm->online_vcpus, 0);
i = atomic_xchg(&kvm->online_vcpus, 0);
> +
> + while (i--)
> + kvm->vcpus[i] = NULL;
> +
> + mutex_unlock(&kvm->lock);
> +}
> +
> static void kvm_destroy_vm(struct kvm *kvm)
> {
> int i;
>
--
Thanks,
David
next prev parent reply other threads:[~2017-08-22 14:19 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-21 20:35 [PATCH RFC v3 0/9] KVM: allow dynamic kvm->vcpus array Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-21 20:35 ` [PATCH RFC v3 1/9] KVM: s390: optimize detection of started vcpus Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-22 7:26 ` Christian Borntraeger
2017-08-22 7:26 ` Christian Borntraeger
2017-08-22 7:26 ` Christian Borntraeger
2017-08-22 11:31 ` David Hildenbrand
2017-08-22 11:31 ` David Hildenbrand
2017-08-22 11:31 ` David Hildenbrand
2017-08-29 11:23 ` Cornelia Huck
2017-08-29 11:23 ` Cornelia Huck
2017-08-29 11:23 ` Cornelia Huck
2017-08-29 11:23 ` Cornelia Huck
2017-08-29 12:05 ` David Hildenbrand
2017-08-29 12:05 ` David Hildenbrand
2017-08-29 12:05 ` David Hildenbrand
2017-08-29 12:42 ` Cornelia Huck
2017-08-29 12:42 ` Cornelia Huck
2017-08-29 12:42 ` Cornelia Huck
2017-08-29 11:26 ` Cornelia Huck
2017-08-29 11:26 ` Cornelia Huck
2017-08-29 11:26 ` Cornelia Huck
2017-08-21 20:35 ` [PATCH RFC v3 2/9] KVM: arm/arm64: fix vcpu self-detection in vgic_v3_dispatch_sgi() Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-22 11:43 ` David Hildenbrand
2017-08-22 11:43 ` David Hildenbrand
2017-08-22 11:43 ` David Hildenbrand
2017-08-29 10:00 ` Christoffer Dall
2017-08-29 10:00 ` Christoffer Dall
2017-08-29 10:00 ` Christoffer Dall
2017-08-21 20:35 ` [PATCH RFC v3 3/9] KVM: remember position in kvm->vcpus array Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-22 11:44 ` David Hildenbrand
2017-08-22 11:44 ` David Hildenbrand
2017-08-22 11:44 ` David Hildenbrand
2017-08-29 11:30 ` Cornelia Huck
2017-08-29 11:30 ` Cornelia Huck
2017-08-29 11:30 ` Cornelia Huck
2017-08-21 20:35 ` [PATCH RFC v3 4/9] KVM: arm/arm64: use locking helpers in kvm_vgic_create() Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-22 11:51 ` David Hildenbrand
2017-08-22 11:51 ` David Hildenbrand
2017-08-22 11:51 ` David Hildenbrand
2017-08-29 10:00 ` Christoffer Dall
2017-08-29 10:00 ` Christoffer Dall
2017-08-29 10:00 ` Christoffer Dall
2017-08-21 20:35 ` [PATCH RFC v3 5/9] KVM: remove unused __KVM_HAVE_ARCH_VM_ALLOC Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-21 20:35 ` [PATCH RFC v3 6/9] KVM: rework kvm_vcpu_on_spin loop Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-22 14:06 ` David Hildenbrand
2017-08-22 14:06 ` David Hildenbrand
2017-08-22 14:06 ` David Hildenbrand
2017-08-29 15:24 ` Cornelia Huck
2017-08-29 15:24 ` Cornelia Huck
2017-08-29 15:24 ` Cornelia Huck
2017-08-21 20:35 ` [PATCH RFC v3 7/9] KVM: add kvm_free_vcpus and kvm_arch_free_vcpus Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-22 14:18 ` David Hildenbrand [this message]
2017-08-22 14:18 ` David Hildenbrand
2017-08-22 14:18 ` David Hildenbrand
2017-08-29 13:00 ` Cornelia Huck
2017-08-29 13:00 ` Cornelia Huck
2017-08-29 13:00 ` Cornelia Huck
2017-08-21 20:35 ` [PATCH RFC v3 8/9] KVM: implement kvm_for_each_vcpu with a list Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-29 9:58 ` Christoffer Dall
2017-08-29 9:58 ` Christoffer Dall
2017-08-29 9:58 ` Christoffer Dall
2017-08-21 20:35 ` [PATCH RFC v3 9/9] KVM: split kvm->vcpus into chunks Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45e07499-e60c-5289-f439-9c51f59866ec@redhat.com \
--to=david@redhat.com \
--cc=agraf@suse.com \
--cc=borntraeger@de.ibm.com \
--cc=cdall@linaro.org \
--cc=cohuck@redhat.com \
--cc=james.hogan@imgtec.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-s390@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=paulus@ozlabs.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.