From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: shmobile: lager: enable Ether
Date: Mon, 13 May 2013 22:30:27 +0000 [thread overview]
Message-ID: <4649393.HiDLOXMspX@avalon> (raw)
In-Reply-To: <5190E4E9.20100@cogentembedded.com>
On Monday 13 May 2013 17:04:41 Sergei Shtylyov wrote:
> On 13.05.2013 4:40, Simon Horman wrote:
> > [ CC Laurent ]
> >
> >>> Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> >>> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> >>>
> >>> ---
> >>>
> >>> This patch has a run-time dependency on "sh_eth: add support for r8a7790
> >>> SoC".
> [...]
>
> >>> diff --git a/arch/arm/mach-shmobile/board-lager.c
> >>> b/arch/arm/mach-shmobile/board-lager.c index 6a1ba38..0b8112d 100644
> >>> --- a/arch/arm/mach-shmobile/board-lager.c
> >>> +++ b/arch/arm/mach-shmobile/board-lager.c
> >>
> >> [...]
> >>
> >>> @@ -59,6 +69,17 @@ static const struct pinctrl_map lager_pinctrl_map[] > >>> {
> >>>
> >>> /* SCIF1 (CN20: DEBUG SERIAL1) */
> >>> PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.7", "pfc-r8a7790",
> >>>
> >>> "scif1_data", "scif1"),
> >>>
> >>> + /* Ether */
> >>> + PIN_MAP_MUX_GROUP_DEFAULT("sh-eth", "pfc-r8a7790",
> >>> + "eth_link", "eth"),
> >>> + PIN_MAP_MUX_GROUP_DEFAULT("sh-eth", "pfc-r8a7790",
> >>> + "eth_magic", "eth"),
> >>> + PIN_MAP_MUX_GROUP_DEFAULT("sh-eth", "pfc-r8a7790",
> >>> + "eth_mdio", "eth"),
> >>> + PIN_MAP_MUX_GROUP_DEFAULT("sh-eth", "pfc-r8a7790",
> >>> + "eth_rmii", "eth"),
> >>>
> >> I thought MDIO bus was a part of RMII. At least Wikipedia told
> >>
> >> me so. :-)
> >
> > Is the implication that you think that the eth_mdio and eth_rmii
> > groups should be combined?
MDIO is used by RMII, MII and (R)GMII. Merging eth_mdio and eth_rmii would
require duplicating the pins in all those ethernet-related functions.
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: shmobile: lager: enable Ether
Date: Tue, 14 May 2013 00:30:27 +0200 [thread overview]
Message-ID: <4649393.HiDLOXMspX@avalon> (raw)
In-Reply-To: <5190E4E9.20100@cogentembedded.com>
On Monday 13 May 2013 17:04:41 Sergei Shtylyov wrote:
> On 13.05.2013 4:40, Simon Horman wrote:
> > [ CC Laurent ]
> >
> >>> Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> >>> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> >>>
> >>> ---
> >>>
> >>> This patch has a run-time dependency on "sh_eth: add support for r8a7790
> >>> SoC".
> [...]
>
> >>> diff --git a/arch/arm/mach-shmobile/board-lager.c
> >>> b/arch/arm/mach-shmobile/board-lager.c index 6a1ba38..0b8112d 100644
> >>> --- a/arch/arm/mach-shmobile/board-lager.c
> >>> +++ b/arch/arm/mach-shmobile/board-lager.c
> >>
> >> [...]
> >>
> >>> @@ -59,6 +69,17 @@ static const struct pinctrl_map lager_pinctrl_map[] =
> >>> {
> >>>
> >>> /* SCIF1 (CN20: DEBUG SERIAL1) */
> >>> PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.7", "pfc-r8a7790",
> >>>
> >>> "scif1_data", "scif1"),
> >>>
> >>> + /* Ether */
> >>> + PIN_MAP_MUX_GROUP_DEFAULT("sh-eth", "pfc-r8a7790",
> >>> + "eth_link", "eth"),
> >>> + PIN_MAP_MUX_GROUP_DEFAULT("sh-eth", "pfc-r8a7790",
> >>> + "eth_magic", "eth"),
> >>> + PIN_MAP_MUX_GROUP_DEFAULT("sh-eth", "pfc-r8a7790",
> >>> + "eth_mdio", "eth"),
> >>> + PIN_MAP_MUX_GROUP_DEFAULT("sh-eth", "pfc-r8a7790",
> >>> + "eth_rmii", "eth"),
> >>>
> >> I thought MDIO bus was a part of RMII. At least Wikipedia told
> >>
> >> me so. :-)
> >
> > Is the implication that you think that the eth_mdio and eth_rmii
> > groups should be combined?
MDIO is used by RMII, MII and (R)GMII. Merging eth_mdio and eth_rmii would
require duplicating the pins in all those ethernet-related functions.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-05-13 22:30 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-10 8:05 [PATCH 0/2] ARM: shmobile: lager: enable Ether Simon Horman
2013-05-10 8:05 ` Simon Horman
2013-05-10 8:05 ` [PATCH 1/2] ARM: shmobile: r8a7790: add Ether support Simon Horman
2013-05-10 8:05 ` Simon Horman
2013-05-10 10:26 ` Sergei Shtylyov
2013-05-10 10:26 ` Sergei Shtylyov
2013-05-13 0:43 ` Simon Horman
2013-05-13 0:43 ` Simon Horman
2013-05-13 13:07 ` Sergei Shtylyov
2013-05-13 13:07 ` Sergei Shtylyov
2013-05-14 0:29 ` Simon Horman
2013-05-14 0:29 ` Simon Horman
2013-10-15 9:08 ` [PATCH 1/2] ARM: shmobile: r8a7790: add QSPI support Cao Minh Hiep
2013-10-16 0:39 ` Simon Horman
2013-10-16 0:46 ` Magnus Damm
2013-10-16 1:49 ` Simon Horman
2013-10-16 11:03 ` カオ ミン ヒェップ
2013-10-17 0:13 ` Kuninori Morimoto
2013-10-17 0:52 ` Simon Horman
2013-10-17 1:40 ` Simon Horman
2013-10-17 3:27 ` カオ ミン ヒェップ
2013-10-17 4:32 ` Kuninori Morimoto
2013-10-17 8:04 ` カオ ミン ヒェップ
2013-10-18 0:44 ` Kuninori Morimoto
2013-10-18 1:06 ` カオ ミン ヒェップ
2013-12-13 11:52 ` [PATCH 1/2] arm: shmobile: r8a7790: Add PCI USB host clock support Valentine Barshak
2013-12-19 17:57 ` [PATCH 1/2] arm: shmobile: r8a7790: Add SATA clock Valentine Barshak
2013-12-24 18:55 ` [PATCH 1/2] arm: shmobile: r8a7790: Add VIN clock support Valentine Barshak
2013-12-26 15:35 ` Valentine Barshak
2014-01-06 8:32 ` [PATCH 1/2] ARM: shmobile: r8a7790: add Audio DMAC clock Kuninori Morimoto
2014-01-08 4:17 ` Simon Horman
2014-01-08 4:23 ` Simon Horman
2014-01-08 6:08 ` Kuninori Morimoto
2014-01-09 8:07 ` Simon Horman
2014-04-08 16:35 ` [PATCH 1/2] ARM: shmobile: r8a7790: Add VSP1 devices to DT Laurent Pinchart
2014-05-29 10:59 ` [PATCH 1/2] arm: shmobile: r8a7790: add USB3.0 clocks to device tree Yoshihiro Shimoda
2014-05-29 10:59 ` Yoshihiro Shimoda
2014-05-29 10:59 ` Yoshihiro Shimoda
2014-06-26 0:52 ` [PATCH 1/2] ARM: shmobile: r8a7790: add DVC support for sound node on DTSI Kuninori Morimoto
2014-09-13 23:36 ` [PATCH 1/2] ARM: shmobile: r8a7790: Add VSP1 devices to DT Laurent Pinchart
2014-09-14 17:58 ` Sergei Shtylyov
2014-09-14 23:32 ` Laurent Pinchart
2014-09-30 4:23 ` Simon Horman
2014-09-30 8:51 ` Laurent Pinchart
2014-09-30 23:55 ` Simon Horman
2015-01-08 1:55 ` [PATCH 1/2] ARM: shmobile: r8a7790: add SRC interrupt number on DTSI Kuninori Morimoto
2013-05-10 8:05 ` [PATCH 2/2] ARM: shmobile: lager: enable Ether Simon Horman
2013-05-10 8:05 ` Simon Horman
2013-05-10 10:35 ` Sergei Shtylyov
2013-05-10 10:35 ` Sergei Shtylyov
2013-05-13 0:40 ` Simon Horman
2013-05-13 0:40 ` Simon Horman
2013-05-13 13:04 ` Sergei Shtylyov
2013-05-13 13:04 ` Sergei Shtylyov
2013-05-13 22:30 ` Laurent Pinchart [this message]
2013-05-13 22:30 ` Laurent Pinchart
2013-05-13 22:31 ` Laurent Pinchart
2013-05-13 22:31 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4649393.HiDLOXMspX@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.